View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001937 | Slicer4 | Module Annotations | public | 2012-04-24 10:35 | 2017-06-07 23:27 |
Reporter | finetjul | Assigned To | jcfr | ||
Priority | normal | Severity | tweak | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.1.0 | ||||
Target Version | Slicer 4.3.0 | Fixed in Version | Slicer 4.3.0 | ||
Summary | 0001937: Remove Qt dependency from vtkMRMLAnnotationsLogic | ||||
Description | The module logics are not designed to use Qt internally. Related commit: http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=19937 | ||||
Tags | No tags attached. | ||||
The dependency was added due to the QtTreeView not updating on certain changes in the annotations, so the logic was triggering it. Also the CMakeLists.txt was probably mostly copied and not pared down initially. |
|
Seems that only the following is Qt dependent: |
|
This is in the HTML report functionality, so not core. I can have it just use the present directory instead unless there's a pure VTK way to get at the temporary path set in the Qt core application. |
|
You can maybe expose Get/SetTemporaryDirectory() methods that are set in teh setup() of the annotation module. But as stated by 0002416, such temp path should be available by MRML anyway. |
|
Pushed code here (in the same branch of its parent topic) |
|
Fixed in r22230 |
|
Closing resolved issues that have not been updated in more than 3 months |
|
Fix committed to 2145-support-for-installing-extension-from-file branch. |
|
Slicer: 2145-support-for-installing-extension-from-file 90ed1640 2013-07-22 16:53:54 Details Diff |
ENH: Remove Qt Dependency from vtkMRMLAnnotationLogic Following r22229, TemporaryPath can be accessible from MRML logics, the Qt dependency code can now be removed from vtkMRMLAnnotationsLogic. Fixes 0001937 From: Yuzheng Zhou <yuzheng.zhou@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@22230 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - Modules/Loadable/Annotations/Logic/CMakeLists.txt | Diff File | ||
mod - Modules/Loadable/Annotations/Logic/vtkSlicerAnnotationModuleLogic.cxx | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-04-24 10:35 | finetjul | New Issue | |
2012-04-24 10:35 | finetjul | Status | new => assigned |
2012-04-24 10:35 | finetjul | Assigned To | => nicole |
2012-04-24 10:44 | nicole | Note Added: 0004071 | |
2012-04-24 10:52 | finetjul | Note Added: 0004072 | |
2012-08-20 10:27 | nicole | Target Version | => Slicer 4.2.0 - Feature freeze Sept 1st 2012 |
2012-08-20 12:03 | jcfr | Target Version | Slicer 4.2.0 - Feature freeze Sept 1st 2012 => Slicer 4.2.5 |
2012-08-20 12:32 | finetjul | Relationship added | child of 0002416 |
2012-08-21 09:39 | jcfr | Target Version | Slicer 4.2.5 => Slicer 4.3.0 |
2013-07-09 08:44 | nicole | Note Added: 0008954 | |
2013-07-09 09:22 | finetjul | Note Added: 0008963 | |
2013-07-09 09:23 | finetjul | Relationship deleted | child of 0002416 |
2013-07-09 09:23 | finetjul | Relationship added | child of 0002416 |
2013-07-17 09:57 | jcfr | Assigned To | nicole => yuzheng |
2013-07-17 11:28 | yuzheng | Note Added: 0009105 | |
2013-07-17 11:28 | yuzheng | Status | assigned => resolved |
2013-07-22 12:55 | jcfr | Note Added: 0009166 | |
2013-07-22 12:55 | jcfr | Fixed in Version | => Slicer 4.3.0 |
2014-03-06 05:18 | jcfr | Note Added: 0011133 | |
2014-03-06 05:19 | jcfr | Status | resolved => closed |
2017-06-07 23:27 | jcfr | Changeset attached | => Slicer 2145-support-for-installing-extension-from-file 90ed1640 |
2017-06-07 23:27 | jcfr | Note Added: 0014628 | |
2017-06-07 23:27 | jcfr | Assigned To | yuzheng => jcfr |
2017-06-07 23:27 | jcfr | Resolution | open => fixed |