View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001915 | Slicer4 | Core: Base Code | public | 2012-04-17 17:36 | 2019-05-31 16:09 |
Reporter | ungi | Assigned To | jcfr | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Product Version | |||||
Target Version | Fixed in Version | Slicer 4.11.0 | |||
Summary | 0001915: Effect of matrix bottom row in Transforms module | ||||
Description | In the Transforms module, a value larger than 1.0 in the bottom row of a transform matrix (perspective projection part of the matrix) does not always make its effect in the other coordinates when an additional translation is applied. All values in the result matrix are capped by the Min Max values of the translation sliders when the sliders are changed. | ||||
Tags | No tags attached. | ||||
Several places in Slicer core and extensions the bottom row of the matrix is ignored (assumed to be [0 0 0 1]). Therefore, the cleanest solution would be to make the bottom row read-only in the GUI. |
|
@Chrystel: This could be done by adding a property named PerspectiveProjectionEditable to ctkVTKAbstractMatrixWidget In addition to Q_PROPERTY(bool PerspectiveProjectionEditable READ ...) the methods to add will be: bool perspectiveProjectionEditable()const; |
|
Reminder sent to: pieper @steve: What do you think of the solution proposed in note 9650 ? |
|
Reminder sent to: lassoan @Andras: Do you think adding a property "PerspectiveProjectionEditable" to ctkVTKAbstractMatrixWidget make sense ? |
|
@jcfr: I like the idea of hiding the row as described in #9650 |
|
I would prefer to have a non-editable 4-th row, as it makes clear that the matrix is a homogenous transformation. I think the property name could be more explicit, for example 'LastRowEditable'. |
|
By showing the last row the user could also verify that the values are indeed [0 0 0 1], as expected. |
|
Implementation is ready. Remaining tasks:
|
|
Fixed in Revision: 28279 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-04-17 17:36 | ungi | New Issue | |
2012-04-17 17:43 | finetjul | Project | Slicer3 => Slicer4 |
2012-04-18 06:12 | lassoan | Note Added: 0004041 | |
2012-08-20 07:49 | nicole | Assigned To | => finetjul |
2012-08-20 07:49 | nicole | Status | new => assigned |
2012-08-20 07:49 | nicole | Target Version | => Slicer 4.2.5 |
2012-08-21 09:39 | jcfr | Target Version | Slicer 4.2.5 => Slicer 4.3.0 |
2013-08-09 04:39 | finetjul | Target Version | Slicer 4.3.0 => Slicer 4.4.0 |
2013-08-09 04:43 | finetjul | Assigned To | finetjul => chrysteljuan |
2013-08-27 13:33 | jcfr | Note Added: 0009650 | |
2013-08-27 13:34 | jcfr | Note Added: 0009651 | |
2014-05-13 20:30 | jcfr | Assigned To | chrysteljuan => jcfr |
2014-05-13 20:30 | jcfr | Target Version | Slicer 4.4.0 => |
2014-05-13 20:31 | jcfr | Note Added: 0011838 | |
2014-05-13 20:35 | jcfr | Note Edited: 0011838 | |
2014-05-14 03:50 | pieper | Note Added: 0011842 | |
2014-05-14 15:12 | lassoan | Note Added: 0011859 | |
2014-05-14 15:13 | lassoan | Note Added: 0011860 | |
2014-08-26 15:24 | lassoan | Relationship added | has duplicate 0003818 |
2019-05-30 16:10 | lassoan | Note Added: 0016264 | |
2019-05-31 16:09 | lassoan | Status | assigned => resolved |
2019-05-31 16:09 | lassoan | Resolution | open => fixed |
2019-05-31 16:09 | lassoan | Fixed in Version | => Slicer 4.11.0 |
2019-05-31 16:09 | lassoan | Note Added: 0016265 |