View Issue Details

IDProjectCategoryView StatusLast Update
0001907Slicer4Core: Extensionspublic2017-06-10 08:51
Reporterfinetjul Assigned Tomatthew-woehlke  
PriorityhighSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformWindows 7OSOS Version
Product VersionSlicer 4.1.0 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0001907: Icons in "Manage Extensions" are default icons, not extension specific icons
Description

Icons in "Manage Extensions" are default icons, not extension specific icons

Steps To Reproduce

Open Slicer
Open Extension Manager
Install 1 extension
Go to "Manage Extensions(1)"
Icons are different from extension icon

TagsNo tags attached.

Relationships

child of 0003608 closedmatthew-woehlke ExtensionsManager: Add ability to view details page for installed extensions. 

Activities

kikinis

kikinis

2013-03-26 12:27

developer   ~0008246

This should get fixed

jcfr

jcfr

2014-04-01 07:37

administrator   ~0011501

For reference: https://github.com/mwoehlke-kitware/Slicer/tree/REBASE-1907-extension-icons-in-manager

matthew-woehlke

matthew-woehlke

2014-05-05 13:17

developer   ~0011704

Last edited: 2014-05-05 13:17

I have code for this, but it is waiting on refactoring changes via the branch to fix 0003608.

matthew-woehlke

matthew-woehlke

2014-05-13 09:57

developer   ~0011772

This has been implemented by https://github.com/mwoehlke-kitware/Slicer/tree/1907-extension-icons-in-manager.

jcfr

jcfr

2014-05-19 06:53

administrator   ~0011890

Nice work.
Please, integrate associated commit into Slicer trunk. Thanks

matthew-woehlke

matthew-woehlke

2014-05-19 10:27

developer   ~0011895

Fixed in r23199 - r23204.

Related Changesets

Import 2017-06-07 23:51:09: master ee1e583e

2014-05-19 14:18:41

mwoehlke

Details Diff
ENH: Load extension icon from disk

Change extension manager to attempt to load the icon for the extension
from disk, given the URL (which serves to provide a reasonable file
type, hopefully). For now this assumes that the icon already exists;
next, we'll want to try to download it if not.

Note that, rather than using the icon image directly, we render it as a
rounded rectangle in order to apply some rounding to the icon's corners,
for consistency with the web view which does something similar.

Issue 0001907

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23201 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerExtensionsManageWidget.cxx Diff File

Import 2017-06-07 23:51:09: master fc6d4fda

2014-05-19 14:18:42

mwoehlke

Details Diff
ENH: Implement downloading of extension icons

Change qSlicerExtensionsManageWidget to attempt to download icons for
extensions that don't already have an icon on disk. On successful
download, the icon is saved and applied to the extension list item.

Note that we will retry downloads for missing icons on first showing of
the extension manager. This seems like reasonable behavior. Missing
icons fall back to the default icon as before, and download errors are
silent.

Issue 0001907

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23202 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerExtensionsManageWidget.cxx Diff File
mod - Base/QTGUI/qSlicerExtensionsManageWidget.h Diff File

Issue History

Date Modified Username Field Change
2012-04-16 06:46 finetjul New Issue
2012-04-16 06:46 finetjul Status new => assigned
2012-04-16 06:46 finetjul Assigned To => jcfr
2012-08-21 12:59 jcfr Target Version => Slicer 4.3.0
2013-03-26 12:27 kikinis Note Added: 0008246
2013-03-26 14:30 jcfr Priority normal => high
2013-08-30 12:49 jcfr Target Version Slicer 4.3.0 => Slicer 4.3.1
2013-10-01 11:33 jcfr Target Version Slicer 4.3.1 => Slicer 4.3.2
2014-03-06 10:15 nicole Target Version Slicer 4.3.2 => Slicer 4.4.0
2014-03-07 10:08 jcfr Assigned To jcfr => matthew-woehlke
2014-03-26 13:37 matthew-woehlke Status assigned => acknowledged
2014-04-01 07:37 jcfr Note Added: 0011501
2014-05-05 13:16 matthew-woehlke Relationship added child of 0003608
2014-05-05 13:17 matthew-woehlke Note Added: 0011704
2014-05-05 13:17 matthew-woehlke Note Edited: 0011704
2014-05-12 11:28 matthew-woehlke Status acknowledged => confirmed
2014-05-13 09:57 matthew-woehlke Note Added: 0011772
2014-05-13 09:57 matthew-woehlke Status confirmed => feedback
2014-05-19 06:53 jcfr Note Added: 0011890
2014-05-19 06:53 jcfr Status feedback => assigned
2014-05-19 10:27 matthew-woehlke Note Added: 0011895
2014-05-19 10:27 matthew-woehlke Status assigned => resolved
2014-05-19 10:27 matthew-woehlke Resolution open => fixed
2014-05-19 11:32 jcfr Fixed in Version => Slicer 4.4.0
2014-06-04 06:09 jcfr Status resolved => closed
2017-06-10 08:51 Changeset attached => Slicer master fc6d4fda
2017-06-10 08:51 Changeset attached => Slicer master ee1e583e