0001892: Colors Module GUI: LUT label values issue

ID	Project	Category	View Status	Date Submitted	Last Update

0001892	Slicer4	Core: Base Code	public	2012-04-10 16:29	2017-06-07 23:27

Reporter	spujol	Assigned To	nicole
Priority	normal	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	Slicer 4.1.0 RC
Target Version	Slicer 4.3.0	Fixed in Version	Slicer 4.3.0

Summary	0001892: Colors Module GUI: LUT label values issue
Description	The labels values displayed in the Colors module start at label 0000001 whereas the Color tables start at label #0. As a result, the values displayed in the GUI of the Colors module are not consistent with the values displayed in the Data Probe. ( See screenshot below from the brain atlas where the cursor of the mouse is positioned in the white matter of the left cerebral hemisphere: the corresponding label value is 2 according to the Data Probe, and is listed as 3 in the GUI table).
Tags	No tags attached.

2012-04-10 16:29	Screen shot 2012-04-10 at 8.20.15 PM.png (442,493 bytes) Screen shot 2012-04-10 at 8.20.15 PM.png (442,493 bytes)

2013-08-23 12:06	ColorsTableIndexBug.png (14,543 bytes) ColorsTableIndexBug.png (14,543 bytes)

2013-08-23 12:06	col.txt (63 bytes) col.txt (63 bytes)

nicole 2013-08-23 12:07 administrator ~0009582	A simpler test case: load the attached col.txt, turn on hide empty colors and it's obvious how the indices are off by 1.

nicole 2013-08-26 09:39 administrator ~0009591	Fixed in svn 22331. http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22331

jcfr 2014-03-06 04:56 administrator ~0010838	Closing resolved issues that have not been updated in more than 3 months

Slicer: 2145-support-for-installing-extension-from-file eecc44de 2013-08-26 13:38:52 naucoin Details Diff	BUG: show the color indices rather than row number The Color GUI was showing a row number starting from 1 when displaying color table entries, which are 0 indexed. This led to a mismatch between the value shown in the data probe (and in the actual color node) versus what the user was being shown to be the color index. Overloaded the headerData method to, in the case of the vertical header display role to return the row index minus 1. The MRML color model defines a ColorEntryRole but it's still off by 1 from the color index. Testing of copying a color node exposed the fact that the new color node was not showing up in the Data module nor in the Save Data dialog, so updated CopyNode in the color logic to turn off the hide from editors flag on the new node. Issue 0001892 git-svn-id: http://svn.slicer.org/Slicer4/trunk@22331 3bd1e089-480b-0410-8dfb-8563597acbee
	mod - Libs/MRML/Logic/vtkMRMLColorLogic.cxx	Diff File
	mod - Libs/MRML/Widgets/qMRMLColorModel.cxx	Diff File
	mod - Libs/MRML/Widgets/qMRMLColorModel.h	Diff File

Date Modified	Username	Field	Change
2012-04-10 16:29	spujol	New Issue
2012-04-10 16:29	spujol	Status	new => assigned
2012-04-10 16:29	spujol	Assigned To	=> finetjul
2012-04-10 16:29	spujol	File Added: Screen shot 2012-04-10 at 8.20.15 PM.png
2012-08-22 05:56	jcfr	Target Version	=> Slicer 4.3.0
2013-08-08 11:35	nicole	Assigned To	finetjul => nicole
2013-08-23 12:06	nicole	File Added: ColorsTableIndexBug.png
2013-08-23 12:06	nicole	File Added: col.txt
2013-08-23 12:07	nicole	Note Added: 0009582
2013-08-26 09:39	nicole	Note Added: 0009591
2013-08-26 09:39	nicole	Status	assigned => resolved
2013-08-26 09:39	nicole	Fixed in Version	=> Slicer 4.3.0
2013-08-26 09:39	nicole	Resolution	open => fixed
2014-03-06 04:56	jcfr	Note Added: 0010838
2014-03-06 04:58	jcfr	Status	resolved => closed
2017-06-07 23:27		Changeset attached	=> Slicer 2145-support-for-installing-extension-from-file eecc44de