View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001853Slicer4Module Editorpublic2012-04-02 17:042017-06-10 08:51
Reporterblowekamp Assigned Topieper  
PrioritynormalSeverityfeatureReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.0 gamma RC2 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.2.0 
Summary0001853: Increate the limit for the paint tool, to be space aware.
Description

Currently the radius for the paint tool in the Editor Module is hard set to 100mm. If the image has a physical spacing of say 50. Then the maximum radius is only 2 pixels. The limit of the paint bush size should take into consideration the image spacing, so have a sensible maximum size.

TagsNo tags attached.

Activities

blowekamp

blowekamp

2012-04-02 17:15

developer   ~0003957

To create data that will reproduce this issue, just manual set the Image Spacing in the Volume Module, under the Volume Information so say [40,40,40]
pieper

pieper

2012-04-03 13:52

administrator   ~0003961

Sent test version of the code to Brad.
blowekamp

blowekamp

2012-04-04 11:44

developer   ~0003962

I was able to use and was not able to get unexpected behavior from the following topic:

https://github.com/pieper/Slicer/compare/1853-space-aware-paint-radius
pieper

pieper

2012-04-20 05:21

administrator   ~0004050

Merged fix into trunk

http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=19910
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=19911
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=19912
blowekamp

blowekamp

2012-06-19 04:29

developer   ~0004851

I have tested this in the latest development version and it appears to be working.
pieper

pieper

2015-03-02 13:05

administrator   ~0012951

There was a further issue with the paint effect forgetting the user-selected value so this was refactored here:

http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24008

See:

http://slicer-devel.65872.n3.nabble.com/Editor-PaintEffect-radius-td4033583.html

Related Changesets

Import 2017-06-07 23:51:09: master 47579984

2015-03-02 17:42:24

pieper

Details Diff 		BUG: 0001853 - fix issue where paint radius if forgotten switching effects

Now the calculation of the volume-dependent radius is done before
the mrml defaults are set. This means that the first volume edited
will get a spacing-dependent radius, and from then on the radius
will remain at the user's setting no matter what volume is selected.
This is probably the right answer in most cases.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24008 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/PaintEffect.py Diff File

Issue History

Date Modified Username Field Change
2012-04-02 17:04 blowekamp New Issue
2012-04-02 17:04 blowekamp Status new => assigned
2012-04-02 17:04 blowekamp Assigned To => pieper
2012-04-02 17:15 blowekamp Note Added: 0003957
2012-04-03 13:39 pieper File Added: megaHead.nhdr
2012-04-03 13:39 pieper File Added: MMhead.nhdr
2012-04-03 13:40 pieper File Deleted: megaHead.nhdr
2012-04-03 13:40 pieper File Deleted: MMhead.nhdr
2012-04-03 13:52 pieper Note Added: 0003961
2012-04-04 11:44 blowekamp Note Added: 0003962
2012-04-20 05:21 pieper Note Added: 0004050
2012-04-20 05:22 pieper Status assigned => resolved
2012-04-20 05:22 pieper Resolution open => fixed
2012-06-19 04:29 blowekamp Note Added: 0004851
2012-06-19 04:29 blowekamp Status resolved => closed
2012-08-21 10:01 jcfr Fixed in Version => Slicer 4.2.0 - Feature freeze Sept 1st 2012
2012-08-21 10:01 jcfr Target Version => Slicer 4.2.0 - Feature freeze Sept 1st 2012
2015-03-02 13:05 pieper Note Added: 0012951
2017-06-10 08:51 pieper Changeset attached => Slicer master 47579984