Steve Pieper via bwh.harvard.edu
Mar 11 (3 days ago)
to Julien, Andriy, Jean-Christophe
There are definitely some operations that are leading to memory leaks, but I haven't had a chance to look into it - I was planning to do this once I finish porting the editor to pure python.
But now that you mention it there seems to be something with the python/qt layer at work.
For example, the SampleData module does not generate a leak, even if I add something like self.image = vtk.vtkImageData() to the init. This reference gets cleaned up automatically.
However if I just enter the Endoscopy module and exit I get these leaks which seem to be related to the qSlicerNodeComboBox not releasing the vtkMRMLCameraNode:
vtkDebugLeaks has detected LEAKS!
Class "vtkPerspectiveTransform" has 2 instances still around.
Class "vtkObservation" has 1 instance still around.
Class "vtkMatrix4x4" has 14 instances still around.
Class "vtkSimpleTransform" has 5 instances still around.
Class "vtkObserverManager" has 1 instance still around.
Class "vtkEventBroker" has 1 instance still around.
Class "vtkOpenGLCamera" has 1 instance still around.
Class "vtkTransform" has 3 instances still around.
Class "vtkMRMLCameraNode" has 1 instance still around.
Class "vtkTimerLog" has 1 instance still around.
Class "vtkCommand or subclass" has 5 instances still around.
I'll try to look into this some time, but if anyone knows what's going on I'd be glad to hear it ;)
-Steve
On Sat, Mar 10, 2012 at 9:43 PM, Julien Finet <julien.finet@kitware.com> wrote:
Hi Andrei,
See below my answers
On Sat, Mar 10, 2012 at 8:23 PM, Andriy Fedorov <fedorov@bwh.harvard.edu> wrote:
Julien,
I looked into this issue
1) the reason tests were passing on my machine (I tested on mac and
linux) is when I run them locally, memory leaks are not treated as
errors, so the tests pass and you need -VV to see the leaks.
I forgot about it, but yes, it's one oddity of VTK, it has been fixed in VTK 5.10.
2) I realized I do not know what are the rules regarding memory
allocation in python to prevent memory leaks.
Example 1:
Just adding this line to init()
self.__logic = slicer.modulelogic.vtkSlicerMultiVolumeExplorerLogic()
leads to the following leaks:
301: Class "vtkObserverManager" has 2 instances still around.
301: Class "vtkSlicerMultiVolumeExplorerLogic" has 1 instance still around.
301: Class "vtkCommand or subclass" has 2 instances still around.
In this module, I do not use __logic, so this is easy to fix, but I
don't understand this.
Example 2:
To get rid of the remaining leaks in the generic tests, I have to
comment out the following lines from my setup():
self.chart = self.chartView.chart()
self.chartTable = vtk.vtkTable()
self.xArray = vtk.vtkFloatArray()
self.yArray = vtk.vtkFloatArray()
self.xArray.SetName('X')
self.yArray.SetName('Y')
self.chartTable.AddColumn(self.xArray)
self.chartTable.AddColumn(self.__yArray)
Why is this? Does this mean I need to manually manage references to
all VTK objects?
You earlier email about managing references deals with objects created
by factories ( http://massmail.spl.harvard.edu/public-archives/slicer-devel/2011/007513.html ),
and I do not recall any other guidelines about explicit reference
counting from python.
The bottom line is I need some guidelines regarding memory management
from python to fix these tests.
Interesting... Does that means that python can't instantiate VTK objects without making leaks ? I'm not enough aware of the python wrapping to give you an answer, I let the python experts answering you :-)
Julien.
On Thu, Mar 8, 2012 at 8:53 PM, Andriy Fedorov <fedorov@bwh.harvard.edu> wrote:
Yes, I have all these three flags set to ON. I do get leaks messages
when I close Slicer.
On Thu, Mar 8, 2012 at 7:11 PM, Julien Finet <julien.finet@kitware.com> wrote:
do you have Slicer_USE_VTK_DEBUG_LEAKS set to ON in the superbuild directory
?
and Slicer_USE_VTK_DEBUG_LEAKS and VTK_DEBUG_LEAKS to ON in the inner build
?
j.
On Thu, Mar 8, 2012 at 6:50 PM, Andriy Fedorov <fedorov@bwh.harvard.edu>
wrote:
Julien,
fyi, these tests pass on my mac, and I have timeout when I try to
access the links included in your email.
Test project /Users/fedorov/Slicer/Slicer4-SuperBuild/Slicer-build
Start 301: qSlicerMultiVolumeExplorerModuleGenericTest
1/3 Test 0000301: qSlicerMultiVolumeExplorerModuleGenericTest
................... Passed 8.77 sec
Start 302: qSlicerMultiVolumeExplorerModuleWidgetGenericTest
2/3 Test 0000302: qSlicerMultiVolumeExplorerModuleWidgetGenericTest
............. Passed 5.89 sec
Start 318: py_nomainwindow_qSlicerMultiVolumeImporterModuleGenericTest
3/3 Test 0000318: py_nomainwindow_qSlicerMultiVolumeImporterModuleGenericTest
... Passed 16.92 sec
100% tests passed, 0 tests failed out of 3
On Thu, Mar 8, 2012 at 6:38 PM, Andriy Fedorov <fedorov@bwh.harvard.edu>
wrote:
Yes, I should, I will try this week.
On Thu, Mar 8, 2012 at 5:09 PM, Julien Finet <julien.finet@kitware.com>
wrote:
Hi Andrei,
qSlicerMultiVolumeExplorerModuleGenericTest
http://slicer.cdash.org/testDetails.php?test=863239&build=11504
and qSlicerMultiVolumeExplorerModuleWidgetGenericTest
http://slicer.cdash.org/testDetails.php?test=928324&build=11504
are having memory leaks.
Can you eventually give a look ?
Thanks,
Julien.
| 
