View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001683Slicer4Core: Packagingpublic2012-02-01 09:222017-06-07 23:27
Reporterpieper Assigned Tojcfr  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
PlatformwindowsOSOS Version
Product Version 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0001683: ctk app launcher doesn't handle windows command console
Description

On Tue, Jan 24, 2012 at 7:36 AM, Ruben Schmidt <R.Schmidt-1@student.tudelft.nl> wrote:

Hi,
I want to convert a BSpline transform file to a deformation field (as the warp feature for Grid transforms with a non-identity orientation matrix is not yet implemented). Like I did in Slicer3, I tried the following commands:

C:\Program Files\Slicer 4.0.1>Slicer --launch lib\Slicer-4.0\cli-modules\BSplineToDeformationField --tfm C:\bspline.tfm --refImage C:\ct1.nrrd --defImage C:\output_vector_field.nhdr
However, there's no response, no output. Can't I use the BSplineToDeformationField module through the command prompt anymore?

I'm working in Windows 7, 64-bit.

Thanks,
Ruben

_______________________________________________
slicer-users mailing list
slicer-users@bwh.harvard.edu
http://massmail.spl.harvard.edu/mailman/listinfo/slicer-users
To unsubscribe: send email to slicer-users-request@massmail.spl.harvard.edu with unsubscribe as the subject
Steps To Reproduce

Running "Slicer.exe --help" in a command console gives no output.

TagsNo tags attached.

Relationships

duplicate of 0002934 assignedjcfr Console output logging for Windows 
related to 0002376 closedjcfr Inconsistent behavior of Slicer launcher command options output across systems 
related to 0003408 closedjcfr Launcher and command line output broken on Windows 

Activities

finetjul

finetjul

2012-02-01 10:23

administrator   ~0003591

Consider commit: https://github.com/commontk/AppLauncher/commit/c067d290b10668b71bcfe8b990ee5cd14c79f0ef
And discussion from Andrei on 11/11/11:
J2, JC,

We tested Win64 build and ChangeTracker in preparation to RSNA. Mostly
things went smoothly, but there are two issues we need to fix:

  • a big annoyance is the DOS console that spits out all warnings -
    Steve and I agreed it would be great to hide it
  • need to hide the leaks message box

Would it be possible to do this?

Steve mentioned, the first one was done in Slicer3, and he said it has
something to do with the type of application on Windows (console vs
something else).

Please let us know if this can be fixed, and when. As you know, at
this point every single Win64 nightly build before Nov 15 is very
important for testing purposes.
jcfr

jcfr

2012-05-27 13:31

administrator   ~0004641

Last edited: 2012-05-27 13:32

As explained by Julien, verbose output was an issue. It has been addressed. See note [1] for details.

A possible solution would be to provide a launcher built with console support. What about providing a launcher named "SlicerWithOutput.exe" ?

[1] http://www.na-mic.org/Bug/view.php?id=1683#c3591
pieper

pieper

2012-07-31 12:44

administrator   ~0005472

Can we do a specialized launcher that does the SlicerWithOutput mode and use it during all the nightly tests - particularly for extensions where it may be hard to debug otherwise.

Also, maybe we can use a dialog box for the help display on windows?
jcfr

jcfr

2012-10-19 07:16

administrator   ~0006640

With the next release of the launcher, it will be possible to add the "--launch" arguments to the "additionalLauncherNoSplashArguments" settings.

When splash screen is disabled, it means text will be outputted on the console.

See https://github.com/commontk/AppLauncher/issues/34
and https://github.com/commontk/AppLauncher/commit/683ee5228942800b631aed0d52ff08f68dee34e5
jcfr

jcfr

2012-10-22 10:28

administrator   ~0006682

See http://www.na-mic.org/Bug/view.php?id=2376#c6681
jcfr

jcfr

2012-10-22 16:52

administrator   ~0006686

Topic pushed: 1683-launcher-with-output
See https://github.com/jcfr/Slicer/tree/1683-launcher-with-output

Consider also the note added in the commit:

// -------
Note that the launcher settings are currently duplicated for each launcher,
this will lead to some issue if extension are installed using a slicer
started with one and then module are attempted to be loaded with the
same Slicer started using the other launcher.
// -------
jcfr

jcfr

2012-10-24 11:23

administrator   ~0006727

From AF: Potentially related issue?

http://massmail.spl.harvard.edu/public-archives/slicer-devel/2012/010375.html [^]

Hi,

I have a script that I am running from command line using
--python-script option to the launcher with the latest nightly build
of Slicer on Win7.

If I run it without --no-splash, I have Slicer crash. With
--no-splash, it completes without issues.

Perhaps it could be relevant that the script produces a lot of console
output as it imports a large DICOM series (of course, all of this
output is not captured since Slicer detaches itself from the console
as described in http://www.na-mic.org/Bug/view.php?id=2376). [^]

AF
jcfr

jcfr

2012-10-24 11:36

administrator   ~0006729

Hi Andriy,

"If I run it without --no-splash, I have Slicer crash. With --no-splash, it completes without issues.". Please create an issue to capture that problem.

To provide some background ...

On all platform, beside of showing the splashscreen or not, the "--no-splash" argument also allows to determine if a QCoreApplication or a QApplication should be instantiated within the launcher, hence the requirement for a X server.

The problem specific to output on windows (captured by issue 1683) is quite different. I initially improperly considered that --no-splash could be a solution in my initial exchange with you.

As detailed in a note to issue 2376, I explained that the entry point of windows application specifying if there is a support or not for console output is defined at compile time. As far as I know, there are no "easy" way of choosing such behavior at runtime.

For that reason, in the windows install package, providing am additional launcher named "SlicerWithOutput" would enable the console output. I started some work in that direction. See 1683#c6686

Logging the output into a file could also be useful. That way in case of crash, it would be easy to refer to it.

Hth
Jc
jcfr

jcfr

2017-06-07 23:27

administrator   ~0014538

Fix committed to 1683-launcher-with-output branch.

Related Changesets

Slicer: 1683-launcher-with-output 16d828ff

2012-10-22 17:41:38

jcfr

Details Diff 		BUG: Fix CTK AppLauncher to have consistent output across platform.

* Now uses CTK AppLauncher 0.1.9

* Note that doesn't fix issue 0001683. See http://www.na-mic.org/Bug/view.php?id=1683

See http://www.na-mic.org/Bug/view.php?id=2376

Fixes 0002376

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21223 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_CTKAPPLAUNCHER.cmake Diff File

Slicer: 1683-launcher-with-output cc7a5f19

2012-10-22 20:50:50

jcfr

Details Diff 		BUG: Also install a Slicer launcher with console output

Note that the launcher settings are currently duplicated for each launcher,
this will lead to some issue if extension are installed using a slicer
started with one and then module are attempted to be loaded with the
same Slicer started using the other launcher.

See http://www.na-mic.org/Bug/view.php?id=1683

Fixes 0001683
mod - Applications/SlicerApp/CMakeLists.txt Diff File

Issue History

Date Modified Username Field Change
2012-02-01 09:22 pieper New Issue
2012-02-01 09:22 pieper Status new => assigned
2012-02-01 09:22 pieper Assigned To => jcfr
2012-02-01 10:10 finetjul Project Slicer3 => Slicer4
2012-02-01 10:11 finetjul Category Command Line Modules (Applications/CLI) => Packaging
2012-02-01 10:11 finetjul Description Updated
2012-02-01 10:23 finetjul Note Added: 0003591
2012-05-27 13:27 jcfr Target Version => Slicer 4.2.0 - Sept 1st 2012
2012-05-27 13:31 jcfr Note Added: 0004641
2012-05-27 13:31 jcfr Status assigned => feedback
2012-05-27 13:32 jcfr Note Edited: 0004641
2012-07-31 12:39 fedorov Relationship added related to 0002376
2012-07-31 12:44 pieper Note Added: 0005472
2012-08-20 11:44 jcfr Target Version Slicer 4.2.0 - Feature freeze Sept 1st 2012 => Slicer 4.2.5
2012-08-21 09:39 jcfr Target Version Slicer 4.2.5 => Slicer 4.3.0
2012-10-19 07:16 jcfr Note Added: 0006640
2012-10-22 10:28 jcfr Note Added: 0006682
2012-10-22 13:37 jcfr Status feedback => assigned
2012-10-22 16:52 jcfr Note Added: 0006686
2012-10-24 11:23 jcfr Note Added: 0006727
2012-10-24 11:36 jcfr Note Added: 0006729
2013-08-30 13:23 jcfr Target Version Slicer 4.3.0 => Slicer 4.4.0
2013-09-19 13:31 jcfr Relationship added related to 0003408
2014-05-13 08:30 jcfr Relationship added duplicate of 0002934
2014-05-13 08:30 jcfr Duplicate ID 0 => 2934
2014-05-13 08:30 jcfr Status assigned => resolved
2014-05-13 08:30 jcfr Fixed in Version => Slicer 4.4.0
2014-05-13 08:30 jcfr Resolution open => duplicate
2014-05-13 08:30 jcfr Status resolved => closed
2017-06-07 23:27 jcfr Changeset attached => Slicer 1683-launcher-with-output cc7a5f19
2017-06-07 23:27 jcfr Changeset attached => Slicer 1683-launcher-with-output 16d828ff
2017-06-07 23:27 jcfr Note Added: 0014538
2017-06-07 23:27 jcfr Resolution duplicate => fixed