View Issue Details

IDProjectCategoryView StatusLast Update
0001669Slicer4Core: Usabilitypublic2014-03-06 05:22
Reporterfinetjul Assigned Tocrmullin  
PriorityurgentSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product VersionSlicer 4.0.1 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0001669: Add recent loaded files menu entry in File menu bar
Description

It would be nice to have a shortcut to load recent files (scene, volume or mesh...)

Additional Information

qSlicerCoreIOManager::loadNodes(...) is the central function to load files from the gui.
Consider qSlicerIOManagerPrivate::readSettings() and qSlicerIOManagerPrivate::writeSettings() for an example of loading/saving data between multiple instances of Slicer.

TagsNo tags attached.

Relationships

related to 0003354 acknowledgedjcfr Recently loaded menu - Add tooltip showing last load date and time 
related to 0003355 acknowledgedjcfr Recently loaded menu - Do not require a restart 

Activities

joe_snyder

joe_snyder

2012-05-15 06:55

developer   ~0004396

A "Work-in-progress" branch for this feature can be found here:

https://github.com/josephsnyder/Slicer/tree/recent-data-list

crmullin

crmullin

2012-06-04 09:31

developer   ~0004762

These changes have been incorporated into a WIP branch here:

https://github.com/chrismullins/Slicer/tree/recent-loaded-files

crmullin

crmullin

2012-07-03 07:34

developer   ~0005052

Jc or Julien,
Would you review the changes on this branch, as well as the comments I made?

I think some of these hunks are not necessary to be staged for commit.
Thanks

[1] https://github.com/chrismullins/Slicer/commit/b5a40272c0ad080b54ff6f04b7efb77800f0d9bf

crmullin

crmullin

2012-07-03 13:49

developer   ~0005063

More recent branch:

https://github.com/chrismullins/Slicer/commit/bf945ef7a69120a07943c68bbb98f32c719b908c

crmullin

crmullin

2012-07-11 14:07

developer   ~0005122

Jc's comments:

https://github.com/chrismullins/Slicer/commit/71f630e2705ab6fab8c540fad924db98e21042ce

crmullin

crmullin

2012-07-11 15:28

developer   ~0005124

Now the "Clear" button works as expected.

https://github.com/chrismullins/Slicer/commit/87e376ee826ac115e4952ff77376ad71e69e409b

crmullin

crmullin

2012-07-12 11:57

developer   ~0005129

Jc's and Julien's comments have been addressed here:

https://github.com/chrismullins/Slicer/commit/d1691f95ea0ffec7dc8251a6f3facd7bff272e7f

Please test if you like it.

Note: Remember to clear your Slicer.ini before trying this out. Also when testing the mechanisms to clear and change the size of the "Recently Loaded Files" menu, keep in mind that choosing the option to restart will not call the necessary methods to update the application settings. Selecting "no" to the restart, exiting the program, and starting it again will have this effect. However, this should be easily fixable in the next revision.

crmullin

crmullin

2012-07-13 05:18

developer   ~0005136

Added the aforementioned 'gray out' when there are no recently loaded files. Also addresses several other comments.

https://github.com/chrismullins/Slicer/commit/01c7dc7badec53b954f049dcb992e1b554fea022

crmullin

crmullin

2012-07-13 11:04

developer   ~0005138

Latest update:
https://github.com/chrismullins/Slicer/commit/1fb292e439acb4d76a6182fc3a9573e3fc56ef76

crmullin

crmullin

2012-07-16 10:50

developer   ~0005147

Upon playing with the option to decrease the number of files shown, it appears that indeed the most "recently loaded files" are not always what is shown. Fix is on the way.

crmullin

crmullin

2012-07-16 12:38

developer   ~0005150

This appears to fix that problem:

https://github.com/chrismullins/Slicer/commit/d3f921452a09cf8b258866108ed4ddf938bba426

jcfr

jcfr

2012-07-16 13:04

administrator   ~0005152

Let me know when you are ready for a demo :)

crmullin

crmullin

2012-07-18 10:38

developer   ~0005189

This fix will update all these settings live instead of waiting for a restart:

https://github.com/chrismullins/Slicer/commit/c1bdd41bab0a6ae5c88993367a9305260562b05f

jcfr

jcfr

2012-07-24 08:03

administrator   ~0005222

I fixed few stuff. On your side, could you verify things work as expected. See https://github.com/jcfr/Slicer/compare/1669-recently-loaded-files

jcfr

jcfr

2012-07-24 23:36

administrator   ~0005230

Fixed in r20685
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20685
and http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20686

jcfr

jcfr

2012-07-27 15:36

administrator   ~0005333

Dear issue reporter,

Good news :) Slicer developers SOLVED the problem you reported - YOU now need to VERIFY and CLOSE this issue.

finetjul

finetjul

2012-07-30 07:49

administrator   ~0005454

When changing the number of entries for the most recent files menu, it is said that the option needs a restart to be taken into account.
This is not really true (it works if you increase the number), and when it is true ( 2 items decreased to 1) it should be fixed without a restart (general panel fires a signal that is listened by the main window)
Maybe having a special value of 0 could hide the menu.
I would also suggest to support more than 10 entries, increase to 100 ? I tend to always feel limited by the most recent max number, I love to have all my history available :-)

crmullin

crmullin

2012-08-02 09:59

developer   ~0005491

Do these settings really update live for you? My workflow is as follows:
1) I set the number of recently loaded files to keep to 2.
2) I load a directory of 10+ files. Only the most recent 2 are shown.
3) I increase the number of files to 10.
Now, only the most recent 2 are still shown.

Regardless, I will try to make the settings update live. Also I will increase the maximum available files to 100.

finetjul

finetjul

2012-08-02 10:08

administrator   ~0005492

I have the same workflow as you.
That's why I believe it should update live.
j.

finetjul

finetjul

2012-08-28 06:39

administrator   ~0005825

Rename "Clear Menu" into "Clear history"
Would be nice if each entry could have the date (and hour) when it was loaded for the last time as a tooltip.

jcfr

jcfr

2013-08-30 21:27

administrator   ~0009761

See r22377 - http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22377

ENH: In Recently loaded menu, rename "Clear Menu" into "Clear History"

jcfr

jcfr

2013-08-30 21:47

administrator   ~0009762

See r22378 - http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22378

ENH: Increase maximum size for Recently loaded menu

jcfr

jcfr

2014-03-06 05:22

administrator   ~0011187

Closing resolved issues that have not been updated in more than 3 months

Issue History

Date Modified Username Field Change
2012-01-26 15:00 finetjul New Issue
2012-01-26 15:00 finetjul Status new => assigned
2012-01-26 15:00 finetjul Assigned To => finetjul
2012-01-26 15:04 finetjul Additional Information Updated
2012-01-26 15:04 finetjul Summary Add recent loaded files menu entry in File => Add recent loaded files menu entry in File menu bar
2012-02-23 12:56 finetjul Assigned To finetjul => joe_snyder
2012-05-15 06:55 joe_snyder Note Added: 0004396
2012-05-30 06:42 jcfr Assigned To joe_snyder => crmullin
2012-06-04 09:31 crmullin Note Added: 0004762
2012-07-03 07:34 crmullin Note Added: 0005052
2012-07-03 13:49 crmullin Note Added: 0005063
2012-07-05 10:16 jcfr Priority low => high
2012-07-05 10:16 jcfr Target Version => Slicer 4.2.0 - Sept 1st 2012
2012-07-05 10:17 jcfr Priority high => urgent
2012-07-11 14:07 crmullin Note Added: 0005122
2012-07-11 15:28 crmullin Note Added: 0005124
2012-07-12 11:57 crmullin Note Added: 0005129
2012-07-13 05:18 crmullin Note Added: 0005136
2012-07-13 11:04 crmullin Note Added: 0005138
2012-07-16 10:50 crmullin Note Added: 0005147
2012-07-16 12:38 crmullin Note Added: 0005150
2012-07-16 13:04 jcfr Note Added: 0005152
2012-07-18 10:38 crmullin Note Added: 0005189
2012-07-24 08:03 jcfr Note Added: 0005222
2012-07-24 23:36 jcfr Note Added: 0005230
2012-07-24 23:36 jcfr Status assigned => resolved
2012-07-24 23:36 jcfr Fixed in Version => Slicer 4.2.0 - October 1st 2012
2012-07-24 23:36 jcfr Resolution open => fixed
2012-07-27 15:36 jcfr Note Added: 0005333
2012-07-30 07:49 finetjul Note Added: 0005454
2012-07-30 07:49 finetjul Status resolved => assigned
2012-08-02 09:59 crmullin Note Added: 0005491
2012-08-02 10:08 finetjul Note Added: 0005492
2012-08-20 10:02 jcfr Target Version Slicer 4.2.0 - Feature freeze Sept 1st 2012 => Slicer 4.2.5
2012-08-21 09:39 jcfr Target Version Slicer 4.2.5 => Slicer 4.3.0
2012-08-28 06:39 finetjul Note Added: 0005825
2013-08-30 21:21 jcfr Relationship added related to 0003354
2013-08-30 21:27 jcfr Note Added: 0009761
2013-08-30 21:43 jcfr Relationship added related to 0003355
2013-08-30 21:44 jcfr Status assigned => resolved
2013-08-30 21:44 jcfr Fixed in Version Slicer 4.2.0 => Slicer 4.3.0
2013-08-30 21:47 jcfr Note Added: 0009762
2014-03-06 05:22 jcfr Note Added: 0011187
2014-03-06 05:22 jcfr Status resolved => closed