View Issue Details

IDProjectCategoryView StatusLast Update
0001608Slicer4Core: GUIpublic2011-12-12 08:28
Reporterjmk1 Assigned Topieper  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.0.0 
Target VersionSlicer 4.0.1Fixed in VersionSlicer 4.0.1 
Summary0001608: volume names always get loaded as "name1" instead of just "name"
Description

When I load .nii volumes using the "Add Data" dialog, The filename shows up normally in the dialog. I could change it here if I wanted to, to be something different. For example, I select the file called "myimage.nii", and there is a text box that is pre-filled with "myimage", which I leave alone. Then, when I click "OK" to load the image, it now shows up in the Data and Volumes modules as "myimage1". In slicer3, this would happen if I tried to load a second copy of an image called the same thing, and I understand that. But it is sometimes confusing when loading images that have names that end in numbers ("subject354" would now be loaded as "subject3541", even the first time I've ever loaded that image).

Could it be that the algorithm that checks if the name is already in use is getting fooled somehow, and it's always adding the "1"? If I try to load the same file again, it seems to correctly iterate to "2".

Additional Information

I am running 4.0.gamma-11-27 r18777 on Centos 5.5 64-bit.

TagsNo tags attached.

Activities

pieper

pieper

2011-12-05 12:03

administrator   ~0003418

I agree this should be fixed (Ron also was outspoken the he doesn't like the current behavior with, for example, mr.nrrd being loaded as mr1) - I changed the behavior to be closer to the slicer3 version, but with the slight difference that there is now an underscore to differentiate the name from the serial number. This was the solution some of us discussed on a recent phone call.

If you could try it and make sure it works for you that would be great - then you could close out the bug.

pieper@flint:~/slicer4/latest/Slicer4$ svn commit -m "BUG: fix for bug 1608 - now don't change name first time, but append _1, _2, etc for subsequent times adding volume of the same name" Libs/MRML/vtkMRMLScene.cxx
Sending Libs/MRML/vtkMRMLScene.cxx
Transmitting file data .
Committed revision 18805.

jmk1

jmk1

2011-12-12 08:28

reporter   ~0003438

looks like it's working fine, thanks!

Issue History

Date Modified Username Field Change
2011-12-05 11:39 jmk1 New Issue
2011-12-05 11:39 jmk1 Status new => assigned
2011-12-05 11:39 jmk1 Assigned To => finetjul
2011-12-05 11:44 finetjul Assigned To finetjul => pieper
2011-12-05 11:45 finetjul Product Version => Slicer 4.0 RSNA
2011-12-05 11:45 finetjul Fixed in Version => Slicer 4.0 post RSNA
2011-12-05 11:45 finetjul Target Version => Slicer 4.0 post RSNA
2011-12-05 12:03 pieper Note Added: 0003418
2011-12-05 12:03 pieper Status assigned => resolved
2011-12-05 12:03 pieper Resolution open => fixed
2011-12-12 08:28 jmk1 Note Added: 0003438
2011-12-12 08:28 jmk1 Status resolved => closed