The same extension installed on CTK wiki works as expected. See http://www.commontk.org/index.php/Sandbox

mediawiki version:
CTK: 1.16.5 - See http://www.commontk.org/index.php/Special:Version
Slicer: 1.15.1 - See http://wiki.slicer.org/slicerWiki/index.php/Special:Version

Jc.

Ron and Steve brought this issue back to my attention. Unless you know exactly what's causing this problem, I would prefer to go on the lead that the CTK wiki isn't broken. The version of MediaWiki seems different, and I'm not sure if the plugin has and difference in configuration as well.

If we can avoid groveling through MediaWIki source code and monkey-patching the problem, I'd be happier. If it's a config problem on our side, then let's by all means do the quick fix.

Let me know how you'd like to proceed.
--Mike

Hi Mike,

Thanks for looking into the issue.

The first step could be the update of the ExternalData extension installed on Slicer wiki.

CTK wiki: External Data (Version 1.3.3)
Slicer wiki: External Data (Version 1.3.2)

Version info can be retrieved on the following pages:
http://www.commontk.org/index.php/Special:Version
http://wiki.slicer.org/slicerWiki/index.php/Special:Version

Installation an extension is very easy. From the documentation of the extension:

//------------------
To install the extension, place the entire 'ExternalData' directory
within your MediaWiki 'extensions' directory, then add the following
line to your 'LocalSettings.php' file:

 require_once( "$IP/extensions/ExternalData/ExternalData.php" );

//------------------

The lastest version 1.3.5 requires a recent version, that's why I would suggest to check out version 1.3.4 that requires Mediawiki 1.11 or higher.

To do so:

cd /path/to/mediawiki/extensions
rm -r ExternalData
svn co http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/ExternalData/ -r 105197

Let me know if you need further guidance or help.

Try now.

It doesn't work :(

I locally installed a version of 1.15.1 with the same extension that are used on Slicer Wiki (same version of the extension also). See screenshot LocalInstall-1.15.1-works_ExternalData.png.

... and it works. See screenshot Local_Mediawiki-1.15.1_works_ExternalDataExample.

Few things to try:

• Seems the extension ConfirmEdit is installed but doesn't work on SlicerWiki. I would suggest to try to comment the corresponding line in LocalSettings.php

• Seems two extra lines have been introduced somewhere. Could you archive the mediawiki installation and send it to me by email ? It should be around 20MB. Make sure to exclude tmp files etc ..

• Within extensions/ExternalData/ED_GetData.php, adding debug statement using either of error_log or fwrite could help. See http://php.net/manual/en/function.error-log.php

Thanks

Just noticed that every wiki page served by slicer wiki contains two extra lines at the top. See screenshot AllPageSlicerWiki_ExtraLines.png

I am able to reproduce the issue by adding to empty line at the top of LocalSettings.php. See LocalSettings_ExtraLines

If localSettings.php is fine .. you should check the other php script for extra blank line at the top.

Weird. I think it's fixed. There weren't any extra lines on the top of LocalSettings.php, but I couldn't find any spurious extra lines anywhere else either. I essentially did your test and put extra lines at the top of LocalSettings, then removed them.

And then everything magically worked: the lines are gone, and your example appears to work.

At any rate, at least I managed to do a small amount of random cleaning up as well (disabled the recaptcha extension).

Please verify and close.

Works great. See http://wiki.slicer.org/slicerWiki/index.php/Documentation/4.0/ModulesMetadata

For some reason, it seems something has been changed .. using the following URL:

http://wiki.slicer.org/slicerWiki/index.php/Special:GetData/Documentation/4.0/Developers/Sandbox_data

return this result;

<source lang="php" line="true">
Name,Color,Shape
Apple,Red,Round
Banana,Yellow,Oblong
Orange,Orange,Round
Pear,Yellow,"Pear-shaped"

whereas the following is expected:

Name,Color,Shape
Apple,Red,Round
Banana,Yellow,Oblong
Orange,Orange,Round
Pear,Yellow,"Pear-shaped"

Looking at the source of any slicer wiki page, we can see that the line:

"<source lang="php" line="true">"

is at the top.

Would it be possible to make sure :
Both LocalSettings and the brettcrumb extension don't have the closing "?>" php tag at the end.

See here for details: https://www.mediawiki.org/wiki/Manual:LocalSettings.php

"Your version of LocalSettings.php may not end with a closing PHP tag of ?>. This is done on purpose, as it prevents people from accidentally adding new information after this tag. PHP will function just fine without a closing tag."

Just added a screenshot to illustrate the issue.

I've removed the closing tag at the end of LocalSettings.php.

As an aide, what a ridiculous convention, even if the mechanism and logic are understandable.

Agreed ... adding the closing tag at the end shouldn't cause all this trouble.
Thanks for your help. It works great.