View Issue Details

IDProjectCategoryView StatusLast Update
0001480Slicer4Core: Base Codepublic2012-05-04 14:31
Reporterfinetjul Assigned Tojcfr  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product VersionSlicer 4.0.0 
Target VersionSlicer 4.0.1Fixed in VersionSlicer 4.0.0 
Summary0001480: Enforce the lenght of Slicer src/build to not go over 50 chars on Windows
Description

This typically leads to errors hard to debug.

TagsITKv4

Activities

jcfr

jcfr

2011-10-12 15:12

administrator   ~0003174

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=18326

finetjul

finetjul

2011-10-12 15:57

administrator   ~0003175

It works fine, thanks !
There is a typo though. It says that it's the "ITK" directory that is too long, instead of "Slicer".

jcfr

jcfr

2011-10-12 21:39

administrator   ~0003176

Typo fixed - see https://github.com/Slicer/Slicer/commit/93cbb032b228e2113fa68b6359bab3acd560fb09

pieper

pieper

2011-10-14 11:49

administrator   ~0003181

ITKv4 limit is 50

ITKv4 being a dependency of Slicer, I guess it should even be smaller. [for example 40 = 50 - length(/ITK-build)]

Ideally, we could scan a successful build of windows, and find out what's the longest path. From there we would be able to do a more educated guess.

Let's continue the discussion on that mantis issue: http://na-mic.org/Mantis/view.php?id=1480

Thanks
Jc

  • Hide quoted text -

On Fri, Oct 14, 2011 at 3:39 PM, Steve Pieper <pieper@ibility.net> wrote:

Jc -

It looks like the windows build failed due to the new check on the directory depth - that bit me on my local builds too.  Did the # of 50 come from an empirical test or is it just a guess?  Could we get by with a number more like 75 or 100?  My path is 67 and it always worked until the new tests were committed.

-Steve
finetjul

finetjul

2011-10-17 18:56

administrator   ~0003185

Sometime, the length test can pass for the superbuild but fail for the inner build. Unfortunately, it is not caught at configure time.
Can you test superbuild is not 11 chars too long (sizeof("Slicer-Build"))?

finetjul

finetjul

2011-10-24 12:09

administrator   ~0003201

The option is not passed to the inner build neither.

jcfr

jcfr

2011-12-19 15:02

administrator   ~0003466

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=18466

Issue History

Date Modified Username Field Change
2011-10-12 06:21 finetjul New Issue
2011-10-12 06:21 finetjul Status new => assigned
2011-10-12 06:21 finetjul Assigned To => jcfr
2011-10-12 15:12 jcfr Note Added: 0003174
2011-10-12 15:12 jcfr Status assigned => resolved
2011-10-12 15:12 jcfr Fixed in Version => Slicer 4.0 RSNA
2011-10-12 15:12 jcfr Resolution open => fixed
2011-10-12 15:57 finetjul Note Added: 0003175
2011-10-12 21:39 jcfr Note Added: 0003176
2011-10-13 10:10 finetjul Status resolved => closed
2011-10-14 11:49 pieper Note Added: 0003181
2011-10-17 18:56 finetjul Note Added: 0003185
2011-10-17 18:56 finetjul Status closed => assigned
2011-10-24 12:09 finetjul Note Added: 0003201
2011-12-19 15:00 jcfr Assigned To jcfr => finetjul
2011-12-19 15:02 jcfr Note Added: 0003466
2011-12-19 15:02 jcfr Status assigned => resolved
2011-12-19 17:07 finetjul Assigned To finetjul => jcfr
2012-05-04 14:31 finetjul Status resolved => closed
2012-11-30 09:35 jcfr Tag Attached: ITKv4