View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001347 | Slicer4 | Core: GUI | public | 2011-08-18 18:27 | 2014-03-06 05:17 |
Reporter | finetjul | Assigned To | crmullin | ||
Priority | low | Severity | tweak | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.0.0 | ||||
Target Version | Slicer 4.3.0 | Fixed in Version | Slicer 4.3.0 | ||
Summary | 0001347: Small bugs in the module selector | ||||
Description |
| ||||
Tags | No tags attached. | ||||
child of | 0001120 | closed | BenjaminLong | Use combobox for module selector menu; move to the module widget area |
Also: it takes two clicks to get the clear button to work. At least on linux. one to focus, one to activate clear button? |
|
I can't reproduce this, on my machine the module is selected on the click. I'll work on the other 3, especially not truncating module title, which is important. |
|
For reference - See https://github.com/commontk/CTK/pull/300 "Changes cursor when mouse enters ctkSearchBox" |
|
It appears that my fix only works when the user currently isn't typing in the box - ie. when the dropdown menu is not visible. Check out the attached picture. Also, anyone know where to start with enlarging the dropdown box to accomodate larger module names? If it gets long enough this becomes a scroll area, so I'm not sure if I need to account for two different cases. |
|
2013-02-27 08:47
|
|
Each a module is loaded, get its title, compute what would be ideal width and if it applies update the width. |
|
I believe that all the modules are loaded as soon as Slicer is started - thus, this approach will lead to the size of both the search bar and the combobox to be fixed as the size of the module with the largest name. Is this the desired behavior? This function[1] is called once for every module at the start, and this line[2] is setting the width from the start. [1] https://github.com/Slicer/Slicer/blob/master/Base/QTGUI/qSlicerModulesMenu.cxx#L367 [2] https://github.com/Slicer/Slicer/blob/master/Base/QTGUI/qSlicerModuleSelectorToolBar.cxx#L93 |
|
If the name of module displayed in "All modules" are not truncated, let's just call this a non issue and move on something else. |
|
You're correct - the module names are not truncated in "All modules." They are only truncated when searched for. Maybe this is acceptable, at least until we have modules which are not distinct until after ~ 25 characters. What about the final issue, "When clicking on the module selector, it opens the whole modules menu, however the focus is on the menu which prevents the key strokes to be used for the line edit search. This is not the case with the pair QLineEdit/QCompleter, so it seems to be feasible to have both a open menu and a QLineEdit with keyboard focus." Does this require a fix? Right now the user can either view all the modules or search for a module with the keyboard, not both. If this behavior is okay, then I will resolve this issue. |
|
The behavior has improved a lot since this was submitted (and/or I have become accustomed to it). Ok to close. |
|
Reported of the issue is the one suppose to close it :) |
|
Closing resolved issues that have not been updated in more than 3 months |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2011-08-18 18:27 | finetjul | New Issue | |
2011-08-18 18:27 | finetjul | Status | new => assigned |
2011-08-18 18:27 | finetjul | Assigned To | => BenjaminLong |
2011-08-18 18:29 | finetjul | Relationship added | child of 0001120 |
2011-08-28 17:09 | finetjul | Description Updated | |
2011-08-30 07:50 | finetjul | Description Updated | |
2011-09-13 19:44 | inorton | Note Added: 0003018 | |
2012-08-21 11:42 | jcfr | Assigned To | BenjaminLong => crmullin |
2012-10-22 07:34 | jcfr | Target Version | Slicer 4.0.0 => Slicer 4.3.0 |
2013-02-25 09:47 | crmullin | Note Added: 0008043 | |
2013-02-25 16:44 | jcfr | Note Added: 0008045 | |
2013-02-27 08:46 | crmullin | Note Added: 0008060 | |
2013-02-27 08:47 | crmullin | File Added: moduleSelector-clearButton-cursor.png | |
2013-02-27 08:59 | jcfr | Note Added: 0008061 | |
2013-02-27 10:42 | crmullin | Note Added: 0008063 | |
2013-02-27 10:51 | jcfr | Note Added: 0008064 | |
2013-02-27 10:56 | crmullin | Note Added: 0008065 | |
2013-02-27 10:57 | crmullin | Note Edited: 0008065 | |
2013-02-27 10:57 | crmullin | Note Edited: 0008065 | |
2013-02-27 11:15 | inorton | Note Added: 0008067 | |
2013-02-27 11:15 | inorton | Status | assigned => closed |
2013-02-27 11:15 | inorton | Resolution | open => fixed |
2013-02-27 11:28 | jcfr | Note Added: 0008068 | |
2013-02-27 11:28 | jcfr | Status | closed => resolved |
2013-02-27 11:28 | jcfr | Fixed in Version | => Slicer 4.3.0 |
2014-03-06 05:15 | jcfr | Note Added: 0011051 | |
2014-03-06 05:17 | jcfr | Status | resolved => closed |