View Issue Details

IDProjectCategoryView StatusLast Update
0001343Slicer4Core: GUIpublic2012-08-21 09:43
Reporterkikinis Assigned Tofinetjul  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.0.0 
Target VersionSlicer 4.0.0Fixed in VersionSlicer 4.0.0 
Summary0001343: failure to put a volume under a transform
Description

load 2 volumes
open the data module
create new transform
try to drag one of the volumes under the transform
Its not working, volume bounce back outside of the transform.

TagsNo tags attached.

Relationships

related to 0001510 closedfinetjul data module display is bad 

Activities

2011-08-17 04:39

 

pieper

pieper

2011-08-17 10:42

administrator   ~0002722

Andrey showed me a similar issue where he couldn't drag and drop a volume into a transform using his mac book pro.

kikinis

kikinis

2011-08-17 15:27

developer   ~0002728

If you are close to the lower boundary of the blue, when clicking it works. If you are close to the center of the blue bar it does not work. This requires too fine a control.
BTW: the adapting box around the tree is too tight. It would be good to have half a line of empty space between the bottom of the tree and the box. Again to much precision needed in the current setup.

finetjul

finetjul

2011-08-18 18:44

administrator   ~0002742

Fixed in r17755:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=17755

It was failing the first time the volume was dropped, but was working the second time.

finetjul

finetjul

2011-08-18 19:02

administrator   ~0002743

Half a row height under the tree is fixed in r17756:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=17756

kikinis

kikinis

2011-08-20 11:05

developer   ~0002756

The three selections for displaying information in the data module are confusing.

pieper

pieper

2011-09-07 09:48

administrator   ~0002934

Unfortunately on my mac build dragging the volume into the transform causes both of them to disappear from the Data tree(!). This is on mac lion with qt 4.7.3 and svn 17990.

On my linux build all works as expected.

finetjul

finetjul

2011-09-07 21:39

administrator   ~0002938

is this 100% reproducible ?
Do you do the following ?
load 1 volumes
open the data module
create new transform
drag the volume under the transform

pieper

pieper

2011-09-08 04:27

administrator   ~0002942

Yes, exactly, that's the procedure and the errant behavior happens 100% of the time.

It looks like the nodes get marked as 'hidden' for some reason. If I switch to the Transforms module the transform is initially selected, but if I try to reselect it the module disables and I can't reselect. Also in the slice controllers it is not possible to pick the None volume option...

pieper

pieper

2011-09-08 04:37

administrator   ~0002943

Confirmed it still happens on r17997 on mac osx lion.

pieper

pieper

2011-11-22 09:54

administrator   ~0003351

Still happens on mac (not linux) as of November 22 - happens on the release build.

finetjul

finetjul

2011-11-23 15:39

administrator   ~0003370

Fixed in r18754:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=18754

Indeed, it was a Mac only issue, its internal implementation of Drag&Drops is different from Windows/Linux in a way it calls processEvents on the application within the drop.
It had the side effect of calling onItemChanged() too early. We now use a timer (delay could be decreased if needed).

fedorov

fedorov

2011-11-29 05:19

developer   ~0003405

This is still an issue -- I have the same problem now at RSNA Slicer booth. Julien: stop by to see a demo :)

pieper

pieper

2011-11-29 19:51

administrator   ~0003407

Julien saw this today - he agrees it is a bug :)

But it may be something internal to Qt-on-mac itself and may be hard to fix...

fedorov

fedorov

2011-12-17 09:18

developer   ~0003457

What is the status of this issue? This is very inconvenient.

If this cannot be resolved, how about we modify the interface and add something like "Parent transform" combo box in the volumes module?

This will be ugly, but better than having to open the python console to each time I need to put something under a transform.

pieper

pieper

2011-12-19 03:24

administrator   ~0003458

Agreed - it would be good to have a second method for this.

I would think that the lower portion of the Data module could have a node combo box for parent transform that would be enabled whenever a transformable node s selected in the tree. This might also help users 'discover' functionality like being able to transform annotations, which is otherwise a kind of hidden feature.

kikinis

kikinis

2011-12-19 03:32

developer   ~0003459

IMHO the natural home of an interface associating a transform with an element of the mrml tree would be the transforms module.

We would need to think about how to handle nested transforms as well.

How about Selecting a transform from a tree presentation brings up a pop up which gives you a two column listing of all the elements that can be transformed. One column is "under the transform", the other is "not under the transform". Hit apply or cancel to finish.

finetjul

finetjul

2011-12-19 04:48

administrator   ~0003460

I like the idea of adding transformable nodes to the current transform in the Transforms module.
How about a new field "Transformed:" that lists all the nodes under a transform. When the list gets focus, a panel containing the list of untransformed nodes opens on the side of the list.
<< and >> buttons are also in the panel to move the nodes from one list to the other.

finetjul

finetjul

2012-01-20 11:35

administrator   ~0003514

First implementation in r19121

pieper

pieper

2012-01-20 11:53

administrator   ~0003515

Very nice!

Issue History

Date Modified Username Field Change
2011-08-17 04:39 kikinis New Issue
2011-08-17 04:39 kikinis File Added: Screen Shot 2011-08-17 at 8.07.48 AM.png
2011-08-17 10:42 pieper Note Added: 0002722
2011-08-17 15:27 kikinis Note Added: 0002728
2011-08-18 18:44 finetjul Note Added: 0002742
2011-08-18 18:44 finetjul Status new => resolved
2011-08-18 18:44 finetjul Fixed in Version => Slicer 4.0 RSNA
2011-08-18 18:44 finetjul Resolution open => fixed
2011-08-18 18:44 finetjul Assigned To => finetjul
2011-08-18 19:02 finetjul Note Added: 0002743
2011-08-20 11:05 kikinis Note Added: 0002756
2011-08-20 11:05 kikinis Status resolved => closed
2011-09-07 09:48 pieper Note Added: 0002934
2011-09-07 09:48 pieper Status closed => assigned
2011-09-07 09:48 pieper Resolution fixed => reopened
2011-09-07 21:39 finetjul Note Added: 0002938
2011-09-08 04:27 pieper Note Added: 0002942
2011-09-08 04:37 pieper Note Added: 0002943
2011-11-22 09:54 pieper Note Added: 0003351
2011-11-23 15:39 finetjul Note Added: 0003370
2011-11-23 15:39 finetjul Status assigned => resolved
2011-11-23 15:39 finetjul Resolution reopened => fixed
2011-11-24 03:48 finetjul Relationship added related to 0001510
2011-11-29 05:19 fedorov Note Added: 0003405
2011-11-29 05:19 fedorov Status resolved => feedback
2011-11-29 05:19 fedorov Resolution fixed => reopened
2011-11-29 19:51 pieper Note Added: 0003407
2011-12-17 09:18 fedorov Note Added: 0003457
2011-12-19 03:24 pieper Note Added: 0003458
2011-12-19 03:32 kikinis Note Added: 0003459
2011-12-19 04:48 finetjul Note Added: 0003460
2012-01-20 11:35 finetjul Note Added: 0003514
2012-01-20 11:35 finetjul Status feedback => resolved
2012-01-20 11:35 finetjul Resolution reopened => fixed
2012-01-20 11:53 pieper Note Added: 0003515
2012-02-21 10:27 kikinis Status resolved => closed
2012-08-21 09:43 jcfr Target Version => Slicer 4.0.0