View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001299 | Slicer4 | Core: GUI | public | 2011-07-29 04:24 | 2017-06-10 08:51 |
Reporter | kikinis | Assigned To | nicole | ||
Priority | high | Severity | feature | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.0 gamma RC2 | ||||
Target Version | Slicer 4.4.0 | Fixed in Version | Slicer 4.4.0 | ||
Summary | 0001299: Facelift for Sceneviews Module | ||||
Description | Hi, | ||||
Tags | No tags attached. | ||||
2011-07-29 04:24
|
|
Julien: do you see an easy(ish) way to update a tree view scene model to support this organisation/display? |
|
Would it help to remove the green arrow and make the thumbnail clickable? |
|
Does this have to be a tree view? We need to identify one of the views as the master view, but there is no functional need for a tree. |
|
Nicole, you can use a QItemDelegate (see qMRMLNodeItemDelegate for an example), you can customize the look of each cell. |
|
any update? |
|
I tried the item delegate route and was unable to get it to work. I'll see if I can find some time to consult with Julien on it when he's here for the ctk hackfest. |
|
?? |
|
No progress. |
|
ok |
|
I strongly disagree. This is high priority for the last year of NA-MIC. EDIT (Jc): Updated priority to high |
|
If it can not be done in qt, can it be done in webkit? |
|
I (Steve) thinks this is lower priority than 0001914 where incorrect information is being presented to the user in some circumstances. During the bugfest meeting 2014-03-07 we discussed this in the context of the number of other issues and the time available for release. We want to keep this on the plate but will not prioritize it above circumstances where incorrect information is displayed that may be critical for clinical research. |
|
Look at making a custom widget per scene view node and removing the qMRMLSceneModel (or make a different QtView. |
|
2014-04-21 08:04
|
SceneViewsFacelift-1.tiff (670,676 bytes) |
I've done an html version of the Scene Views module using the Qt web view, based on the DataStore module, see attached picture SceneViewsFacelift-1.tiff From an implementation standpoint, issues are:
So, it's not pretty under the hood[1], needs a bit more cleaning up, but it seems to work okay. Posting this work in progress to check that it's worth continuing to go down this path. [1] Initial implementation commit on github: |
|
Under the hood is not my domain, but the tiff looks good. |
|
Reminder sent to: pieper Steve: Could you take a look at the initial webview implementation and let me know of any problems you see? |
|
It actually doesn't look too bad under the hood to me. It doesn't really need to be too flexible, and writing to tmp is allowed. Nice! |
|
Pretty much done:
Squashing it and will commit to svn tomorrow so I can monitor the dashboards. |
|
Squashed commit: |
|
Import 2017-06-07 23:51:09: master fb0da667 2014-05-13 11:30:42 naucoin Details Diff |
ENH: html facelift for SceneViews Implemented a Qt web view and populated it with HTML to allow viewing, editing, restoring, creating scene views with the layout requested. The scene view thumbnail is being written to disk in a temp dir. To get the Edit, Delete, Restore and Capture funtionality I'm capturing the clicks on the links and parsing specially formatted urls (Edit/Restore/Delete mrmlNodeID/Create) Clear out the temp files on scene close and clear the memory cache, now don't have to write them out all the time. Resize the images before writing to disk so that the web view doesn't have to handle resizing. Added in support for VTK6 Created new MRML web view based on the qMRMLChartView. It allows better resizing (returns an invalid size hint, sets size policy to expanding/expanding) so that the web view doesn't keep getting reset to width = 800. Added a plug in for the designer. Save and restore the scroll position so user goes back to the scene view node that they were previously viewing after adding a new scene view. Running on a mac, you can't see the scroll bar on the data store page nor on the scene views module widget, but it is visible on a linux build. You can scroll using the trackpad and it is consistent, so only show the scroll bar as needed. The dialog superclass disables capturing a new thumbnail on review/edit so don't resave the thumbnail type nor the image data. Issue 0001299 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23160 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - Libs/MRML/Widgets/CMakeLists.txt | Diff File | ||
mod - Libs/MRML/Widgets/DesignerPlugins/CMakeLists.txt | Diff File | ||
add - Libs/MRML/Widgets/DesignerPlugins/qMRMLExpandingWebViewPlugin.cxx | Diff File | ||
add - Libs/MRML/Widgets/DesignerPlugins/qMRMLExpandingWebViewPlugin.h | Diff File | ||
mod - Libs/MRML/Widgets/DesignerPlugins/qMRMLWidgetsPlugin.h | Diff File | ||
add - Libs/MRML/Widgets/qMRMLExpandingWebView.cxx | Diff File | ||
add - Libs/MRML/Widgets/qMRMLExpandingWebView.h | Diff File | ||
add - Libs/MRML/Widgets/qMRMLExpandingWebView_p.h | Diff File | ||
mod - Modules/Loadable/SceneViews/CMakeLists.txt | Diff File | ||
rm - Modules/Loadable/SceneViews/GUI/qMRMLSceneViewsModel.cxx | Diff File | ||
rm - Modules/Loadable/SceneViews/GUI/qMRMLSceneViewsModel.h | Diff File | ||
rm - Modules/Loadable/SceneViews/GUI/qMRMLSceneViewsTreeView.cxx | Diff File | ||
rm - Modules/Loadable/SceneViews/GUI/qMRMLSceneViewsTreeView.h | Diff File | ||
mod - Modules/Loadable/SceneViews/GUI/qSlicerSceneViewsModuleWidget.cxx | Diff File | ||
mod - Modules/Loadable/SceneViews/GUI/qSlicerSceneViewsModuleWidget.h | Diff File | ||
mod - Modules/Loadable/SceneViews/Logic/vtkSlicerSceneViewsModuleLogic.cxx | Diff File | ||
mod - Modules/Loadable/SceneViews/Logic/vtkSlicerSceneViewsModuleLogic.h | Diff File | ||
mod - Modules/Loadable/SceneViews/Resources/UI/qSlicerSceneViewsModuleWidget.ui | Diff File | ||
mod - Modules/Loadable/SceneViews/qSlicerSceneViewsModule.cxx | Diff File | ||
Import 2017-06-07 23:51:09: master f675265f 2014-05-13 12:23:49 naucoin Details Diff |
COMP: remove unused variable warnings Remove unused variables or mark as unused parameters in the scene views module update. Issue 0001299 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23161 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - Libs/MRML/Widgets/qMRMLExpandingWebView.cxx | Diff File | ||
mod - Modules/Loadable/SceneViews/GUI/qSlicerSceneViewsModuleWidget.cxx | Diff File | ||
mod - Modules/Loadable/SceneViews/Logic/vtkSlicerSceneViewsModuleLogic.cxx | Diff File | ||
Import 2017-06-07 23:51:09: master 06a52a52 2014-05-19 12:15:26 naucoin Details Diff |
BUG: use Slicer system fonts in Scene Views To bring the Scene Views module into alignment with the Slicer system fonts, propagate the application settings fonts to the QWebView used to display the scene views. Issue 0001299 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23197 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - Modules/Loadable/SceneViews/GUI/qSlicerSceneViewsModuleWidget.cxx | Diff File | ||
Import 2017-06-07 23:51:09: master dbbe9f53 2014-05-19 17:51:29 naucoin Details Diff |
BUG: fix crash when scene view added without screen shot When saving a scene with the Scene Views module open, a null pointer crash happened because the qSlicerSceneWriter was adding the scene view node to the scene before capturing and setting the screen shot. The mrml application logic does the same thing. For now, avoid the crash by checking the pointer. The thumbnail immage will appear on the next update, but since the mrml scene isn't invoking an event when it's finished the Commit call, the module will have to in future observe scene view nodes for modified events to detect that a screen shot has been added to the node (and if there have been other updates directly to the node rather than via the GUI). Issue 0001299 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23213 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - Modules/Loadable/SceneViews/GUI/qSlicerSceneViewsModuleWidget.cxx | Diff File | ||
Import 2017-06-07 23:51:09: master 20cd8881 2014-05-21 11:02:26 naucoin Details Diff |
ENH: separate scene views with a line Request from Ron, adding in a horizontal line between scene views. Issue 0001299 git-svn-id: http://svn.slicer.org/Slicer4/trunk@23221 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - Modules/Loadable/SceneViews/GUI/qSlicerSceneViewsModuleWidget.cxx | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2011-07-29 04:24 | kikinis | New Issue | |
2011-07-29 04:24 | kikinis | File Added: Screen Shot 2011-07-29 at 7.51.37 AM.png | |
2011-07-29 15:01 | finetjul | Status | new => assigned |
2011-07-29 15:01 | finetjul | Assigned To | => nicole |
2011-08-25 09:34 | finetjul | Target Version | => Slicer 4.0 RSNA |
2011-08-25 11:26 | nicole | Note Added: 0002800 | |
2011-08-25 11:31 | kikinis | Note Added: 0002801 | |
2011-09-27 05:18 | kikinis | Note Added: 0003123 | |
2011-09-28 05:55 | finetjul | Note Added: 0003126 | |
2012-06-28 10:07 | kikinis | Note Added: 0004971 | |
2012-06-28 10:13 | nicole | Note Added: 0004972 | |
2012-08-20 09:41 | nicole | Target Version | Slicer 4.0.0 => Slicer 4.3.0 |
2013-02-08 07:46 | kikinis | Note Added: 0007846 | |
2013-02-08 07:59 | nicole | Note Added: 0007847 | |
2013-02-08 08:14 | kikinis | Note Added: 0007848 | |
2013-07-09 06:40 | nicole | Target Version | Slicer 4.3.0 => Slicer 4.4.0 |
2013-09-02 12:37 | jcfr | Priority | normal => low |
2013-09-02 12:55 | kikinis | Note Added: 0009785 | |
2013-09-02 13:01 | jcfr | Priority | low => high |
2013-09-02 13:02 | jcfr | Note Edited: 0009785 | |
2013-10-26 06:36 | kikinis | Note Added: 0010225 | |
2014-03-07 10:17 | pieper | Note Added: 0011375 | |
2014-03-07 10:17 | pieper | Status | assigned => acknowledged |
2014-03-07 10:18 | pieper | Note Added: 0011376 | |
2014-04-21 08:04 | nicole | File Added: SceneViewsFacelift-1.tiff | |
2014-04-21 08:51 | nicole | Note Added: 0011632 | |
2014-04-21 08:51 | nicole | Status | acknowledged => feedback |
2014-04-21 08:53 | nicole | Note Edited: 0011632 | |
2014-04-21 08:56 | kikinis | Note Added: 0011633 | |
2014-04-21 09:16 | nicole | Note Added: 0011634 | |
2014-04-21 13:18 | pieper | Note Added: 0011636 | |
2014-05-12 14:57 | nicole | Note Added: 0011732 | |
2014-05-13 07:37 | nicole | Note Added: 0011753 | |
2014-05-13 07:37 | nicole | Status | feedback => resolved |
2014-05-13 07:37 | nicole | Fixed in Version | => Slicer 4.4.0 |
2014-05-13 07:37 | nicole | Resolution | open => fixed |
2014-07-23 10:28 | kikinis | Status | resolved => closed |
2017-06-10 08:51 | Changeset attached | => Slicer master 20cd8881 | |
2017-06-10 08:51 | Changeset attached | => Slicer master dbbe9f53 | |
2017-06-10 08:51 | Changeset attached | => Slicer master 06a52a52 | |
2017-06-10 08:51 | Changeset attached | => Slicer master f675265f | |
2017-06-10 08:51 | Changeset attached | => Slicer master fb0da667 |