 |
From Chris - June 1st 2012: Also here is my latest fix on the cursorOffset issue. I'm still working on how I'm going to do the consolidation of pythonModule and pythonObject. However, this one takes into account multiline statements and also fixes all the crash cases I could find. |
2012-06-06 07:10
|
python-autocomplete-parameter-detection-problem.png (59,765 bytes) |
|
|
See to fail with custom class. See enclosed screenshot. |
|
|
Make sure to consolidate the two methods pythonObject and pythonModule |
|
2012-06-07 12:37
|
pythonAutocomplete.png (26,822 bytes) |
 |
This fix appears to work for me: However, I believe I've made the case stronger that pythonObject and pythonModule need to be together. Perhaps adding an optional parameter to pythonObject which makes it function just like pythonModule (essentially ignoring the last part of the function) ? Edit: Also I now see that it's impossible to tell if it works from that screenshot as the cursor must have blinked then. But that's how I tested it, since I was also concerned about retrieving classes within classes. Please try it out and break it if you can. |
|
|
I gave a try and it works better :) Few remarks: 1) Could you also update the associates tests ? 2) When a non-static method associated with a python class is auto-completed, the first argument should be ignored since it corresponds to "self", the user is not expected to provide a value. See ctkSimplePythonShell-Understand-self.png |
|
2012-06-11 19:38
|
ctkSimplePythonShell-Understand-self.png (19,798 bytes) |
|
|
I'm not having much luck simulating multi-line statements (such as declaring a class) within the tests. I'll keep looking into it.
|
|
|
@Mayeul: Here is the full topic of Chris: https://github.com/chrismullins/CTK/commits/python-autocomplete-parameter-detection It is an old topic and it doesn't rebase cleanly @Chris: It will happen :) |
|
|
Fixed in r25289 |
- Anonymous
