View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001184Slicer4Module Annotationspublic2011-06-04 10:402012-10-25 13:45
Reporterinorton Assigned Tonicole  
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.1.0 
Summary0001184: Annotation: improve drag-drop to hierarchy usability
Description

Drag-dropping in the annotation tree view has some interaction quirks:

  1. every field in the table is a drop target, but the only field where this behavior is defined is the leftmost "tree" column.
  • I think every column should be a drop target, but the re-parent behavior needs to be defined for all columns... I imagine this is already on the list!
  • it would be nice, visually, for the whole row of the target to change color or have some other more clear visual cue. The current drop-shadow in each separate column can be confusing.

  1. dropping an item onto other fields currently causes the item to disappear
    2a. changing visibility of the parent hierarchy then causes 0001172

  2. It is possible to drop items onto the tree-column of non-hierarchy nodes. Maybe this is intentional but it feels strange.

TagsNo tags attached.

Activities

finetjul

finetjul

2011-06-12 16:07

administrator   ~0002499

  1. and 2. are fixed in r16926:
    http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=16926

  2. should be fixable by fixing canBeAParent in the annotation model .

1b) "change color or have some other more clear visual cue."
-> please create a feature request.
nicole

nicole

2011-06-14 14:01

administrator   ~0002514

  1. Julien and I discussed adding a parameter to hierarchy nodes to denote that they can only have one mrml node associated with them. The current scene is organised such that each annotation node has it's own private hierarchy node, so it is possible to add another annotation to that private one.
    Or we could check to see if "hide from editors" is on when evaluating a drop target?
nicole

nicole

2011-06-14 15:47

administrator   ~0002522

  1. Started to implement "leaf nodes" in http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=17015 but need to add the QT part to check if can drop a node onto a hierarchy by checking AllowMultipleChildren.
finetjul

finetjul

2011-06-16 23:27

administrator   ~0002526

To make the item stop receive items in the Qt part, you need to control the behavior in qMRMLSceneAnnotationModel::nodeFlags
nicole

nicole

2012-08-27 14:25

administrator   ~0005818

svn 20884 removes the drop enabled node flag from annotation nodes with hierarchy nodes that don't allow multiple children. Dropped nodes shouldn't disappear now.

Issue History

Date Modified Username Field Change
2011-06-04 10:40 inorton New Issue
2011-06-12 16:07 finetjul Note Added: 0002499
2011-06-12 16:07 finetjul Status new => assigned
2011-06-12 16:07 finetjul Assigned To => nicole
2011-06-14 14:01 nicole Note Added: 0002514
2011-06-14 15:47 nicole Note Added: 0002522
2011-06-16 23:27 finetjul Note Added: 0002526
2011-08-25 09:48 finetjul Target Version => Slicer 4.0 RSNA
2012-08-20 09:19 nicole Category Usability => Module Annotations
2012-08-20 09:19 nicole Target Version Slicer 4.0.0 => Slicer 4.2.0 - Feature freeze Sept 1st 2012
2012-08-27 14:25 nicole Note Added: 0005818
2012-08-27 14:25 nicole Status assigned => resolved
2012-08-27 14:25 nicole Fixed in Version => Slicer 4.1.0
2012-08-27 14:25 nicole Resolution open => fixed
2012-10-25 13:45 inorton Status resolved => closed