0004709: need to escape apostrophe in sql statement

ID	Project	Category	View Status	Date Submitted	Last Update

0004709	Slicer4	Module DICOM	public	2019-08-28 17:43	2019-08-30 13:38

Reporter	pieper	Assigned To	pinter
Priority	normal	Severity	major	Reproducibility	have not tried
Status	resolved	Resolution	fixed
Product Version	Slicer 4.11.0
Target Version		Fixed in Version	Slicer 4.11.0

Summary	0004709: need to escape apostrophe in sql statement
Description	Running the latest slicer it offered to update my dicom database but then failed with this message. Note that BWH sometimes written out with an apostrophe s ('s) and so the statement needs to be escaped. `Series Added SQL failed Bad SQL: UPDATE Studies SET DisplayedNumberOfSeries='3', InstitutionName='BRIGHAM & WOMEN'S HOSPITAL', PatientsUID=4, ReferringPhysician='x^x^^^', StudyDate='2019xxxx', StudyDescription='MRI BRAIN FUNCTIONAL', StudyInstanceUID='1.2.xx' WHERE StudyInstanceUID='1.2.x';` (Note I had this same bug when CTK was first written and I imported a BWH scan : )
Additional Information	We should be able to fix this by using the correct Qt SQL api. I didn't find the code at a quick glance but if needed maybe we could look together Csaba.
Tags	No tags attached.

pinter 2019-08-28 21:59 developer ~0016284	Does this look fine or did you think about something more comprehensive? https://github.com/commontk/CTK/pull/881 If it looks OK, can you please try it with your dataset? Thanks!

pinter 2019-08-30 13:38 developer ~0016285	Resolved in https://github.com/commontk/CTK/pull/881 Testing pending. Please close if it works fine.

Date Modified	Username	Field	Change
2019-08-28 17:43	pieper	New Issue
2019-08-28 17:43	pieper	Status	new => assigned
2019-08-28 17:43	pieper	Assigned To	=> pinter
2019-08-28 21:59	pinter	Note Added: 0016284
2019-08-30 13:38	pinter	Status	assigned => resolved
2019-08-30 13:38	pinter	Resolution	open => fixed
2019-08-30 13:38	pinter	Fixed in Version	=> Slicer 4.11.0
2019-08-30 13:38	pinter	Note Added: 0016285