View Issue Details

IDProjectCategoryView StatusLast Update
0004677Slicer4Core: Base Codepublic2019-03-04 22:42
Reporterphcerdan Assigned Tolassoan  
PrioritynormalSeverityminorReproducibilityalways
Status assignedResolutionopen 
Product VersionSlicer 4.11.0 
Target VersionFixed in Version 
Summary0004677: Minor warnings introduced with recent markups fiducials
Description

Minor warnings introduced in 0efe38afcd4f76e80c17c2e70ded5d225b5fc0fa
@lassoan

Libs/MRML/DisplayableManager/vtkMRMLAbstractDisplayableManager.cxx: In member function ‘virtual bool vtkMRMLAbstractDisplayableManager::CanProcessInteractionEvent(vtkMRMLInteractionEventData, double&)’:
Libs/MRML/DisplayableManager/vtkMRMLAbstractDisplayableManager.cxx:992:97: warning: unused parameter ‘eventData’ [-Wunused-parameter]
bool vtkMRMLAbstractDisplayableManager::CanProcessInteractionEvent(vtkMRMLInteractionEventData
eventData, double &distance2)


Libs/MRML/DisplayableManager/vtkMRMLAbstractDisplayableManager.cxx: In member function ‘virtual bool vtkMRMLAbstractDisplayableManager::ProcessInteractionEvent(vtkMRMLInteractionEventData*)’:
Libs/MRML/DisplayableManager/vtkMRMLAbstractDisplayableManager.cxx:999:94: warning: unused parameter ‘eventData’ [-Wunused-parameter]
 bool vtkMRMLAbstractDisplayableManager::ProcessInteractionEvent(vtkMRMLInteractionEventData* eventData)
                                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
Libs/MRML/DisplayableManager/vtkMRMLAbstractDisplayableManager.cxx: In member function ‘virtual void vtkMRMLAbstractDisplayableManager::SetHasFocus(bool)’:
Libs/MRML/DisplayableManager/vtkMRMLAbstractDisplayableManager.cxx:1005:58: warning: unused parameter ‘hasFocus’ [-Wunused-parameter]
 void vtkMRMLAbstractDisplayableManager::SetHasFocus(bool hasFocus)
                                                     ~~~~~^~~~~~~~
[54/780] Building CXX object Libs/MRML/DisplayableManager/...MLDisplayableManager.dir/vtkSliceViewInteractorStyle.cxx.o
Libs/MRML/DisplayableManager/vtkThreeDViewInteractorStyle.cxx: In member function ‘virtual void vtkThreeDViewInteractorStyle::OnLeftButtonUp()’:
Libs/MRML/DisplayableManager/vtkThreeDViewInteractorStyle.cxx:445:7: warning: variable ‘mouseInteractionMode’ set but not used [-Wunused-but-set-variable]
   int mouseInteractionMode = vtkMRMLInteractionNode::ViewTransform;
       ^~~~~~~~~~~~~~~~~~~~
Libs/MRML/DisplayableManager/vtkThreeDViewInteractorStyle.cxx:446:7: warning: variable ‘placeModePersistence’ set but not used [-Wunused-but-set-variable]
   int placeModePersistence = 0;
       ^~~~~~~~~~~~~~~~~~~~
Libs/MRML/DisplayableManager/vtkThreeDViewInteractorStyle.cxx: In member function ‘bool vtkThreeDViewInteractorStyle::ForwardInteractionEventToDisplayableManagers(long unsigned int)’:
Libs/MRML/DisplayableManager/vtkThreeDViewInteractorStyle.cxx:604:10: warning: unused variable ‘displayPosition’ [-Wunused-variable]
   double displayPosition[4] =
          ^~~~~~~~~~~~~~~
[55/780] Linking CXX shared library bin/libMRMLCore.so
Libs/MRML/DisplayableManager/vtkSliceViewInteractorStyle.cxx: In member function ‘virtual void vtkSliceViewInteractorStyle::OnMouseMove()’:
Libs/MRML/DisplayableManager/vtkSliceViewInteractorStyle.cxx:255:30: warning: unused variable ‘sliceCompositeNode’ [-Wunused-variable]
   vtkMRMLSliceCompositeNode *sliceCompositeNode = this->SliceLogic->GetSliceCompositeNode();
                              ^~~~~~~~~~~~~~~~~~
Libs/MRML/DisplayableManager/vtkSliceViewInteractorStyle.cxx: In member function ‘void vtkSliceViewInteractorStyle::DoZoom()’:
Libs/MRML/DisplayableManager/vtkSliceViewInteractorStyle.cxx:805:10: warning: unused variable ‘windowMinSize’ [-Wunused-variable]
   double windowMinSize = std::min(windowSize[0], windowSize[1]);
          ^~~~~~~~~~~~~
[76/780] Linking CXX shared library bin/libMRMLCLIPythonD.so
Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx: In member function ‘bool vtkMRMLMarkupsNode::InsertControlPoint(vtkMRMLMarkupsNode::ControlPoint*, int)’:
Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx:705:43: warning: variable ‘result’ set but not used [-Wunused-but-set-variable]
   std::vector < ControlPoint* >::iterator result = this->ControlPoints.insert(pos, controlPoint);
                                           ^~~~~~
[334/780] Building CXX object Base/QTApp/CMakeFiles/qSlicerBaseQTApp.dir/qSlicerMainWindow.cxx.o
Modules/Loadable/Markups/VTKWidgets/vtkSlicerCurveRepresentation2D.cxx: In member function ‘void vtkSlicerCurveRepresentation2D::CanInteractWithCurve(const int*, const double*, int&, int&, double&)’:
Modules/Loadable/Markups/VTKWidgets/vtkSlicerCurveRepresentation2D.cxx:355:13: warning: unused parameter ‘displayPosition’ [-Wunused-parameter]
   const int displayPosition[2], const double worldPosition[3],
   ~~~~~~~~~~^~~~~~~~~~~~~~~~~~
[340/780] Building CXX object Base/QTApp/CMakeFiles/qSlicerBaseQTApp.dir/qSlicerMainWindow.cxx.o
Modules/Loadable/Markups/VTKWidgets/vtkSlicerCurveRepresentation3D.cxx: In member function ‘void vtkSlicerCurveRepresentation3D::CanInteractWithCurve(const int*, const double*, int&, int&, double&)’:
Modules/Loadable/Markups/VTKWidgets/vtkSlicerCurveRepresentation3D.cxx:293:13: warning: unused parameter ‘displayPosition’ [-Wunused-parameter]
   const int displayPosition[2], const double worldPosition[3],
   ~~~~~~~~~~^~~~~~~~~~~~~~~~~~
[365/780] Building CXX object Modules/Loadable/Markups/Log...tkSlicerMarkupsModuleLogic.dir/vtkSlicerMarkupsLogic.cxx.o
Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager.cxx: In member function ‘virtual void vtkMRMLMarkupsDisplayableManager::OnMRMLSliceNodeModifiedEvent()’:
Modules/Loadable/Markups/MRMLDM/vtkMRMLMarkupsDisplayableManager.cxx:508:33: warning: unused variable ‘markupsDisplayNode’ [-Wunused-variable]
     vtkMRMLMarkupsDisplayNode * markupsDisplayNode = (it->first);
Steps To Reproduce

Build master

TagsNo tags attached.

Activities

phcerdan

phcerdan

2019-03-04 22:42

developer  

log.cpp (5,628 bytes)

Issue History

Date Modified Username Field Change
2019-03-04 22:42 phcerdan New Issue
2019-03-04 22:42 phcerdan Status new => assigned
2019-03-04 22:42 phcerdan Assigned To => lassoan
2019-03-04 22:42 phcerdan File Added: log.cpp