View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0004231 | Slicer4 | Core: Extensions | public | 2016-07-07 23:19 | 2018-05-29 14:22 |
Reporter | fedorov | Assigned To | jcfr | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | resolved | Resolution | no change required | ||
Product Version | |||||
Target Version | Slicer 4.11.0 | Fixed in Version | Slicer 4.9.0 | ||
Summary | 0004231: Extension icon in Extension manager is not the same as specified in s4ext file | ||||
Description | From Andrey: SlicerPathology s4ext file points to this as the extension icon: https://raw.githubusercontent.com/SBU-BMI/SlicerPathology/master/SlicerPathology.png (see https://github.com/Slicer/ExtensionsIndex/blob/master/SlicerPathology.s4ext) However, extension manager in the latest nightly shows old icon. See attachment. (note that the Revision correctly lists the latest version of SlicerPathology trunk that has the updated icon: SBU-BMI/SlicerPathology@ae5d1c4) | ||||
Tags | No tags attached. | ||||
related to | 0002171 | assigned | matthew-woehlke | Integrate extension license information on the extension server |
related to | 0002334 | assigned | matthew-woehlke | Differentiate different type of extenions in extension manager: Concept of channel |
As was identified later, it appears that this is happening because Slicer extensions build system ignores the icon specified in the s4ext file, and instead uses the one from CMakeLists.txt. It is not clear whether this is a bug, or intentional behavior. Is is clear though that this situation is rather confusing to the developer... |
|
Added note to documentation to clarify: https://www.slicer.org/wiki/Documentation/Nightly/Developers/Extensions/DescriptionFile. For Slicer5, a new extension description format should be created and the redundancy between CMakeLists.txt and s4ext file should be removed. See discussion at https://www.slicer.org/wiki/Documentation/Labs/ExtensionsMetadata. |
|
I will confirm this tomorrow after I see the dashboard, but -- related to this issue -- it looks like build_subdirectory is ignored in CMakeLists.txt, and is taken from s4ext... |
|
Confirmed - build_subdirectory is ignored in CMakeLists.txt. For the superbuild extensions, it must be populated in s4ext. Demonstrated on the example of PkModeling extension that we recently moved to superbuild. |
|
Indeed, the value of [1] https://www.slicer.org/wiki/Documentation/Nightly/Developers/FAQ#How_to_upload_an_extension_.3F |
|
Closing . URL was improperly specified. In the future, we will improve how metadata are specified to avoid similar issue. For the record:
|
|
Date Modified | Username | Field | Change |
---|---|---|---|
2016-07-07 23:19 | jcfr | New Issue | |
2016-07-07 23:19 | jcfr | Status | new => assigned |
2016-07-07 23:19 | jcfr | Assigned To | => jcfr |
2016-07-07 23:20 | jcfr | Description Updated | View Revisions |
2016-07-07 23:20 | jcfr | File Added: 1fcdf364-4461-11e6-99a3-9230fca08cf1.png | |
2016-07-07 23:20 | jcfr | Reporter | jcfr => fedorov |
2016-10-12 14:25 | jcfr | Target Version | Slicer 4.6.0 => Slicer 4.7.0 |
2016-10-12 14:39 | fedorov | Note Added: 0014184 | |
2017-09-27 09:30 | lassoan | Note Added: 0015142 | |
2017-09-27 09:32 | lassoan | Target Version | Slicer 4.7.0 => Slicer 4.9.0 |
2017-09-27 09:32 | lassoan | Summary | Issue with extension icon => Extension icon in Extension manager is not the same as specified in s4ext file |
2017-09-27 10:16 | lassoan | Relationship added | related to 0002171 |
2017-09-27 10:17 | lassoan | Relationship added | related to 0002334 |
2017-09-27 10:51 | fedorov | Note Added: 0015160 | |
2017-09-28 11:30 | fedorov | Note Added: 0015212 | |
2017-10-03 02:12 | jcfr | Note Added: 0015238 | |
2018-03-31 00:37 | jcfr | Target Version | Slicer 4.9.0 => Slicer 4.11.0 |
2018-05-29 14:20 | jcfr | Status | assigned => resolved |
2018-05-29 14:20 | jcfr | Resolution | open => no change required |
2018-05-29 14:20 | jcfr | Fixed in Version | => Slicer 4.9.0 |
2018-05-29 14:20 | jcfr | Note Added: 0015768 | |
2018-05-29 14:22 | jcfr | Note Edited: 0015768 | View Revisions |