View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0004017Slicer4Core: Unitspublic2015-07-10 06:592018-01-23 11:21
ReporterDavide Assigned Tojcfr  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product VersionSlicer 4.4.0 
Target VersionFixed in VersionSlicer 4.5.0-1 
Summary0004017: adding support for more quantities in the Units module
Description

As talked with Steve during the Summer Project week, It will be nice to add support for other units in Slicer (see link below). Attached there is a screenshot with a preview. Feedback will be very appreciated.

Topic pushed to https://github.com/Punzo/Slicer/tree/0004017-adding-extra-units-support

I tested it only on Ubuntu.

P.S.: should I do a pull request in github now or should I wait for feedback here?

Thanks,

Davide.

Additional Information

This patch will add only 3 new quantities (frequency, velocities and intensity). Each extension then can add a specific UnitNode.
example: unitsLogic->AddUnitNode("ApplicationLength", "length", "", "degree", 3);

TagsNo tags attached.

Activities

2015-07-10 06:59

 

Screenshot from 2015-07-10 16:19:36.png (114,150 bytes)
jcfr

jcfr

2015-07-14 22:01

administrator   ~0013183

Thanks for your contribution.

Integrated in r24411, r24412 and r24413
See:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24411
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24412
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24413

Related Changesets

Import 2017-06-07 23:51:09: master af66adcc

2015-07-15 01:29:55

jcfr

Details Diff 		ENH: Adding extra units support (frequency, velocity and intensity)

Fixes 0004017

Reviewed-by: Julien Finet <julien.finet@kitware.com>

From: Davide Punzo <punzodavide@hotmail.it>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24413 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/Units/Logic/vtkSlicerUnitsLogic.cxx Diff File
mod - Modules/Loadable/Units/Widgets/Resources/UI/qMRMLUnitWidget.ui Diff File
mod - Modules/Loadable/Units/qSlicerUnitsSettingsPanel.cxx Diff File

Issue History

Date Modified Username Field Change
2015-07-10 06:59 Davide New Issue
2015-07-10 06:59 Davide File Added: Screenshot from 2015-07-10 16:19:36.png
2015-07-10 07:01 Davide Description Updated
2015-07-10 07:17 Davide Description Updated
2015-07-10 07:17 Davide Additional Information Updated
2015-07-10 07:18 Davide Description Updated
2015-07-10 07:24 Davide Description Updated
2015-07-10 07:26 Davide Description Updated
2015-07-14 22:01 jcfr Note Added: 0013183
2015-07-14 22:01 jcfr Status new => resolved
2015-07-14 22:01 jcfr Fixed in Version => Slicer 4.5.0-1
2015-07-14 22:01 jcfr Resolution open => fixed
2015-07-14 22:01 jcfr Assigned To => jcfr
2015-07-14 22:37 jcfr Category Core: GUI => Core: Units
2017-06-10 08:51 jcfr Changeset attached => Slicer master af66adcc
2018-01-23 11:21 Davide Status resolved => closed