I disabled Slicer_BUILD_CLI and build succeeded on Windows. Should I disable Slicer_BUILD_CLI_SUPPORT too? Or something else?

I was trying to build a minimal slicer to test some build/packaging issues and turned off all CLI options, so yes, CLI_SUPPORT too probably (I re-enabled things in order to get past the issue so I don't have that configuration right now). Sorry, I didn't save the cache but it should be easy to replicate on my side if you can't.

I think I fixed the error in
https://github.com/cpinter/Slicer/tree/4014-cannot-build-sh-with-cli-disabled

The only doubt is that I had other build errors like the one below, so I cannot verify for 100%. I just did a rebase to the current trunk, and doing a clean build. If it goes well I will do the commit. Or you can do it as well if you consider the changes OK.

31>vtkSlicerDataStoreLogic.obj : error LNK2019: unresolved external symbol "declspec(dllimport) public: cdecl ctkVTKConnectionFactoryInitialize::c
tkVTKConnectionFactoryInitialize(void)" (_imp??0ctkVTKConnectionFactoryInitialize@@QEAA@XZ) referenced in function "void cdecl `dynamic initialize
r for 'ctkVTKConnectionFactoryInitializer''(void)" (??EctkVTKConnectionFactoryInitializer@@YAXXZ) [C:\de\S4cpD\Slicer-build\Modules\Remote\DataStore
\DataStore\Logic\vtkSlicerDataStoreModuleLogic.vcxproj]

That error does seem unrelated, but since you are doing a clean build let's wait and see how that turns out. Your fix looks good to me - sorry it turned out to be so many lines. Thanks for the fix!

I got the same errors after the clean build. I'll look into it more.

I still get those errors on my branch, strange.
I tried to build with CLI enabled, and it builds fine. Also those data store link errors really seem unrelated so I committed my fixes:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24408
Can you please try to build it on your computer with CLI disabled?