View Issue Details

IDProjectCategoryView StatusLast Update
0003891Slicer4Module SubjectHierarchypublic2018-03-02 11:06
Reporterpinter Assigned Topinter  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.5.0-1Fixed in VersionSlicer 4.5.0-1 
Summary0003891: Potential nodes and transforms in subject hierarchy
Description

The problem:

  • Now that the potential nodes are added to the same tree, the SH appears to be broken for all simple data (that is not loaded from DICOM). Of course things are not actually broken, but the nodes are just potential nodes, so no visibility icon appears and in the transform columns there is just a simple editbox that you can enter text into. Also, only rename and delete actions are available for them. Either SH features should work on potential nodes or by default nodes should be put in a UnknownSubject / UnknownStudy branch.
  • Transform nodes do not appear in the hierarchy, so it is not possible to go to Edit properties of transforms from SH

The solution:

  • The most likely role will be automatically assigned to these, and the SH node created (thus icons and functions are accessible)
  • The nodes will appear under the scene with no parent, or a default subject called "Uncategorized" or "Other" or "Unknown", or something along these lines, where every node that has no parent (and not subject/patient) are shown.
TagsNo tags attached.

Activities

pinter

pinter

2014-11-14 16:36

developer   ~0012698

Fixed in
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23784
See commit message for details

Related Changesets

Import 2017-06-07 23:51:09: master 1ac4193e

2014-11-14 21:17:37

pinter

Details Diff
ENH: Subject hierarchy nodes automatically created for supported types

If a data node is added that is supported in subject hierarchy, it is automatically inserted in the tree. The notion of potential nodes completely removed. This reduces confusion about why certain nodes in the subject hierarchy tree don't have full functionality and icons. Generally, both code and usage became simpler.
Fixes 0003891

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23784 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/SubjectHierarchy/Logic/vtkSlicerSubjectHierarchyModuleLogic.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Logic/vtkSlicerSubjectHierarchyModuleLogic.h Diff File
mod - Modules/Loadable/SubjectHierarchy/MRML/vtkMRMLSubjectHierarchyConstants.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/MRML/vtkMRMLSubjectHierarchyConstants.h Diff File
mod - Modules/Loadable/SubjectHierarchy/MRML/vtkMRMLSubjectHierarchyNode.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/MRML/vtkMRMLSubjectHierarchyNode.h Diff File
mod - Modules/Loadable/SubjectHierarchy/Resources/UI/qSlicerSubjectHierarchyModule.ui Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSceneSubjectHierarchyModel.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSortFilterSubjectHierarchyProxyModel.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSortFilterSubjectHierarchyProxyModel.h Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyTreeView.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/Widgets/qSlicerSubjectHierarchyAbstractPlugin.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/qSlicerSubjectHierarchyModule.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/qSlicerSubjectHierarchyModuleWidget.cxx Diff File
mod - Modules/Loadable/SubjectHierarchy/qSlicerSubjectHierarchyModuleWidget.h Diff File
mod - Modules/Scripted/DICOM/DICOMLib/DICOMPlugin.py Diff File

Issue History

Date Modified Username Field Change
2014-11-12 06:25 pinter New Issue
2014-11-12 06:25 pinter Status new => assigned
2014-11-12 06:25 pinter Assigned To => pinter
2014-11-12 09:11 pinter Description Updated
2014-11-14 16:36 pinter Note Added: 0012698
2014-11-14 16:36 pinter Status assigned => resolved
2014-11-14 16:36 pinter Fixed in Version => Slicer 4.4.1
2014-11-14 16:36 pinter Resolution open => fixed
2014-11-17 16:10 jcfr Target Version => Slicer 4.4.1
2015-09-09 08:29 jcfr Fixed in Version Slicer 4.4.1 => Slicer 4.5.0-1
2015-09-09 08:29 jcfr Target Version Slicer 4.4.1 => Slicer 4.5.0-1
2017-06-10 08:51 pinter Changeset attached => Slicer master 1ac4193e
2018-03-02 11:06 jcfr Status resolved => closed