View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003783 | Slicer4 | Module Models | public | 2014-07-29 08:41 | 2018-03-02 11:07 |
Reporter | alexy | Assigned To | nicole | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | |||||
Target Version | Fixed in Version | Slicer 4.4.0 | |||
Summary | 0003783: Force color to children checkbox does not work | ||||
Description | If I create a model hierarchy, add colors to both model and hierarchy node, checking the "Force color to children" has no effect on display | ||||
Tags | No tags attached. | ||||
I looked at the issue and it seems that the problem is a regression from https://github.com/Slicer/Slicer/commit/a22c49cab51666a7a1c2a0ddcf79d329a4da08c9 The local variable modelDisplayNode has been partially renamed into mrmlDisplayNode. However the lines after L1557 have not been renamed. Not being familiar with that code, I would prefer to let Nicole comment on what's the best way to fix it. (my naive thought would be to rename in SetModelDisplayProperty after line 1557 all the modelDisplayNode into mrmlDisplayNode ). |
|
I was trying to separate out the operations that were specifically defined on the model display node for the scalar settings, and saved the hierarchy display node in line 1492 (in the github version Julien linked) to the more general mrml display node pointer since it was obtained as a mrml display node, not a model display node. |
|
Cast the model hierarchy display node to a model display node and use it for determining model colours if the hierarchy's display settings are to over ride the model's display settings. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2014-07-29 08:41 | alexy | New Issue | |
2014-08-01 08:26 | alexy | Assigned To | => finetjul |
2014-08-01 08:26 | alexy | Status | new => assigned |
2014-08-01 16:32 | finetjul | Note Added: 0012343 | |
2014-08-01 16:33 | finetjul | Relationship added | child of 0003573 |
2014-08-04 08:03 | nicole | Note Added: 0012349 | |
2014-08-04 08:03 | nicole | Assigned To | finetjul => nicole |
2014-08-04 10:42 | nicole | Note Added: 0012350 | |
2014-08-04 10:42 | nicole | Status | assigned => resolved |
2014-08-04 10:42 | nicole | Fixed in Version | => Slicer 4.4.0 |
2014-08-04 10:42 | nicole | Resolution | open => fixed |
2018-03-02 11:07 | jcfr | Status | resolved => closed |