View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003478Slicer4Module OpenIGTLinkIFpublic2013-11-05 17:452014-03-06 10:17
Reportertokuda Assigned Totokuda  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
Product VersionSlicer 4.3.0 
Target VersionSlicer 4.4.0Fixed in VersionSlicer 4.4.0 
Summary0003478: Pass the new node when NewDeviceEvent is invoked.
Description

ihnorton suggested:
It seems this could be cleaner if the NewDeviceEvent invokation included the new node as the data packet. Would you consider changing the signature? (I can make relevant changes and PR if so).

Additional Information

Although vtkMRMLIGTLConnectorNode invokes NewDeviceEvent when it receives a message with a new device name, it does not pass a pointer to the new node. Because of this, event handlers need to find the new node from the MRML scene.

TagsToBeBackported

Activities

tokuda

tokuda

2013-11-22 10:05

developer   ~0010361

I checked in the code in the main repository

https://github.com/openigtlink/OpenIGTLinkIF/commit/8283638bb665f0475f9f095dd66ce4f4b3bb401b
jcfr

jcfr

2013-11-25 10:38

administrator   ~0010381

Fixed in r22727
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22727
jcfr

jcfr

2014-03-06 05:25

administrator   ~0011219

Closing resolved issues that have not been updated in more than 3 months

Issue History

Date Modified Username Field Change
2013-11-05 17:45 tokuda New Issue
2013-11-05 17:45 tokuda Status new => assigned
2013-11-05 17:45 tokuda Assigned To => tokuda
2013-11-22 10:05 tokuda Note Added: 0010361
2013-11-25 10:37 jcfr Fixed in Version => Slicer 4.3.2
2013-11-25 10:37 jcfr Target Version => Slicer 4.3.2
2013-11-25 10:37 jcfr Tag Attached: ToBeBackported
2013-11-25 10:38 jcfr Note Added: 0010381
2013-11-25 10:38 jcfr Status assigned => resolved
2013-11-25 10:38 jcfr Resolution open => fixed
2014-03-06 05:25 jcfr Note Added: 0011219
2014-03-06 05:28 jcfr Status resolved => closed
2014-03-06 10:16 nicole Target Version Slicer 4.3.2 => Slicer 4.4.0
2014-03-06 10:17 nicole Fixed in Version Slicer 4.3.2 => Slicer 4.4.0