View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0003417Slicer4Core: CLI infrastructurepublic2013-09-24 13:342017-06-07 23:27
Reporternicole Assigned Tonicole  
PrioritynormalSeveritymajorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.1Fixed in VersionSlicer 4.4.0 
Summary0003417: Creating new point nodes in CLIs creates a Slicer3 vtkMRMLFiducialListNode
Description

CLIs are creating vtkMRMLFiducialListNodes by default from their node selectors. Nees to update to create Markups fiducial nodes.

Steps To Reproduce

Go to the simple region growing segmentation module
In Segmentation Parameters, Seeds, click on the node selector and click on Create New FiducialList
In the Data module, turn on Display MRML IDs and see that it's a vtkMRMLFiducialNodeList.

Additional Information

qSlicerCLIModuleUIHelperPrivate::createPointTagWidget

TagsNo tags attached.

Activities

nicole

nicole

2013-09-24 13:46

administrator   ~0010080

Last edited: 2013-09-24 13:50

I've got it creating a new markups fiducial node, but it's not being set active for adding points to, nor are the added points (once it's made active via the Markups module) showing up in the viewers. A display node is not created.
nicole

nicole

2013-09-24 14:35

administrator   ~0010081

Fixes checked in as svn 22482:
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22482
jcfr

jcfr

2013-09-24 14:47

administrator   ~0010082

Could you also update the following two pages to ensure that the wiki documentation is up-tod-date ?

http://slicer.org/slicerWiki/index.php/Documentation/4.3/ModulesMetadata

http://slicer.org/slicerWiki/index.php/Documentation/Nightly/ModulesMetadata
nicole

nicole

2013-09-24 15:00

administrator   ~0010083

Metadata pages on the wiki updated to svn 22482
jcfr

jcfr

2014-03-06 05:00

administrator   ~0010874

Closing resolved issues that have not been updated in more than 3 months

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file e5841531

2013-09-24 18:33:45

naucoin

Details Diff 		BUG: update the CLIs to create new Markup fiduicals from point node selector

The command line module GUI helper hadn't been updated to create Markups
Fiducial nodes by default when creating new nodes was enabled. It was still
set up to create Slicer3 vtkMRMLFiducialListNodes.
Now by default a vtkMRMLMarkupsFiducialNode will be created when Create New is
selected.
Update the Markups module logic to detect node added events and add a display
node if not in batch processing, import or restore modes.
Updated the simple region growing segmentation help documentation to refer to the
Markups module.

Issue 0003417



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22482 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTCLI/qSlicerCLIModuleUIHelper.cxx Diff File
mod - Modules/CLI/SimpleRegionGrowingSegmentation/SimpleRegionGrowingSegmentation.xml Diff File
mod - Modules/Loadable/Markups/Logic/vtkSlicerMarkupsLogic.cxx Diff File
mod - Modules/Loadable/Markups/Logic/vtkSlicerMarkupsLogic.h Diff File

Issue History

Date Modified Username Field Change
2013-09-24 13:34 nicole New Issue
2013-09-24 13:34 nicole Status new => assigned
2013-09-24 13:34 nicole Assigned To => millerjv
2013-09-24 13:35 nicole Assigned To millerjv => nicole
2013-09-24 13:35 nicole Target Version => Slicer 4.3.1
2013-09-24 13:46 nicole Note Added: 0010080
2013-09-24 13:50 nicole Note Edited: 0010080
2013-09-24 14:35 nicole Note Added: 0010081
2013-09-24 14:35 nicole Status assigned => resolved
2013-09-24 14:35 nicole Resolution open => fixed
2013-09-24 14:47 jcfr Note Added: 0010082
2013-09-24 15:00 nicole Note Added: 0010083
2014-03-06 05:00 jcfr Note Added: 0010874
2014-03-06 05:01 jcfr Status resolved => closed
2014-03-06 05:56 jcfr Fixed in Version => Slicer 4.4.0
2017-06-07 23:27 Changeset attached => Slicer 2145-support-for-installing-extension-from-file e5841531