0003413: Saving a scene results in a crash if a node reference is added but its role is not

ID	Project	Category	View Status	Date Submitted	Last Update

0003413	Slicer4	Core: MRML	public	2013-09-23 05:39	2014-03-06 10:16

Reporter	pinter	Assigned To	alexy
Priority	normal	Severity	crash	Reproducibility	always
Status	closed	Resolution	fixed
Product Version	Slicer 4.3.0
Target Version	Slicer 4.4.0	Fixed in Version	Slicer 4.3.1

Summary	0003413: Saving a scene results in a crash if a node reference is added but its role is not
Description	If a reference is added to a node like this, then Slicer crashes when saving the scene: node->AddNodeReferenceID("custom", referencedNode->GetID()); If it is added like this, then there is no crash: node->AddNodeReferenceRole("custom", "customRef"); node->AddNodeReferenceID("custom", referencedNode->GetID()); Instead of crashing, Slicer should gracefully recover while logging an error.
Tags	No tags attached.

Date Modified	Username	Field	Change
2013-09-23 05:39	pinter	New Issue
2013-09-23 05:39	pinter	Status	new => assigned
2013-09-23 05:39	pinter	Assigned To	=> alexy
2013-09-23 05:49	pinter	Note Added: 0010045
2013-09-24 11:40	jcfr	Target Version	=> Slicer 4.3.2
2013-09-24 12:30	pinter	Relationship added	related to 0003416
2013-09-27 10:43	alexy	Note Added: 0010100
2013-09-27 10:43	alexy	Status	assigned => resolved
2013-09-27 10:43	alexy	Resolution	open => fixed
2013-09-27 11:39	pinter	Status	resolved => closed
2014-03-06 05:58	jcfr	Fixed in Version	=> Slicer 4.3.1
2014-03-06 10:16	nicole	Target Version	Slicer 4.3.2 => Slicer 4.4.0

pinter 2013-09-23 05:49 developer ~0010045	The crash occurs in vtkMRMLNode::WriteXML (line 458) where GetMRMLAttributeNameFromReferenceRole is called in the NodeReferences for loop.

alexy 2013-09-27 10:43 developer ~0010100	Fixed crash on writing a custom node reference. At revision: 22524