View Issue Details

IDProjectCategoryView StatusLast Update
0003410Slicer4Core: Building (CMake, Superbuild)public2018-03-02 11:06
Reporterjcfr Assigned Tohjmjohnson  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.5.0-1Fixed in VersionSlicer 4.5.0-1 
Summary0003410: Depends on MGH IO module provided by ITK
Description

From Kent:

If I was just proposing a change to ITK this would be a bit easier -- I'd
just go through ITK's gerrit review system.

As it is this has a few more moving parts.

The problem was that MGHImageIO was writing out Image origins incorrectly.
Eun Young Kim discovered this while using SimpleITK within Slicer to read
and write MGZ files.

I re-wrote the 'WriteHeader' code where it converts the origin from ITK
conventions to FreeSurfer conventions, so the conversion code on the Write
side matches that on the Read side.

But getting this incorporated back into Slicer and ITK has more than one
step.

ITK:

  1. Merge the pull request into the Slicer/itkMGHImageIO repository on
    github. The pull request is here:
    https://github.com/Slicer/itkMGHImageIO/pull/3
  2. Get a topic through ITK Gerrit to update the SHA to match the revision
    of my change.

SLICER:

Slicer has an older version of MGHImageIO than the one used by ITK; I
don't know if Slicer uses this and turns on the MGHImageIO remote module
when it builds ITK.
A) If Slicer uses the old code in Slicer/Libs/MGHImageIO, then this should
be replaced by the code in the Github repository above.
B) If Slicer uses the ITK version via the ITK remote module for
itkMGHImageIO, then Š well there's a bit of a problem, as when the fix
gets propogated through into ITK, it will be at the Development head for
ITK, and be some time before it's part of a ITK Minor version release.
Slicer no doubt picks a particular ITK version and sticks with it until a
newer version comes along with sufficient new functionality and bug fixes
to justify re-validating ITK all over again with Slicer.

So I have the fix, I just need to know what I need to do for it to be
pushed where it needs to be.

TagsNo tags attached.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 3a2aeb6f

2013-09-25 00:03:36

jcfr

Details Diff
COMP: Fix bug in writing origins to MGH files

Waiting Slicer makes use of the ITK remote module "itkMGHImageIO" (issue 0003410),
this commit has been back-ported from Slicer/itkMGHImageIO@13f5e11ef.

It also has been tested by Hans as part of ITK.

Test project /Users/johnsonhj/Dashboard/src/ITK-ccache
Start 2065: MGHIOInDoxygenGroup
1/7 Test 0002065: MGHIOInDoxygenGroup .............. Passed 0.09 sec
Start 2066: MGHFactoryCreationTest
2/7 Test 0002066: MGHFactoryCreationTest ........... Passed 0.15 sec
Start 2067: MGHReadImagesTest_mgz
3/7 Test 0002067: MGHReadImagesTest_mgz ............ Passed 3.77 sec
Start 2068: MGHReadImagesTest_mgh
4/7 Test 0002068: MGHReadImagesTest_mgh ............ Passed 0.49 sec
Start 2069: MGHReadImagesTest_mgh.gz
5/7 Test 0002069: MGHReadImagesTest_mgh.gz ......... Passed 3.88 sec
Start 2070: itkMGHIOInternalTests
6/7 Test 0002070: itkMGHIOInternalTests ............ Passed 0.07 sec
Start 2071: itkMGHIOOriginTest
7/7 Test 0002071: itkMGHIOOriginTest ............... Passed 3.58 sec

More details here: http://review.source.kitware.com/#/c/12771/

From: Kent Williams <norman-k-williams@uiowa.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22485 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MGHImageIO/itkMGHImageIO.cxx Diff File

Issue History

Date Modified Username Field Change
2013-09-20 15:00 jcfr New Issue
2013-09-20 15:00 jcfr Status new => assigned
2013-09-20 15:00 jcfr Assigned To => jcfr
2013-09-20 15:00 jcfr Assigned To jcfr =>
2013-09-20 15:00 jcfr Target Version => Slicer 4.3.2
2014-03-06 08:48 nicole Status assigned => new
2014-03-06 09:13 jcfr Status new => assigned
2014-03-06 09:13 jcfr Assigned To => jcfr
2014-03-06 09:14 jcfr Target Version Slicer 4.3.2 => Slicer 4.4.0
2014-04-22 10:06 jcfr Status assigned => acknowledged
2014-04-22 10:06 jcfr Target Version Slicer 4.4.0 =>
2015-08-03 22:20 jcfr Status acknowledged => assigned
2015-08-03 22:20 jcfr Assigned To jcfr => hjmjohnson
2015-08-03 22:20 jcfr Target Version => Slicer 4.4.1
2015-09-01 10:29 jcfr Target Version Slicer 4.4.1 => Slicer 4.5.0-1
2015-09-15 15:15 jcfr Note Added: 0013276
2015-09-15 15:15 jcfr Status assigned => resolved
2015-09-15 15:15 jcfr Fixed in Version => Slicer 4.5.0-1
2015-09-15 15:15 jcfr Resolution open => fixed
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file 3a2aeb6f
2018-03-02 11:06 jcfr Status resolved => closed