View Issue Details

IDProjectCategoryView StatusLast Update
0003289Slicer4Module Annotationspublic2017-06-07 23:27
Reporterfedorov Assigned Tonicole  
PrioritynormalSeverityblockReproducibilityalways
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0003289: vtkDoubleArray are saved as measurement (.mcsv) but cannot be read back
Description

When .mcsv is being read back into Slicer, it can only be read as Volume, ScalarOverlay or FiberBundle, effectively preventing the user from being able to load a DoubleArray back into Slicer.

Probably an option to interpret .mcsv as a DoubleArray and the corresponding functionality should be added.

TagsNo tags attached.

Activities

nicole

nicole

2013-09-03 12:17

administrator   ~0009861

Can you add steps to reproduce? I'm not sure how to save a double array as .mcsv.

fedorov

fedorov

2013-09-03 12:51

developer   ~0009868

Steps to reproduce:

1) "Add data" with the attached .csv file: load as DoubleArray
2) "Save data" this DoubleArray:

2.1) if you choose .mcsv, it is saved as "Measurement CSV"(according to the text in "Save data". Reading it back tries to read it as a Volume!!??

2.2) if you save as .txt, you only have the option to load as "Color" or other unrelated types, but not as DoubleArray.

2013-09-03 12:52

 

BC10-Visit1-AIF.csv (2,178 bytes)
nicole

nicole

2013-09-03 13:34

administrator   ~0009870

My suspicion is that there's a missing Qt IO class for this data type that should be registered with a factory so that the double arryas can be saved and loaded properly...

In vtkMRMLDoubleArrayStorageNode::InitializeSupportedReadFileTypes and InitializeSupportedWriteFileTypes it lists .mcsv files as the default extension which is correct.

Trying it out in Slicer, the main problem seems to be reloading them, they're being saved in the right format (Measurement CSV (.mcsv) is correct, a ruler appears in the save dialog with the description Annotation list CSV (.acsv)).

This isn't an Annotations module bug, it's a bug in the QT IO for loading, in Modules/Loadable/DoubleArrays/qSlicerDoubleArraysIO (look into: does the description have to match the storage node, will just fixing the extensions there do it (only lists .csv)), or in the load data dialogue box.

nicole

nicole

2013-09-03 13:40

administrator   ~0009871

Yes, this fixes it:

Index: qSlicerDoubleArraysIO.cxx

--- qSlicerDoubleArraysIO.cxx (revision 22390)
+++ qSlicerDoubleArraysIO.cxx (working copy)
@@ -91,7 +91,7 @@
QStringList qSlicerDoubleArraysIO::extensions()const
{
return QStringList()

  • << "Double Array (*.csv)"
  • << "Double Array (*.mcsv)"
    ;
    }

Once the release releasing is done, I'll commit the change to the trunk and port it to the branch for the 4.3.1 release.

nicole

nicole

2013-09-03 13:48

administrator   ~0009872

Fixed in svn 22396.
http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&amp;revision=22396

fedorov

fedorov

2013-09-04 03:55

developer   ~0009885

Minor regression is that .csv files can no longer be loaded as DoubleArray, .mcsv should be used instead. Perhaps this should be noted in the corresponding documentation.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file 93d3f5d4

2013-09-03 17:47:50

naucoin

Details Diff
BUG: fix loading of double array files

The file extension didn't match that in the double array storage node.

Fixes issue 0003289



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22396 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/DoubleArrays/qSlicerDoubleArraysIO.cxx Diff File

Issue History

Date Modified Username Field Change
2013-08-11 08:50 fedorov New Issue
2013-08-11 08:50 fedorov Status new => assigned
2013-08-11 08:50 fedorov Assigned To => nicole
2013-09-03 12:17 nicole Note Added: 0009861
2013-09-03 12:17 nicole Target Version => Slicer 4.4.0
2013-09-03 12:51 fedorov Note Added: 0009868
2013-09-03 12:52 fedorov File Added: BC10-Visit1-AIF.csv
2013-09-03 13:34 nicole Note Added: 0009870
2013-09-03 13:40 nicole Note Added: 0009871
2013-09-03 13:48 nicole Note Added: 0009872
2013-09-03 13:48 nicole Status assigned => resolved
2013-09-03 13:48 nicole Fixed in Version => Slicer 4.3.0
2013-09-03 13:48 nicole Resolution open => fixed
2013-09-03 13:49 nicole Target Version Slicer 4.4.0 => Slicer 4.3.0
2013-09-04 03:55 fedorov Note Added: 0009885
2013-09-04 03:55 fedorov Status resolved => closed
2017-06-07 23:27 Changeset attached => Slicer 2145-support-for-installing-extension-from-file 93d3f5d4