View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002993Slicer4Core: Base Codepublic2013-03-04 11:292014-03-06 05:59
Reporterimphead Assigned Tosnape  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.2.2-1 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0002993: Setting "automatic" for spacing (and fov) not implemented?
Description

In the slice controllers, the pull-down menu (second from right, with a nice little ruler icon, next to rotate to volume plane) is not working except for the manual setting. That is, it's not possible to set the spacing back to automatic. I peeked at the source code: yes the flag is flipped back to automatic, but there doesn't seem to be code that reacts to this changed setting?

Also, at the tweak level, the tool tip is missing.

Slicer version is 4.2.2-1 r21513.

TagsNo tags attached.

Activities

imphead

imphead

2013-03-12 13:24

reporter   ~0008114

I dug around more. My original description is not quite right. The problem has two parts to it.

(1) There's no indication what the spacing mode is in the widget (only in the controller module). That's just a tweak to correct that.

(2) Unsetting and then setting "automatic" does return the increment to same value. I was wrong in my description. But the offset is not reset to center the slices relative to physical slices. So the user may see something different than before "automic" was flipped off and on again if the slider is moved modulo a different prescribed spacing. The offset is not snapped back as I'd expect when "automatic" is turned on again. There is a more general, semantic problem at play here however. I'll investigate that separately and report back.

So I'd downgrade this to a UI tweak for now: just show the status of "automatic" or "prescribed" in the pull down menu.
jcfr

jcfr

2013-03-28 12:27

administrator   ~0008260

For reference: https://github.com/jamiesnape/Slicer/tree/2993-set-automatic-spacing
jcfr

jcfr

2013-03-28 12:29

administrator   ~0008261

Reminder sent to: finetjul, millerjv

@Julien, Jim: Could you review the topic: https://github.com/jamiesnape/Slicer/compare/2993-set-automatic-spacing
Thanks
snape

snape

2013-04-17 12:03

developer   ~0008427

Patch committed: https://github.com/Slicer/Slicer/commit/b8fdb451255c7c6422c98e82d06f91ddd4c31978

Issue History

Date Modified Username Field Change
2013-03-04 11:29 imphead New Issue
2013-03-04 11:29 imphead Status new => assigned
2013-03-04 11:29 imphead Assigned To => jcfr
2013-03-04 13:09 jcfr Assigned To jcfr => snape
2013-03-04 13:09 jcfr Target Version => Slicer 4.3.0
2013-03-12 13:24 imphead Note Added: 0008114
2013-03-28 12:27 jcfr Note Added: 0008260
2013-03-28 12:29 jcfr Note Added: 0008261
2013-03-28 12:30 jcfr Status assigned => feedback
2013-04-17 12:03 snape Note Added: 0008427
2013-04-17 12:05 snape Status feedback => resolved
2013-04-17 12:05 snape Resolution open => fixed
2013-06-11 09:20 imphead Status resolved => closed
2014-03-06 05:59 jcfr Fixed in Version => Slicer 4.3.0