View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002881Slicer4Core: MRMLpublic2013-01-23 07:082017-06-07 23:27
Reporterwangk Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.2.2-1 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0002881: qMRMLVolumeInfoWidget not updated after MRML node removed
Description

I have found a minor issue with the qMRMRVolumeInfoWidget class code. when a volume is loaded and then removed from the scene, the volume info widget does not get updated and it will still display the old volume info. see attached volume_info_not_updated.png picture.

TagsNo tags attached.

Activities

2013-01-23 07:08

 

volume_info_not_updated.png (23,149 bytes)
wangk

wangk

2013-01-23 07:53

developer   ~0007721

sorry. please ignore the previous note. Topic pushed to https://github.com/kevinwangcanada/Slicer/tree/2881-qMRMLVolumeInfoWidget-not-updated-after-MRML-node-removed
wangk

wangk

2013-01-24 08:51

developer   ~0007730

I have pushed the updated topic to https://github.com/kevinwangcanada/Slicer/tree/2881-qMRMLVolumeInfoWidget-not-updated-after-MRML-node-removed

Let me know if this is ok.

Thanks.
wangk

wangk

2013-01-25 05:51

developer   ~0007740

Hi Jc,

I have squashed and pushed the new commit to github. Sadly I have to use --force to push the commit and now the comments on the previous commits are all gone. I hope there is a way to keep them.

Thanks and let me know if this version is fine.
jcfr

jcfr

2013-02-15 06:25

administrator   ~0007943

Hi Kevin,

Fixed in r21709
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21709

Ps: I used option "--use-log-author" instead of "--add-author-from" and it didn't give you credit. Sorry about that.
wangk

wangk

2013-03-11 06:19

developer   ~0008107

Thanks, I have closed the issue
jcfr

jcfr

2017-06-07 23:27

administrator   ~0014657

Fix committed to 2145-support-for-installing-extension-from-file branch.

Related Changesets

Slicer: 2145-support-for-installing-extension-from-file bfae4f54

2013-02-15 11:23:06

jcfr

Details Diff 		BUG: Ensure qMRMLVolumeInfoWidget state is cleared when widget is disabled.

See http://na-mic.org/Mantis/view.php?id=2881
Fixes 0002881

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21709 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Widgets/qMRMLVolumeInfoWidget.cxx Diff File

Issue History

Date Modified Username Field Change
2013-01-23 07:08 wangk New Issue
2013-01-23 07:08 wangk Status new => assigned
2013-01-23 07:08 wangk Assigned To => alexy
2013-01-23 07:08 wangk File Added: volume_info_not_updated.png
2013-01-23 07:53 wangk Note Added: 0007721
2013-01-24 08:51 wangk Note Added: 0007730
2013-01-25 05:51 wangk Note Added: 0007740
2013-02-15 06:14 jcfr Target Version => Slicer 4.3.0
2013-02-15 06:25 jcfr Note Added: 0007943
2013-02-15 06:25 jcfr Status assigned => resolved
2013-02-15 06:25 jcfr Fixed in Version => Slicer 4.3.0
2013-02-15 06:25 jcfr Resolution open => fixed
2013-03-11 06:19 wangk Note Added: 0008107
2013-03-11 06:19 wangk Status resolved => closed
2017-06-07 23:27 jcfr Changeset attached => Slicer 2145-support-for-installing-extension-from-file bfae4f54
2017-06-07 23:27 jcfr Note Added: 0014657
2017-06-07 23:27 jcfr Assigned To alexy => jcfr