View Issue Details

IDProjectCategoryView StatusLast Update
0002869Slicer4Core: MRMLpublic2013-03-19 13:15
Reporterwangk Assigned Towangk  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product VersionSlicer 4.2.2-1 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0002869: Direction Matrix not exposed in volume info widget
Description

Currently the direction matrix of a volume node is not displayed in the volume module and this can potentially create some confusion. It would be nice to expose it by enhancing the qMRMLVolumeInfoWidget class.

See https://www.assembla.com/spaces/slicerrt/tickets/198#/activity/ticket: for additional comments on this issue.

TagsNo tags attached.

Relationships

has duplicate 0002083 closedcrmullin Add orientation information in qMRMLVolumesInfoWidget 
related to 0003010 closedfinetjul Volume module GUI permanently modifies the spacing of the selected volume 

Activities

wangk

wangk

2013-01-14 08:49

developer   ~0007662

If needed, I could create and submit a patch.

pieper

pieper

2013-01-14 09:02

administrator   ~0007663

Kevin, if you could submit a working patch, that would be great! Or we we can try to do it ourselves - unless I'm missing something it should be just a few lines.

wangk

wangk

2013-01-14 11:23

developer   ~0007666

Steve, I will try to create a patch then. As you said there should be just a few lines need to be added.

wangk

wangk

2013-01-18 09:54

developer   ~0007711

Topic pushed to https://github.com/kevinwangcanada/Slicer/tree/2869-Direction-Matrix-not-exposed-in-volume-info-widget/

I used 3 ctkCoordinateWidgets to display the direction vectors for I, J, K. see the attached picture. If you think this takes too much space, I can try either a textbox that puts the 3 vectors into one line (separated by ;) or use a ctkCollapsibleGroupBox.

2013-01-18 09:54

 

newvolumeinfowidget.png (21,824 bytes)
newvolumeinfowidget.png (21,824 bytes)
wangk

wangk

2013-01-18 09:59

developer   ~0007712

I have also found a minor issue with the ctkVolumeInfoWidget code. when a volume is loaded and then removed from the scene, the volume info widget does not get updated and it will still display the old info. see attached volume_info_not_updated.png picture. I have modified the code to fix that. Do I need to create a new ticket/topic/branch for that or maybe I can use the same topic again?

2013-01-18 10:00

 

finetjul

finetjul

2013-01-23 08:33

administrator   ~0007722

Last edited: 2013-01-23 08:34

I believe you could use a ctkMatrixWidget instead, it will take less space.
Make sure the matrix can be selectable (if someone wants to copy the matrix).

wangk

wangk

2013-01-23 10:59

developer   ~0007723

Thanks for the explanation. I am able to select all the cells in the matrix widget by changing the selectionMode to QAbstractItemView::MultipleSeletion, however, ctkMatrixWidget will need to be modified to enable the copy/paste functionality. Maybe we reconsider this feature later?

finetjul

finetjul

2013-01-23 11:05

administrator   ~0007724

Sure, this is definitely out of scope.
I didn't know ctkMatrixWidget didn't support the multi selection correctly. My bad.

wangk

wangk

2013-01-24 09:09

developer   ~0007731

No problem, I have pushed the updated topic to https://github.com/kevinwangcanada/Slicer/tree/2869-Direction-Matrix-not-exposed-in-volume-info-widget

Thanks.

jcfr

jcfr

2013-02-15 06:42

administrator   ~0007946

Fixed in r21711
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21711

wangk

wangk

2013-03-11 06:18

developer   ~0008106

thanks. I have closed the issue.

finetjul

finetjul

2013-03-19 12:42

administrator   ~0008171

It most likely generated the following issue 0003010

Issue History

Date Modified Username Field Change
2013-01-14 08:17 wangk New Issue
2013-01-14 08:17 wangk Status new => assigned
2013-01-14 08:17 wangk Assigned To => alexy
2013-01-14 08:49 wangk Note Added: 0007662
2013-01-14 09:02 pieper Note Added: 0007663
2013-01-14 11:23 wangk Note Added: 0007666
2013-01-18 09:54 wangk Note Added: 0007711
2013-01-18 09:54 wangk File Added: newvolumeinfowidget.png
2013-01-18 09:59 wangk Note Added: 0007712
2013-01-18 10:00 wangk File Added: volume_info_not_updated.png
2013-01-23 08:33 finetjul Note Added: 0007722
2013-01-23 08:34 finetjul Note Edited: 0007722
2013-01-23 10:59 wangk Note Added: 0007723
2013-01-23 11:05 finetjul Note Added: 0007724
2013-01-24 09:09 wangk Note Added: 0007731
2013-02-15 06:14 jcfr Target Version => Slicer 4.3.0
2013-02-15 06:42 jcfr Note Added: 0007946
2013-02-15 06:42 jcfr Status assigned => resolved
2013-02-15 06:42 jcfr Fixed in Version => Slicer 4.3.0
2013-02-15 06:42 jcfr Resolution open => fixed
2013-03-11 06:18 wangk Note Added: 0008106
2013-03-11 06:18 wangk Status resolved => closed
2013-03-19 12:40 finetjul Relationship added has duplicate 0002083
2013-03-19 12:41 finetjul Relationship added related to 0003010
2013-03-19 12:42 finetjul Note Added: 0008171
2013-03-19 13:15 jcfr Assigned To alexy => wangk