View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0002728 | Slicer4 | Core: GUI | public | 2012-11-05 05:32 | 2014-03-07 09:08 |
Reporter | Daniel Sachs | Assigned To | alexy | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | confirmed | Resolution | open | ||
Product Version | Slicer 4.2.0 | ||||
Target Version | Fixed in Version | ||||
Summary | 0002728: Problem with outlines of label maps in the lightbox view | ||||
Description | When trying to only view the outlines of a labe lmap in the lightbox view, | ||||
Additional Information | I'm using Slicer on a Mac (with Mountain Lion) and tried it with the latest | ||||
Tags | No tags attached. | ||||
2012-11-05 05:32
|
|
I believe the issue here is that the code to decide if a pixel is on the boundary of the label region is taking into account the 3D neighbors when it should only consider the 2D neighbors (because in lightbox mode the layers are extracted as a 3D volume and then split up per-cell. We should probably move the boundary detection code further down the pipeline (if possible) or else add a mode in the vtk filter so that it treats the slices independently. Perhaps modifying the vtk filter is the more straightforward and more generally useful solution. |
|
This isn't a scene views issue so much as a light box issue, Steve who do you suggest should be assigned to it? |
|
I'll assign this to myself for now - I think it's an issue with the vtk filter used to create the outline volumes not working correctly in slice mode. It'll take a bit of work to make it behave as expected in this mode due to the way lightboxes are implemented. |
|
The code is here: https://github.com/Slicer/Slicer/blob/master/Libs/MRML/Logic/vtkImageLabelOutline.cxx It may be as simple as changing this line to SetNeighborTo4 instead of 8: https://github.com/Slicer/Slicer/blob/master/Libs/MRML/Logic/vtkImageLabelOutline.cxx#L33 But I haven't tested it. |
|
I just tested it, but changing 8 to 4 doesn't resolve the problem. |
|
Thanks for checking - after a little closer look, it probably comes down to (optionally) replacing the tripple nested for-loop construct with a double nested one that only looks in-plane. https://github.com/Slicer/Slicer/blob/master/Libs/MRML/Logic/vtkImageLabelOutline.cxx#L135 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2012-11-05 05:32 | Daniel Sachs | New Issue | |
2012-11-05 05:32 | Daniel Sachs | Status | new => assigned |
2012-11-05 05:32 | Daniel Sachs | Assigned To | => nicole |
2012-11-05 05:32 | Daniel Sachs | File Added: lightbox.png | |
2012-11-05 05:53 | pieper | Note Added: 0007048 | |
2012-11-05 05:53 | pieper | Status | assigned => confirmed |
2012-11-05 05:53 | pieper | Target Version | => Slicer 4.3.0 |
2012-11-12 06:13 | nicole | Note Added: 0007160 | |
2012-11-14 03:30 | pieper | Note Added: 0007204 | |
2012-11-14 03:30 | pieper | Assigned To | nicole => pieper |
2012-11-14 03:30 | pieper | Category | Module SceneViews => GUI |
2012-12-18 10:15 | pieper | Assigned To | pieper => alexy |
2012-12-18 10:19 | pieper | Note Added: 0007539 | |
2013-03-19 02:56 | Daniel Sachs | Note Added: 0008139 | |
2013-03-19 03:38 | pieper | Note Added: 0008140 | |
2013-08-02 05:46 | alexy | Target Version | Slicer 4.3.0 => Slicer 4.4.0 |
2014-03-07 09:08 | pieper | Target Version | Slicer 4.4.0 => |