View Issue Details

IDProjectCategoryView StatusLast Update
0002158Slicer4Core: Extensionspublic2012-10-02 14:20
Reporterfinetjul Assigned Tojcfr  
PrioritynormalSeveritytextReproducibilityN/A
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.2.0 
Summary0002158: Rename variable referring to slicer extension as "sext"
Description

From Julien - June 4th 2012

As a side comment, I'm not sure SEXT is the best variable name component:
http://en.wikipedia.org/wiki/Sexting

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20307

TagsNo tags attached.

Activities

jcfr

jcfr

2012-06-04 05:17

administrator   ~0004756

the term "sext" is left over from Slicer3:

$ cd ./Slicer3/Scripts
$ ack -i sext
lsext.tcl
7:# lsext.tcl
12:# lsext [server] [options]
37:set ::LSEXT(server) "http://ext.slicer.org/ext"
38:set ::LSEXT(build) ""
39:set ::LSEXT(date) ""
40:set ::LSEXT(verbose) "false"
53: set ::LSEXT(build) [lindex $argv $i]
62: set ::LSEXT(date) [lindex $argv $i]
66: set ::LSEXT(verbose) "true"
87: set ::LSEXT(server) $argv
96: if { $::LSEXT($arg) == "" } {
102:if { $::LSEXT(verbose) } {
103: puts [parray ::LSEXT]
111:set url $::LSEXT(server)/$::LSEXT(date)/$::LSEXT(build)/
113:if { $::LSEXT(verbose) } {
120:if { $::LSEXT(verbose) } {

jcfr

jcfr

2012-06-25 14:39

administrator   ~0004929

Fixed in r20486
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20486

jcfr

jcfr

2012-07-27 15:40

administrator   ~0005386

Dear issue reporter,

Good news :) Slicer developers SOLVED the problem you reported - YOU now need to VERIFY and CLOSE this issue.

finetjul

finetjul

2012-07-30 09:23

administrator   ~0005459

SlicerFunctionExtractExtensionDescription.cmake and
SlicerBlockBuildPackageAndUploadExtensions.cmake still use that name.

jcfr

jcfr

2012-10-02 08:34

administrator   ~0006332

Looking again at commit r20486, I think it removed all occurences of "SEXT"
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20486

finetjul

finetjul

2012-10-02 09:20

administrator   ~0006333

https://github.com/Slicer/Slicer/blob/master/Extensions/CMake/SlicerFunctionExtractExtensionDescription.cmake#L95

jcfr

jcfr

2012-10-02 14:15

administrator   ~0006349

Fixed in r21094
See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=21094

Issue History

Date Modified Username Field Change
2012-06-04 05:14 jcfr New Issue
2012-06-04 05:14 jcfr Status new => assigned
2012-06-04 05:14 jcfr Assigned To => jcfr
2012-06-04 05:14 jcfr Reporter jcfr => finetjul
2012-06-04 05:14 jcfr Target Version => Slicer 4.3.0
2012-06-04 05:17 jcfr Note Added: 0004756
2012-06-04 05:59 finetjul Severity minor => text
2012-06-04 05:59 finetjul Reproducibility have not tried => N/A
2012-06-25 14:39 jcfr Note Added: 0004929
2012-06-25 14:39 jcfr Status assigned => resolved
2012-06-25 14:39 jcfr Fixed in Version => Slicer 4.1.2 - July 1st 2012
2012-06-25 14:39 jcfr Resolution open => fixed
2012-07-27 15:40 jcfr Note Added: 0005386
2012-07-30 09:23 finetjul Note Added: 0005459
2012-07-30 09:23 finetjul Status resolved => assigned
2012-08-28 01:47 jcfr Fixed in Version Slicer 4.1.2 - August => Slicer 4.2.0 - Feature freeze Sept 1st 2012
2012-10-02 08:34 jcfr Note Added: 0006332
2012-10-02 08:34 jcfr Status assigned => resolved
2012-10-02 09:20 finetjul Note Added: 0006333
2012-10-02 09:20 finetjul Status resolved => assigned
2012-10-02 14:15 jcfr Note Added: 0006349
2012-10-02 14:15 jcfr Status assigned => resolved
2012-10-02 14:20 finetjul Status resolved => closed