June 13/12 I added the delete multiple models option, as well as checking that hierarchies get deleted properly. Can you double check that this functionality is what you were requesting?

Added the ability to delete model hierarchies via svn 20821-20823. No crashes observed.

There are no crashes any more, but there are a couple of new issues (latest trunk version, on Win7, 64-bit, release mode).

How to reproduce:

Load MRHead sample
Go to the editor module, draw 6 structures with different colors
*Go to the model maker, create a new hierarchy, generate the models
=> ERROR: Only 3 models are visible (the 1st, 2nd, and 3rd), the 4th, 5th, 6th models are generated with the correct colors, but with incorrect geometry (the same as the 1st, 2nd, and 3rd)

Go to model maker again, click Apply =>All the models are correctly appear
Go to Models
Turn off the visibility of the first listed model under Models (Model_4_connective_tissue)
=> ERROR: it jumps to the second place (below Model_5_blood)
Turn off the visibility of the first listed model (Model_5_blood)
=> ERROR: it jumps the third place in the list

Delete models from the list (I couldn't reproduce this, just happened once)
Hide all models
=>ERROR: the deleted model is still visible in the 3D viewer (in gray)

*Exit slicer
=>ERROR: there are leaks

Restart slicer, recreate the models
Go to the Data module, delete a model
*Go to models module
=>ERROR: instead of the seeing only 5 models, there are 5 models and a "Modelhierarchy_5" node listed under the Models hierarchy node (it seems that the model deleted in the data module has been converted to a model hierarchy node)

*Click on the checkbox at the "Modelhierarchy_5" node
=>ERROR: the "Model_2_bone" model jumps into the "Modelhierarchy_5" hierarchy

The delete in the data module doesn't delete hierarchy nodes (it just deletes the selected node, not any heirarchies it may be associated with), that's why I put the hierarchy deletion in the models module.

The jumping around of the entries in the list isn't related to deleting, but to the scene models and tree views.

Could you please put the new bugs into new bug reports and make them related to this one (the model maker ones esp.)? It's easier to track and fix them that way.

Added 3 related issues (0002428, 0002429, 0002430). The only issues that I haven't included in these are the memory leak on quit and the hard-to-reproduce remaining model in the 3D viewer.

Thanks, I'm going to resolve this one now and will update the others as I work on those issues.

Sorry, it's crashing again.

How to reproduce:

• Create 5 models
• Go to Models module
• Create a hierarchy, drag&drop two models
• Right-click, choose delete the hierarchy node, click OK to delete all children
  => ERROR: the children and the hierarchy node still visible in the tree
• Click on the hierarchy node or children that was supposed to be deleted
  => ERROR: Slicer crashes

Tested on Slicer-4.1.0-2012-09-03-win-amd64.exe.

Are you creating the models via the editor + model maker?

It does not seem to matter how you create the models. It's reproducible by simply loading a couple of models from files or creating them one by one from the editor.

Hmm, odd, the crash goes away if I turn off the batch processing settings around the multiple delete (there's a lazy upate flag that's turned on). Let me see if I can get it working with the batch processing flags set, that helps with speed ups, but if not, I'll check in that change since it'll avoid the crash.

svn 20923 adds an update to the GUI tree after batch processing the deletion of multiple models ends.

Thank you it works correctly now. Tested on latest nightly Slicer-4.1.0-2012-10-05-win-amd64.