View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002087Slicer4Core: Building (CMake, Superbuild)public2012-05-18 10:292018-03-02 11:07
Reporterjcfr Assigned Tojcfr  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionFixed in VersionSlicer 4.6.0 
Summary0002087: Configure "vtkSlicerVersionConfigure.h.in" at build time to ensure it's always up-to-date
Description

If a "svn update" of the source doesn't affect a CMakeLists.txt file, the file vtkSlicerVersionConfigure.h.in won't be configure when Slicer is rebuilt.

This is causing problem for either the developer or the case of continuous dashboards.

TagsNo tags attached.

Relationships

related to 0001989 closedjcfr Update Extension documentation on wiki 

Activities

jcfr

jcfr

2012-05-18 10:59

administrator   ~0004497

Last edited: 2012-05-18 11:01

In fact dashboard always re-configure the project, it means this affect only the developer.

Set target to 4.3. For now the workaround is to run CMake after updating the source.
jcfr

jcfr

2012-07-17 08:05

administrator   ~0005162

From Andriy:

This is it. The version reported by Slicer (20537) does not match .
But actually the version reported by git in the Slicer source tree
(20592) is also different!

I thought from the issue report [1] that touching CMakeLists.txt would
resolve this, but after I did that and did make, the version reported
by Slicer is still 20537. What should I do to propagate the update of
the version to the build? (I understand build from scratch would
probably do it, but I don't want to go that route)
fedorov

fedorov

2012-07-17 08:07

developer   ~0005163

Which CMakeLists.txt do I need to touch to reconfigure the version? Touching top-level CMakeLists.txt does not seem to have effect.
jcfr

jcfr

2012-07-17 08:07

administrator   ~0005164

Deleting "vtkSlicerVersionConfigure.h" from Slicer-Superbuild/Slicer-build should do it.
fedorov

fedorov

2012-07-17 13:15

developer   ~0005170

yes it is updated now. the problem was because I had git-svn checkout, but was updating with "git pull". "git svn rebase" did the job.
jcfr

jcfr

2012-07-17 13:41

administrator   ~0005171

Should I still check on the server or the extension now show up in the extension manager ?
fedorov

fedorov

2012-07-17 13:42

developer   ~0005172

Yes, sorry -- the extensions issue remains.

I just had a browser tab open with this report, and wanted to close on the issue of svn version not showing up correctly. Sorry for confusion!

2012-07-17 14:13

 

Build-20535-Reporting.png (25,191 bytes)
Build-20535-Reporting.png (25,191 bytes)

2012-07-17 14:13

 

Build-20629-Reporting.png (25,572 bytes)
Build-20629-Reporting.png (25,572 bytes)
jcfr

jcfr

2012-07-17 14:15

administrator   ~0005175

Last edited: 2012-07-17 14:15

The second time you uploaded the extension, you probably forgot to specify your midas Email and API key .. and it default to a CDash upload. See screenshots attached to the issue.

Feel free to create an issue to capture and describe the problem so that warning or error messages are made more descriptive ...
jcfr

jcfr

2014-03-07 10:49

administrator   ~0011381

The workaround is to reconfigure the project using CMake.

This would be nice to fix - but considering there is a known workaround we think it's low priority right now.

Let us know if it is high priority for you or if you would like to help us by contributing a patch.
jcfr

jcfr

2016-06-13 20:15

administrator   ~0013968

Fixed in in r25189 to r25192

See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=25189
and http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=25192

Related Changesets

Import 2017-06-07 23:51:09: master 2a57053e

2016-06-13 20:12:03

jcfr

Details Diff 		BUG: Ensure vtkSlicerConfigureVersion header is always up-to-date. Fixes 0002087

Since vtkSlicerVersionConfigure.h was only updated at configure time,
a source code update that wasn't triggering a reconfigured was causing
the content of the header to be out of sync with the current build date
and revision.

This commit adds the target 'SlicerConfigureVersionHeader' ensuring
the version header is always up-to-date.

To ensure the file is generated when first needed, a dependency between
qSlicerBaseQTCore and SlicerConfigureVersionHeader is added.

Co-authored-by: Francois Budin <francois.budin@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25190 3bd1e089-480b-0410-8dfb-8563597acbee
add - CMake/SlicerConfigureVersionHeaderTarget.cmake Diff File
mod - CMakeLists.txt Diff File

Issue History

Date Modified Username Field Change
2012-05-18 10:29 jcfr New Issue
2012-05-18 10:29 jcfr Status new => assigned
2012-05-18 10:29 jcfr Assigned To => jcfr
2012-05-18 10:29 jcfr Target Version => Slicer 4.1.1
2012-05-18 10:59 jcfr Note Added: 0004497
2012-05-18 11:01 jcfr Note Edited: 0004497
2012-05-18 11:01 jcfr Target Version Slicer 4.1.1 => Slicer 4.3.0
2012-05-18 11:03 jcfr Relationship added related to 0001989
2012-05-18 11:06 jcfr Target Version Slicer 4.3.0 => Slicer 4.2.0 AHM Summer 2012
2012-07-17 08:05 jcfr Note Added: 0005162
2012-07-17 08:07 fedorov Note Added: 0005163
2012-07-17 08:07 jcfr Note Added: 0005164
2012-07-17 13:15 fedorov Note Added: 0005170
2012-07-17 13:41 jcfr Note Added: 0005171
2012-07-17 13:42 fedorov Note Added: 0005172
2012-07-17 14:13 jcfr File Added: Build-20535-Reporting.png
2012-07-17 14:13 jcfr File Added: Build-20629-Reporting.png
2012-07-17 14:15 jcfr Note Added: 0005175
2012-07-17 14:15 jcfr Note Edited: 0005175
2012-08-20 10:10 jcfr Target Version Slicer 4.2.0 - Feature freeze Sept 1st 2012 => Slicer 4.2.5
2012-08-21 09:40 jcfr Target Version Slicer 4.2.5 => Slicer 4.3.0
2013-08-27 11:43 jcfr Target Version Slicer 4.3.0 => Slicer 4.4.0
2014-03-07 10:49 jcfr Note Added: 0011381
2014-03-07 10:49 jcfr Status assigned => acknowledged
2014-03-07 10:50 jcfr Category Core: Extensions => Core: Building (CMake, Superbuild)
2014-03-07 10:50 jcfr Target Version Slicer 4.4.0 =>
2016-06-13 20:15 jcfr Note Added: 0013968
2016-06-13 20:15 jcfr Status acknowledged => resolved
2016-06-13 20:15 jcfr Fixed in Version => Slicer 4.6.0
2016-06-13 20:15 jcfr Resolution open => fixed
2017-06-10 08:51 jcfr Changeset attached => Slicer master 2a57053e
2018-03-02 11:07 jcfr Status resolved => closed