View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002070Slicer4Core: MRMLpublic2012-05-16 13:362012-05-17 11:06
Reporterfinetjul Assigned Topinter  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version 
Target VersionSlicer 4.2.0Fixed in VersionSlicer 4.2.0 
Summary0002070: Update qMRMLNodeAttributeTableView to use QString only
Description

From Julien - May 16, 2012:

Please also consider not using std::string in Qt classes, but solely QString.
See the point (1.3.)2.1:
http://wiki.slicer.org/slicerWiki/index.php/Documentation/4.1/Developers/Style_Guide#Functions

TagsNo tags attached.

Activities

pinter

pinter

2012-05-17 10:59

developer   ~0004470

Fixed in http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=20105
Please close if found eligible. Thanks!
finetjul

finetjul

2012-05-17 11:06

administrator   ~0004472

Looks good. Thanks !
Note for future work:

  • Generally, QString::toLatin1() is enough, the cast to const char* is done automatically, no need for toLatin1().constData()

Issue History

Date Modified Username Field Change
2012-05-16 13:36 jcfr New Issue
2012-05-16 13:36 jcfr Reporter jcfr => finetjul
2012-05-16 13:36 jcfr Assigned To => pinter
2012-05-16 13:36 jcfr Status new => assigned
2012-05-16 13:36 jcfr Target Version => Slicer 4.2.0 AHM Summer 2012
2012-05-17 10:59 pinter Note Added: 0004470
2012-05-17 10:59 pinter Status assigned => resolved
2012-05-17 10:59 pinter Resolution open => fixed
2012-05-17 11:06 finetjul Note Added: 0004472
2012-05-17 11:06 finetjul Status resolved => closed
2012-05-17 11:06 finetjul Fixed in Version => Slicer 4.2.0 AHM Summer 2012