View Issue Details

IDProjectCategoryView StatusLast Update
0001822Slicer4Module Editorpublic2017-06-10 08:51
Reporterkikinis Assigned Topieper  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.0.1 
Target VersionSlicer 4.3.0Fixed in VersionSlicer 4.3.0 
Summary0001822: Split volume results corrupted
Description

When I do a split and merge on a ct data set, the label maps are wrong. I put the CT data set into ronsexamples in a folder called sarcoma. See the attached before and after image. Workflow: slicer mac nightly 3-19, crop around the sarcoma use the editor with the croped tool. Run grow cut. split merge volume, click on one of the split labels, merge and build.

Additional Information

From Steve:
Was able to reproduce this issue on mac os (10.7) with release build.

The images appear to be due to threading corruption.

The issue does not occur if I set the global maximum number of threads to be 1 on a 4 core machine.

Also does not happen if I reload a scene that has the data file being split.

I'm working on an automated test that will reproduce this issue in an installed version of slicer.

TagsNo tags attached.

Relationships

related to 0001922 closedpieper add a self-testing module 

Activities

2012-03-21 06:24

 

Before.png (269,672 bytes)
Before.png (269,672 bytes)

2012-03-21 06:24

 

After.png (269,232 bytes)
After.png (269,232 bytes)
pieper

pieper

2012-03-22 10:20

administrator   ~0003911

For slicer 4.1 release I made this change:

http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=19676

Ron, let me know if you ever see this issue again.

For future use test should replicate the issue:

https://github.com/pieper/Slicer/blob/9a5ef6bdf2b95946553111ea0265102d04cda067/Modules/Scripted/EditorLib/Testing/ThresholdThreadingTest.py

it requires some changes in various parts of the code so I will commit it to the trunk after the 4.1 code freeze is over.

pieper

pieper

2012-04-20 05:18

administrator   ~0004049

Ron showed me what may be a issue that arose in the ChangeLabelEffect being used to remove the background label from a growcut result.

This is implemented with this class:

class VTK_SLICER_BASE_LOGIC_EXPORT vtkImageLabelChange : public vtkImageToImageFilter

kikinis

kikinis

2012-08-01 04:23

developer   ~0005482

Is there an action item for me on this?

jcfr

jcfr

2014-02-03 09:27

administrator   ~0010552

Last edited: 2014-02-03 09:27

In the HelperBox code, it is written that the multi-threaded version of 'vtkImageThreshold' should not be used until 0001822 (this issue) is solved and this issue mention that the commit adding the same message is resolving the issue ...

... this looks like a "catch 22". Should we update the comment in the code to mention that the multi threading is disabled for some unknown/To-Be-Determined reason and that for more details, developer should refer to issue 1822 ?

jcfr

jcfr

2015-06-05 11:21

administrator   ~0013118

May be the underlying issue is addressed by this commit: https://github.com/Kitware/VTK/commit/242656448e ?

pieper

pieper

2015-06-05 12:31

administrator   ~0013119

I don't think the commit Jc referenced is related - the split operation uses a regular threshold operation and the extents are not different between input and output.

lassoan

lassoan

2016-09-08 09:06

developer   ~0014080

Steve, could you please test if the issue is still there on Mac with current vtk7 version? There is a test that you created that you can run to reproduce the problem.

pieper

pieper

2016-09-13 18:11

administrator   ~0014094

I tested this on today's Nightly (with vtk7) and I couldn't replicate the issue (good!). I'll go ahead and remove the line that forces single threading[1] and check in the result.

https://github.com/Slicer/Slicer/blob/846a654748e263ca51ac43c0d324d260c03e008e/Modules/Scripted/EditorLib/EditUtil.py#L345

Related Changesets

Import 2017-06-07 23:51:09: master bbaa270d

2016-09-13 18:06:54

pieper

Details Diff
BUG: 0001822 is no longer reproducible on current VTK version

Tested on today's mac release build.

See discussion at http://na-mic.org/Bug/view.php?id=1822

From: Steve Pieper <pieper@isomics.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25356 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Scripted/EditorLib/EditUtil.py Diff File

Issue History

Date Modified Username Field Change
2012-03-21 05:43 pieper New Issue
2012-03-21 05:43 pieper Status new => assigned
2012-03-21 05:43 pieper Assigned To => pieper
2012-03-21 06:24 pieper File Added: Before.png
2012-03-21 06:24 pieper File Added: After.png
2012-03-21 07:16 finetjul Reporter pieper => kikinis
2012-03-21 07:16 finetjul Description Updated
2012-03-21 07:16 finetjul Additional Information Updated
2012-03-21 07:17 finetjul Product Version => Slicer 4.0.1
2012-03-22 10:20 pieper Note Added: 0003911
2012-03-22 10:20 pieper Status assigned => feedback
2012-03-22 10:20 pieper Resolution open => fixed
2012-04-20 05:18 pieper Note Added: 0004049
2012-05-01 10:16 pieper Relationship added related to 0001922
2012-08-01 04:23 kikinis Note Added: 0005482
2012-08-22 05:56 jcfr Target Version => Slicer 4.3.0
2012-09-15 10:09 kikinis Status feedback => closed
2013-02-12 09:41 jcfr Fixed in Version => Slicer 4.3.0
2014-02-03 09:27 jcfr Note Added: 0010552
2014-02-03 09:27 jcfr Note Edited: 0010552
2015-06-05 11:21 jcfr Note Added: 0013118
2015-06-05 12:31 pieper Note Added: 0013119
2016-09-08 09:06 lassoan Note Added: 0014080
2016-09-13 18:11 pieper Note Added: 0014094
2017-06-10 08:51 pieper Changeset attached => Slicer master bbaa270d