View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001822 | Slicer4 | Module Editor | public | 2012-03-21 05:43 | 2017-06-10 08:51 |
Reporter | kikinis | Assigned To | pieper | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | Slicer 4.0.1 | ||||
Target Version | Slicer 4.3.0 | Fixed in Version | Slicer 4.3.0 | ||
Summary | 0001822: Split volume results corrupted | ||||
Description | When I do a split and merge on a ct data set, the label maps are wrong. I put the CT data set into ronsexamples in a folder called sarcoma. See the attached before and after image. Workflow: slicer mac nightly 3-19, crop around the sarcoma use the editor with the croped tool. Run grow cut. split merge volume, click on one of the split labels, merge and build. | ||||
Additional Information | From Steve: The images appear to be due to threading corruption. The issue does not occur if I set the global maximum number of threads to be 1 on a 4 core machine. Also does not happen if I reload a scene that has the data file being split. I'm working on an automated test that will reproduce this issue in an installed version of slicer. | ||||
Tags | No tags attached. | ||||
2012-03-21 06:24
|
|
2012-03-21 06:24
|
|
For slicer 4.1 release I made this change: http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=19676 Ron, let me know if you ever see this issue again. For future use test should replicate the issue: it requires some changes in various parts of the code so I will commit it to the trunk after the 4.1 code freeze is over. |
|
Ron showed me what may be a issue that arose in the ChangeLabelEffect being used to remove the background label from a growcut result. This is implemented with this class: class VTK_SLICER_BASE_LOGIC_EXPORT vtkImageLabelChange : public vtkImageToImageFilter |
|
Is there an action item for me on this? |
|
In the HelperBox code, it is written that the multi-threaded version of 'vtkImageThreshold' should not be used until 0001822 (this issue) is solved and this issue mention that the commit adding the same message is resolving the issue ... ... this looks like a "catch 22". Should we update the comment in the code to mention that the multi threading is disabled for some unknown/To-Be-Determined reason and that for more details, developer should refer to issue 1822 ? |
|
May be the underlying issue is addressed by this commit: https://github.com/Kitware/VTK/commit/242656448e ? |
|
I don't think the commit Jc referenced is related - the split operation uses a regular threshold operation and the extents are not different between input and output. |
|
Steve, could you please test if the issue is still there on Mac with current vtk7 version? There is a test that you created that you can run to reproduce the problem. |
|
I tested this on today's Nightly (with vtk7) and I couldn't replicate the issue (good!). I'll go ahead and remove the line that forces single threading[1] and check in the result. |
|
Import 2017-06-07 23:51:09: master bbaa270d 2016-09-13 18:06:54 Details Diff |
BUG: 0001822 is no longer reproducible on current VTK version Tested on today's mac release build. See discussion at http://na-mic.org/Bug/view.php?id=1822 From: Steve Pieper <pieper@isomics.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@25356 3bd1e089-480b-0410-8dfb-8563597acbee |
||
mod - Modules/Scripted/EditorLib/EditUtil.py | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2012-03-21 05:43 | pieper | New Issue | |
2012-03-21 05:43 | pieper | Status | new => assigned |
2012-03-21 05:43 | pieper | Assigned To | => pieper |
2012-03-21 06:24 | pieper | File Added: Before.png | |
2012-03-21 06:24 | pieper | File Added: After.png | |
2012-03-21 07:16 | finetjul | Reporter | pieper => kikinis |
2012-03-21 07:16 | finetjul | Description Updated | |
2012-03-21 07:16 | finetjul | Additional Information Updated | |
2012-03-21 07:17 | finetjul | Product Version | => Slicer 4.0.1 |
2012-03-22 10:20 | pieper | Note Added: 0003911 | |
2012-03-22 10:20 | pieper | Status | assigned => feedback |
2012-03-22 10:20 | pieper | Resolution | open => fixed |
2012-04-20 05:18 | pieper | Note Added: 0004049 | |
2012-05-01 10:16 | pieper | Relationship added | related to 0001922 |
2012-08-01 04:23 | kikinis | Note Added: 0005482 | |
2012-08-22 05:56 | jcfr | Target Version | => Slicer 4.3.0 |
2012-09-15 10:09 | kikinis | Status | feedback => closed |
2013-02-12 09:41 | jcfr | Fixed in Version | => Slicer 4.3.0 |
2014-02-03 09:27 | jcfr | Note Added: 0010552 | |
2014-02-03 09:27 | jcfr | Note Edited: 0010552 | |
2015-06-05 11:21 | jcfr | Note Added: 0013118 | |
2015-06-05 12:31 | pieper | Note Added: 0013119 | |
2016-09-08 09:06 | lassoan | Note Added: 0014080 | |
2016-09-13 18:11 | pieper | Note Added: 0014094 | |
2017-06-10 08:51 | pieper | Changeset attached | => Slicer master bbaa270d |