View Issue Details

IDProjectCategoryView StatusLast Update
0001593Slicer4Module Annotationspublic2012-07-30 07:30
Reporterfinetjul Assigned Tonicole  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSlicer 4.0.0 
Target VersionSlicer 4.0.1Fixed in VersionSlicer 4.2.0 
Summary0001593: Untoggle "Place a fiducial" on click
Description

in the toolbar, after clicking on the place-a-fiducial toolbutton, another click on the button should untoggle the button.
The view transform button seems useless (or obscure at least) and could probably be removed.

TagsNo tags attached.

Relationships

related to 0001645 closednicole update of the mouse mode toolbar 

Activities

kikinis

kikinis

2011-12-22 15:21

developer   ~0003479

Is this in analogy to the crosshairs icon?

finetjul

finetjul

2011-12-22 15:30

administrator   ~0003480

yes

nicole

nicole

2012-04-25 12:21

administrator   ~0004074

svn 19943 resolves this (barring taking out the view transform action, as that's a design decision that was made with Wendy when we worked out the mouse modes).

finetjul

finetjul

2012-04-30 09:28

administrator   ~0004110

I'm not a big fan of the new behavior. I guess it would be good to be tested by Ron and Wendy.
I think having the View Transform action "hides" the annotation feature. It's also odd to have a button always down (never up).
As an improvement, I could see the persistent checkbox being a checkbox on the button instead of a menu option (see what's done in Volume Rendering "Synchronize with Volumes module" button).

finetjul

finetjul

2012-05-02 15:56

administrator   ~0004127

From kikinis:
Why do we need a view transform at all? when in placement mode, then the button is depressed and the mouse pointer should change to remind the user that they are in a different mode. When the action is done, undepress the button to get back into rotate/translate mode.

nicole

nicole

2012-05-03 07:08

administrator   ~0004146

Now that I can change the cursor, I agree that having the view transform button/icon on the tool bar is redundant. I'll work on removing it.

Looking at adding a persistent checkbox on each type of annotation, do you think that would have a better user interaction experience if they wanted to keep annotating a scene with different kinds of annotations? They'd have to click on persistent for each type rather than just once to persistently place all kinds of annotations. Plus that way I'd have to track which ones were persistent or not and the interaction node isn't currently set up that way.

finetjul

finetjul

2012-05-03 07:13

administrator   ~0004147

Last edited: 2012-05-03 07:15

For the persistent checkbox, it wouldn't be for each type of annotation but for all annotations.
The toolbutton and menu will look like that:
/-------\
c F v -------/
------------
F Fiducial R Ruler R ROI ------------
where c is the persistent checkbox, F is the Fiducial icon, v is the menu pointing down arrow, R is the Ruler/ROI icons.
But maybe you should keep also the persistent action in the menu:
/-------\
c F v -------/
-------------
F Fiducial R Ruler R ROI
c Persistent

-------------

nicole

nicole

2012-05-03 09:19

administrator   ~0004150

Last edited: 2012-05-03 09:50

Okay, that makes more sense. I'll try that.
svn 19989 removes the view transfrom action. When you start up Slicer it comes up with the text "Place" in the button, since the annotations are added at run time to the menu. I'll dig up the code I had used to set a default action in a previous iteration of the mouse mode tool bar. Done: svn 19990.

nicole

nicole

2012-05-03 10:01

administrator   ~0004153

For adding the persistence check box to the button, I'm not seeing a way to do it with the QToolButton that I'm using. CTK has the ctkCheckablePushButton, though the widget gallery says that the check button controls the checkable state, rather than being a separate checked flag. Did you have a Qt widget in mind?

finetjul

finetjul

2012-05-03 10:10

administrator   ~0004154

Last edited: 2012-05-03 10:57

It was indeed the original behavior, but the checkbox can actually be customized to be connected to something else.
http://www.commontk.org/docs/html/classctkCheckablePushButton.html

However, looking closely, it won't work in this case because:

  • it's pushbutton not a toolbutton
  • it doesn't support icons
  • it doesn't separate the menu click area from the button area (QToolButton and ctkMenuButton do)
    Some work would need to be done to support that type of behavior.
nicole

nicole

2012-05-03 11:08

administrator   ~0004155

Looks like I can add a menu to the ctkCheckablePushButton, so I'll work on moving the functionality from the QToolButton to a variable of that class, but I have to get some other stuff done first.

jcfr

jcfr

2012-07-27 15:36

administrator   ~0005327

Dear issue reporter,

Good news :) Slicer developers SOLVED the problem you reported - YOU now need to VERIFY and CLOSE this issue.

Issue History

Date Modified Username Field Change
2011-11-29 07:47 finetjul New Issue
2011-11-29 07:47 finetjul Status new => assigned
2011-11-29 07:47 finetjul Assigned To => nicole
2011-12-22 15:21 kikinis Note Added: 0003479
2011-12-22 15:30 finetjul Note Added: 0003480
2012-01-05 04:31 finetjul Relationship added related to 0001645
2012-04-25 12:21 nicole Note Added: 0004074
2012-04-25 12:22 nicole Status assigned => resolved
2012-04-25 12:22 nicole Resolution open => fixed
2012-04-30 09:28 finetjul Note Added: 0004110
2012-05-02 15:56 finetjul Note Added: 0004127
2012-05-03 07:08 nicole Note Added: 0004146
2012-05-03 07:13 finetjul Note Added: 0004147
2012-05-03 07:15 finetjul Note Edited: 0004147
2012-05-03 09:19 nicole Note Added: 0004150
2012-05-03 09:50 nicole Note Edited: 0004150
2012-05-03 10:01 nicole Note Added: 0004153
2012-05-03 10:10 finetjul Note Added: 0004154
2012-05-03 10:57 finetjul Note Edited: 0004154
2012-05-03 11:08 nicole Note Added: 0004155
2012-07-27 15:36 jcfr Note Added: 0005327
2012-07-30 07:30 finetjul Status resolved => closed
2012-07-30 07:30 finetjul Fixed in Version => Slicer 4.2.0 - October 1st 2012