0001263: Simplify qMRMLUtils::qImageToVtkImageData()

ID	Project	Category	View Status	Date Submitted	Last Update

0001263	Slicer4	Core: Base Code	public	2011-07-07 05:46	2017-06-10 08:51

Reporter	finetjul	Assigned To	crmullin
Priority	low	Severity	trivial	Reproducibility	N/A
Status	closed	Resolution	fixed
Product Version
Target Version	Slicer 4.4.0	Fixed in Version	Slicer 4.4.0

Summary	0001263: Simplify qMRMLUtils::qImageToVtkImageData()
Description	qMRMLUtils::qImageToVtkImageData uses its own code. The same function exist in VTK/Rendering/vtkQImageToImageSource It should be using that function. Same thing with vtkImageDataToQImage ?
Additional Information	vtkQImageToImageSource::RequestData() can be fasten by not doing the memcpy at first (vtkQImageToImageSource.cxx:77) because in anyways the image is browse through it.
Tags	No tags attached.

crmullin 2013-08-16 08:21 developer ~0009489	Would it be better to get rid of the extra function call like this? https://github.com/chrismullins/Slicer/commit/4a86a877920cd0c7bdbc6e384524c899cc97e9e7

crmullin 2013-08-17 13:00 developer ~0009494	The vtkQImageToImageSource method is now used internally in qMRMLUtils::qImageToVtkImageData. https://github.com/chrismullins/Slicer/commit/4b579454db70dee25a8498433df3647938d498a3

crmullin 2013-08-19 09:18 developer ~0009513	vtkNew and DeepCopy are now used. https://github.com/chrismullins/Slicer/commit/f004ff9c57d0af5a50724c977982399db41a5823

jcfr 2014-05-13 15:26 administrator ~0011828	Fixed in r23175 See http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=23175

jcfr 2014-09-17 23:01 administrator ~0012546	Closing resolved issues that have not been updated in more than 3 months.

Import 2017-06-07 23:51:09: master 47362cc8 2014-05-13 19:19:59 jcfr Details Diff	ENH: Simplify qMRMLUtils::qImageToVtkImageData using vtkQImageToImageSource. Fixes 0001263 From: Christopher Mullins <christopher.mullins@kitware.com> git-svn-id: http://svn.slicer.org/Slicer4/trunk@23175 3bd1e089-480b-0410-8dfb-8563597acbee
	mod - Libs/MRML/Widgets/CMakeLists.txt	Diff File
	mod - Libs/MRML/Widgets/qMRMLUtils.cxx	Diff File

Date Modified	Username	Field	Change
2011-07-07 05:46	finetjul	New Issue
2011-07-07 05:47	finetjul	Status	new => assigned
2011-07-07 05:47	finetjul	Assigned To	=> finetjul
2011-08-25 09:35	finetjul	Assigned To	finetjul => BenjaminLong
2012-08-21 11:42	jcfr	Assigned To	BenjaminLong => crmullin
2012-08-21 11:44	jcfr	Target Version	=> Slicer 4.3.0
2013-08-16 08:21	crmullin	Note Added: 0009489
2013-08-17 13:00	crmullin	Note Added: 0009494
2013-08-19 09:18	crmullin	Note Added: 0009513
2013-08-27 11:57	jcfr	Target Version	Slicer 4.3.0 => Slicer 4.4.0
2014-05-13 14:29	jcfr	Target Version	Slicer 4.4.0 =>
2014-05-13 14:29	jcfr	Tag Attached: help-wanted
2014-05-13 14:30	jcfr	Assigned To	crmullin => jcfr
2014-05-13 14:30	jcfr	Target Version	=> Slicer 4.4.0
2014-05-13 15:26	jcfr	Assigned To	jcfr => crmullin
2014-05-13 15:26	jcfr	Tag Detached: help-wanted
2014-05-13 15:26	jcfr	Note Added: 0011828
2014-05-13 15:26	jcfr	Status	assigned => resolved
2014-05-13 15:26	jcfr	Fixed in Version	=> Slicer 4.4.0
2014-05-13 15:26	jcfr	Resolution	open => fixed
2014-09-17 22:59	jcfr	Status	resolved => closed
2014-09-17 23:01	jcfr	Note Added: 0012546
2017-06-10 08:51	jcfr	Changeset attached	=> Slicer master 47362cc8