Import 2017-06-07 23:51:09: master 7d35e73b

Diff Back to Repository
Author Committer Branch Timestamp Parent
lassoan lassoan master 2015-12-10 12:15:03 master 79665b39
Changeset

BUG: Fixed vtkTransform::ApplyTransformMatrix crash

How to reproduce:

c=getNode('FullRainbow')
m=vtk.vtkMatrix4x4()
c.ApplyTransformMatrix(m)

Problem:
vtkTransform::ApplyTransform and vtkTransform::ApplyTransformMatrix are calling each other. Most of the time at least one is overridden, so no crash occurs.

Solution:
Removed calling of vtkTransform::ApplyTransformMatrix from vtkTransform::ApplyTransform. If a class has a more efficient version of transform application for linear transforms then this call can be added to vtkTransform::ApplyTransform in that specific class.
Removed vtkTransform::ApplyTransformMatrix where it is not necessary (when it's just a more complicated and possibly slower version of ApplyTransform).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24813 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLFiducialListNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLFiducialListNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLModelDisplayNode.h Diff File
mod - Libs/MRML/Core/vtkMRMLROINode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLROINode.h Diff File
mod - Libs/MRML/Core/vtkMRMLTransformableNode.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLTransformableNode.h Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationAngleNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationAngleNode.h Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationROINode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationRulerNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationRulerNode.h Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationSnapshotNode.cxx Diff File
mod - Modules/Loadable/Annotations/MRML/vtkMRMLAnnotationSnapshotNode.h Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.cxx Diff File
mod - Modules/Loadable/Markups/MRML/vtkMRMLMarkupsNode.h Diff File