Slicer: 2145-support-for-installing-extension-from-file de7d5119

Author Committer Branch Timestamp Parent
jcfr jcfr 2145-support-for-installing-extension-from-file 2013-06-10 11:36:21 2145-support-for-installing-extension-from-file 03108897
Changeset

STYLE: Explanation related to commit r22092

gp_item_default_embedded_path is used to compute default_embedded_path [1] which is then used to set embedded_item[2].

Then, embedded_item is used to compute gp_resolve_embedded_item [3]

Looking at the implementation of gp_resolve_embedded_item [4], we can see that properly computing embedded_item is important to set variable resolved_embedded_item used to determine if item should be copied or not into the bundle. [5]

Note also that the version of BundleUtilities.cmake and GetPrerequisites used in Slicer have been updated [6] to support @rpath. Associated CMake topic is [7], it is also currently being discussed on CMake developer list [8]

That is why the code within the function gp_item_default_embedded_path_override
has been implemented.

[1] http://cmake.org/gitweb?p=stage/cmake.git;a=blob;f=Modules/BundleUtilities.cmake;h=6c49174ce4ec3611310e8b4b67ee9fcc0763d59b;hb=2f770aad1f77ada793291d55048472f692bb4535#l374

[2] http://cmake.org/gitweb?p=stage/cmake.git;a=blob;f=Modules/BundleUtilities.cmake;h=6c49174ce4ec3611310e8b4b67ee9fcc0763d59b;hb=2f770aad1f77ada793291d55048472f692bb4535#l385

[3] http://cmake.org/gitweb?p=stage/cmake.git;a=blob;f=Modules/BundleUtilities.cmake;h=6c49174ce4ec3611310e8b4b67ee9fcc0763d59b;hb=2f770aad1f77ada793291d55048472f692bb4535#l423

[4] http://cmake.org/gitweb?p=stage/cmake.git;a=blob;f=Modules/GetPrerequisites.cmake;h=528c540392f12d9dcb51ad608d29a632b6ac5a8e;hb=2f770aad1f77ada793291d55048472f692bb4535#l476

[5] http://cmake.org/gitweb?p=stage/cmake.git;a=blob;f=Modules/BundleUtilities.cmake;h=6c49174ce4ec3611310e8b4b67ee9fcc0763d59b;hb=2f770aad1f77ada793291d55048472f692bb4535#l428

[6] http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=22023

[7] http://cmake.org/gitweb?p=stage/cmake.git;a=shortlog;h=refs/heads/tweak-bundleutilities-for-rpath

[8] http://comments.gmane.org/gmane.comp.programming.tools.cmake.user/46454

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22093 3bd1e089-480b-0410-8dfb-8563597acbee

mod - CMake/SlicerCPackBundleFixup.cmake.in Diff File