Slicer: 2145-support-for-installing-extension-from-file 8e0ba984

Author Committer Branch Timestamp Parent
jcfr jcfr 2145-support-for-installing-extension-from-file 2013-10-01 15:24:47 2145-support-for-installing-extension-from-file d3f2322f
Changeset

ENH: Improve readability of MRML tests using vtkNew where possible

Simplify code removing tests for null object already being done
in the helper macro "EXERCISE_BASIC_OBJECT_METHODS"

For example, the following should not be needed:

vtkNew<vtkFoo> foo;
if (foo.GetPointer() == 0)
{
std::cerr << "Failed to instantiate vtkFoo" << std::endl;
}

Instead, the following should be used:

EXERCISE_BASIC_OBJECT_METHODS(foo.GetPointer())

Remove use of unnecessary vtkSmartPointer to check return value. Indeed,
since the operator "==" of the vtkSmartPointer is overloaded to compare with
the pointed object, there is no need to used a smart pointer. [1]

// ---------
vtkSmartPointer<vtkMRMLDisplayableNode> pnode = node1->GetDisplayableNode();
std::cout << "GetDisplayableNode returned "
<< (pnode == NULL ? "null" : "not null")
<< std::endl;
// ---------

has been changed into

// ---------
vtkMRMLDisplayableNode* pnode = node1->GetDisplayableNode();
std::cout << "GetDisplayableNode returned "
<< (pnode == NULL ? "null" : "not null")
<< std::endl;
// ---------

[1] https://github.com/Kitware/VTK/blob/0e0674a3695fdeaf01ce87dfc04e32111b7402e0/Common/vtkSmartPointerBase.h#L104

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22538 3bd1e089-480b-0410-8dfb-8563597acbee

mod - Base/Logic/Testing/vtkDataIOManagerLogicTest1.cxx Diff File
mod - Base/Logic/Testing/vtkSlicerApplicationLogicTest1.cxx Diff File
mod - Base/QTCore/Testing/Cxx/qSlicerCoreIOManagerTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLBSplineTransformNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLCameraNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLClipModelsNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLColorNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLColorTableNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLColorTableStorageNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDiffusionImageVolumeNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDiffusionTensorVolumeDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDiffusionTensorVolumeNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayableHierarchyNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayableHierarchyNodeTest2.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayableHierarchyNodeTest3.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLDisplayableNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLFiberBundleNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLFiberBundleTubeDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLFreeSurferModelStorageNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLGlyphableVolumeDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLHierarchyNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLHierarchyNodeTest3.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLModelHierarchyNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLModelNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLNRRDStorageNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLProceduralColorNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLROIListNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLROINodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLScalarVolumeDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLScalarVolumeNodeTest2.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneImportIDModelHierarchyParentIDConflictTest.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneTest2.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeStoreSceneTest.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSceneViewNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSelectionNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLSnapshotClipNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLTensorVolumeNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLUnitNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLVectorVolumeDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLVolumeDisplayNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLVolumeHeaderlessStorageNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkMRMLVolumeNodeTest1.cxx Diff File
mod - Libs/MRML/Core/Testing/vtkObserverManagerTest1.cxx Diff File
mod - Libs/MRML/Core/vtkMRMLCoreTestingMacros.h Diff File
mod - Libs/MRML/DisplayableManager/Testing/Cxx/vtkMRMLSliceViewDisplayableManagerFactoryTest.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLAbstractLogicSceneEventsTest.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLApplicationLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLColorLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLDisplayableHierarchyLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLLayoutLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLLayoutLogicTest2.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLModelHierarchyLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest1.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest2.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest3.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest4.cxx Diff File
mod - Libs/MRML/Logic/Testing/Cxx/vtkMRMLSliceLogicTest5.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorListViewEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorListViewTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorModelTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorPickerWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorPickerWidgetTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorPickerWidgetTest2.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorPickerWidgetTest3.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorTableViewEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLColorTableViewTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLModelTreeViewTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNavigationViewEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNavigationViewTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest3.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest4.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest5.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest6.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest7.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLNodeComboBoxTest8.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLROIWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLScalarInvariantComboBoxEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLScalarInvariantComboBoxTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSceneCategoryModelTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSceneColorTableModelTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSliceWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSliceWidgetTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLSliceWidgetTest2.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLTreeViewEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeInfoWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeInfoWidgetTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeThresholdWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeThresholdWidgetTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLVolumeThresholdWidgetTest2.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLWindowLevelWidgetEventTranslatorPlayerTest1.cxx Diff File
mod - Libs/MRML/Widgets/Testing/qMRMLWindowLevelWidgetTest1.cxx Diff File
mod - Libs/vtkITK/Testing/VTKITKBSplineTransform.cxx Diff File
mod - Libs/vtkTeem/Testing/vtkDiffusionTensorMathematicsTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationDisplayNodeTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationLinesStorageNodeTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationNodesUndoTest1.cxx Diff File
mod - Modules/Loadable/Annotations/Testing/Cxx/vtkMRMLAnnotationRulerNodeTest1.cxx Diff File
mod - Modules/Loadable/CropVolume/Testing/vtkMRMLCropVolumeParametersNodeTest1.cxx Diff File
mod - Modules/Loadable/Markups/Testing/Cxx/vtkMRMLMarkupsDisplayNodeTest1.cxx Diff File
mod - Modules/Loadable/VolumeRendering/Testing/Cxx/vtkMRMLVolumePropertyNodeTest1.cxx Diff File