Import 2017-06-07 23:51:09: master dc22481d

Diff Back to Repository
Author Committer Branch Timestamp Parent
jcfr jcfr master 2014-07-18 03:41:24 master 978e9dd6
Changeset

BUG: Fix memory initialization in vtkMRMLVolumeHeaderlessStorageNode

This commits fixes a problem discovered while running the test
vtkMRMLVolumeHeaderlessStorageNodeTest1 through valgrind.

[...]

==423== Conditional jump or move depends on uninitialised value(s)
==423== at 0x53AB10F: vtkMRMLVolumeHeaderlessStorageNode::SetFileDimensions(int, int, int) (in /home/jchris/Projects/Slicer-2-SuperBuild-Debug/Slicer-build/bin/libMRMLCore.so)
==423== by 0x53A762A: vtkMRMLVolumeHeaderlessStorageNode::vtkMRMLVolumeHeaderlessStorageNode() (vtkMRMLVolumeHeaderlessStorageNode.cxx:56)
==423== by 0x53A7480: vtkMRMLVolumeHeaderlessStorageNode::New() (vtkMRMLVolumeHeaderlessStorageNode.cxx:39)
==423== by 0x621EBF: vtkNew<vtkMRMLVolumeHeaderlessStorageNode>::vtkNew() (vtkNew.h:66)
==423== by 0x61BC65: vtkMRMLVolumeHeaderlessStorageNodeTest1(int, char**) (vtkMRMLVolumeHeaderlessStorageNodeTest1.cxx:21)
==423== by 0x4729AC: main (MRMLCoreCxxTests.cxx:616)

[...]

==423== Conditional jump or move depends on uninitialised value(s)
==423== at 0x53AB10F: vtkMRMLVolumeHeaderlessStorageNode::SetFileDimensions(int, int, int) (in /home/jchris/Projects/Slicer-2-SuperBuild-Debug/Slicer-build/bin/libMRMLCore.so)
==423== by 0x53A762A: vtkMRMLVolumeHeaderlessStorageNode::vtkMRMLVolumeHeaderlessStorageNode() (vtkMRMLVolumeHeaderlessStorageNode.cxx:56)
==423== by 0x53A7480: vtkMRMLVolumeHeaderlessStorageNode::New() (vtkMRMLVolumeHeaderlessStorageNode.cxx:39)
==423== by 0x53A7523: vtkMRMLVolumeHeaderlessStorageNode::CreateNodeInstance() (vtkMRMLVolumeHeaderlessStorageNode.cxx:39)
==423== by 0x61BD63: vtkMRMLVolumeHeaderlessStorageNodeTest1(int, char**) (vtkMRMLVolumeHeaderlessStorageNodeTest1.cxx:25)
==423== by 0x4729AC: main (MRMLCoreCxxTests.cxx:616)

[...]

git-svn-id: http://svn.slicer.org/Slicer4/trunk@23460 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Libs/MRML/Core/vtkMRMLVolumeHeaderlessStorageNode.cxx Diff File