Import 2017-06-07 23:51:09: master a064b4bc

Diff Back to Repository
Author Committer Branch Timestamp Parent
jcfr jcfr master 2015-07-17 01:00:47 master 6fac40e3
Changeset

BUG: Update VTK to include fix for memory leak in vtkSys SystemTools.

See Slicer/VTK@4b46455

Author: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
Date: Thu Jul 16 14:54:10 2015 -0400

KWSys-SystemTools: Fix memory leak in DetectFileType

A more elaborated patch including update of the test case has been
pushed upstream: http://review.source.kitware.com/#/c/20003

This commit fixes the leak found using valgrind memcheck tool:

==29339== 512 bytes in 2 blocks are definitely lost in loss record 2,179 of 2,448
==29339==    at 0x4C2B800: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==29339==    by 0x28396AB8: vtksys::SystemTools::DetectFileType(char const*, unsigned long, double) (SystemTools.cxx:4142)
==29339==    by 0x1018F9229: vtkSlicerColorLogic::FindColorFiles(std::vector&lt;std::string, std::allocator&lt;std::string> > const&) (vtkSlicerColorLogic.cxx:177)
==29339==    by 0x1018F86EA: vtkSlicerColorLogic::FindDefaultColorFiles() (vtkSlicerColorLogic.cxx:100)
==29339==    by 0x9844613: vtkMRMLColorLogic::AddDefaultFileNodes() (vtkMRMLColorLogic.cxx:1016)
==29339==    by 0x983DAF6: vtkMRMLColorLogic::AddDefaultColorNodes() (vtkMRMLColorLogic.cxx:144)
==29339==    by 0x983D673: vtkMRMLColorLogic::OnMRMLSceneNewEvent() (vtkMRMLColorLogic.cxx:85)
==29339==    by 0x983D629: vtkMRMLColorLogic::SetMRMLSceneInternal(vtkMRMLScene*) (vtkMRMLColorLogic.cxx:78)
==29339==    by 0x982B4F9: vtkMRMLAbstractLogic::SetMRMLScene(vtkMRMLScene*) (vtkMRMLAbstractLogic.cxx:281)
==29339==    by 0x8E70F0A: qSlicerAbstractCoreModule::setMRMLScene(vtkMRMLScene*) (qSlicerAbstractCoreModule.cxx:168)
==29339==    by 0x101492780: qSlicerColorsModule::setMRMLScene(vtkMRMLScene*) (qSlicerColorsModule.cxx:132)
==29339==    by 0x8EA2B1A: qSlicerModuleFactoryManager::loadModule(QString const&, QString const&) (qSlicerModuleFactoryManager.cxx:181)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24439 3bd1e089-480b-0410-8dfb-8563597acbee
mod - SuperBuild/External_VTKv6.cmake Diff File