Import 2017-06-07 23:51:09: master 3dd75da5

Diff Back to Repository
Author Committer Branch Timestamp Parent
jcfr jcfr master 2015-09-01 14:00:04 master 03d93916
Changeset

BUG: qSlicerNodeWriter: Default parameters allowed incorrect usage

This commit fixes the following warning obtained when compiling
using clang and c++11.

Slicer/Modules/Loadable/Models/qSlicerModelsModule.cxx:165:44: warning: 'this' pointer cannot be null in
well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
QStringList() << "vtkMRMLModelNode", this));
^~~~

The 'this' pointer was interpreted as boolean. To ensure complete proper
usage, the default parameters were removed, thus forcing compiler errors
that were easy to identify and fix.

From: Hans Johnson <hans-johnson@uiowa.edu>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@24515 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Base/QTGUI/qSlicerNodeWriter.h Diff File
mod - Modules/Loadable/Annotations/qSlicerAnnotationsModule.cxx Diff File
mod - Modules/Loadable/Colors/qSlicerColorsModule.cxx Diff File
mod - Modules/Loadable/DoubleArrays/qSlicerDoubleArraysModule.cxx Diff File
mod - Modules/Loadable/Markups/qSlicerMarkupsModule.cxx Diff File
mod - Modules/Loadable/Models/qSlicerModelsModule.cxx Diff File
mod - Modules/Loadable/SceneViews/qSlicerSceneViewsModule.cxx Diff File
mod - Modules/Loadable/TractographyDisplay/qSlicerTractographyDisplayModule.cxx Diff File
mod - Modules/Loadable/Transforms/qSlicerTransformsModule.cxx Diff File
mod - Modules/Loadable/VolumeRendering/qSlicerVolumeRenderingModule.cxx Diff File
mod - Modules/Loadable/Volumes/qSlicerVolumesModule.cxx Diff File