Import 2017-06-07 23:51:09: master 3fb107bc

Author Committer Branch Timestamp Parent
jcfr jcfr master 2016-07-19 18:27:10 master 0da14d3b
Affected Issues 0004041: packaging issues on MacOS version (at least on r24523)
Changeset

COMP: BRAINSTools: Address MacOSX packaging issue. Fix 0004041

$ git shortlog 7859819..47dc8e6 --no-merges
Isaiah Norton (1):
COMP: Address MacOSX packaging issue.

The BRAINS CMAKE_OSX_RPATH default no longer matched the Slicer default [1].

Due to this setting, the RPATH for BRAINS libraries was not being
detected and replaced correctly by the Slicer fixup_bundle procedure.

Specifically, as far as I can tell, having a pre-set @rpath in the
installed libraries caused the fixup_bundle procedure to copy the
(fixed) libraries into the Slicer-4.5 base directory, rather than
fixing in-place the libraries in Slicer-4.5/cli-modules. This caused
two copies of the libraries to be included in the distribution bundle
[2], one of which was un-patched. This un-patched version is referred
to by all other libraries, causing dlopen failures. The end result
is that BRAINS could not be used in shared-library mode on Mac [3].

See:
[1] https://github.com/Slicer/ITK/commit/8ac0d6013b76238f9d84de906c14b493addf8ac8
[2] http://www.na-mic.org/Bug/view.php?id=4041
[3] http://massmail.spl.harvard.edu/public-archives/slicer-users/2016/010782.html

From: Isaiah Norton <isaiah.norton@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25241 3bd1e089-480b-0410-8dfb-8563597acbee

mod - SuperBuild.cmake Diff File