Import 2017-06-07 23:51:09: master 67c4ae61

Diff Back to Repository
Author Committer Branch Timestamp Parent
jcfr jcfr master 2017-04-25 23:17:59 master 350b63cc
Changeset

ENH: Remove unused VolumeRenderingReplacements fixed point raycaster override

This specialized implementation was first introduced in r4673 (ENH: Integrated
VTK ray cast classes, started with modifications for incremental update) by
copying the VTK implementation of the FixedPoint volume caster and was
most likely introduced to better support volume rendering compositing
with polygonal data.

Based on the discussion of the Developer meeting from April 25th [1] and
considering that non of the classes found in VolumeRenderingReplacements
are instantiated when using either the CPU or GPU volume mapper currently
available in Slicer, this commit removes them.

[1] https://www.slicer.org/wiki/Developer_Meetings/20170425

They most likely became obsolete with one of these commits:

  • r23887 (ENH: Remove unused VTK OpenGL 3D Texture based volume rendering classes)

  • r23888 (ENH: Remove unused NCI volume rendering classes)

  • r23889 (ENH: Remove unused NCI GPU MultiVolume rendering classes).

Also worth noting that since then, the VTK implementation has matured
and fixes can now easily be contributed upstream.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25972 3bd1e089-480b-0410-8dfb-8563597acbee
mod - Modules/Loadable/VolumeRendering/CMakeLists.txt Diff File
mod - Modules/Loadable/VolumeRendering/Logic/CMakeLists.txt Diff File
mod - Modules/Loadable/VolumeRendering/Logic/vtkSlicerVolumeRenderingLogic.cxx Diff File
mod - Modules/Loadable/VolumeRendering/MRMLDM/CMakeLists.txt Diff File
mod - Modules/Loadable/VolumeRendering/MRMLDM/vtkMRMLVolumeRenderingDisplayableManager.cxx Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/CMakeLists.txt Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointRayCastImage.cxx Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointRayCastImage.h Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointVolumeRayCastCompositeGOHelper.cxx Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointVolumeRayCastCompositeGOHelper.h Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointVolumeRayCastCompositeGOShadeHelper.cxx Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointVolumeRayCastCompositeGOShadeHelper.h Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointVolumeRayCastCompositeHelper.cxx Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointVolumeRayCastCompositeHelper.h Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointVolumeRayCastCompositeShadeHelper.cxx Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointVolumeRayCastCompositeShadeHelper.h Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointVolumeRayCastHelper.cxx Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointVolumeRayCastHelper.h Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointVolumeRayCastMIPHelper.cxx Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointVolumeRayCastMIPHelper.h Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointVolumeRayCastMapper.cxx Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerFixedPointVolumeRayCastMapper.h Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerOpenGLRayCastImageDisplayHelper.cxx Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerOpenGLRayCastImageDisplayHelper.h Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerRayCastImageDisplayHelper.cxx Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerRayCastImageDisplayHelper.h Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerVolumeRenderingFactory.cxx Diff File
rm - Modules/Loadable/VolumeRendering/VolumeRenderingReplacements/vtkSlicerVolumeRenderingFactory.h Diff File