View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003737 | Slicer4 | Core: Extensions | public | 2014-06-13 12:33 | 2014-09-17 23:01 |
Reporter | fbudin | Assigned To | matthew-woehlke | ||
Priority | normal | Severity | major | Reproducibility | always |
Status | closed | Resolution | no change required | ||
Product Version | |||||
Target Version | Slicer 4.4.0 | Fixed in Version | Slicer 4.4.0 | ||
Summary | 0003737: Error when trying to update an extension using SVN with slicerExtensionWizard | ||||
Description | When trying to update my extension using the slicerExtensionWizard, I get the following error message: extension repository not found However, if I check what is in my repository, a ".svn" is there. The command line I tried to commit my code was: | ||||
Tags | No tags attached. | ||||
To verify: /opt/Francois/temp/NAMICJANSLC2014/ExtensionsIndex-build-Slicer4.3.1-r22599/SPHARM-PDM/.svn exists? If you run 'svn info' in the directory you passed to the wizard (i.e. the above without the '/.svn'), what output do you get? |
|
.svn exists. I have just updated the directory. Here is the output: |
|
Um... You seem to be missing the working copy path. What version of svn are you using? I believe that was added in 1.7. Here's an example of what I get: Path: . |
|
Indeed, I am using svn version 1.6.11 (r934486). |
|
Using a virtual machine with Ubuntu 14.04 and svn 1.8.8, I now get the following message: |
|
This is explained because, the extension metadata are not specified in your top level CMakeLists.txt [1] You have then two options: 1) Set the extension metadata in your top level CMakeLists @Matt: What do you think ? |
|
Indeed, in most (if not all) my projects, I specify the extension variables in Common.cmake which is included both in my Superbuild and in the sub-project cmake file. Should I directly include all the extension variables in CMakeLists.txt? It is not an issue if I need to since I just need to move a few lines of CMake code. |
|
If possible, it would make your extension more "standard" and allow the wizard to work. That said, if you have any advice on how we could also improve the Superbuild extension template [1], that would be great. [1] https://github.com/Slicer/Slicer/tree/master/Utilities/Templates/Extensions/SuperBuild |
|
I modified my CMake code: However, I still had 2 issues: This new way of contributing code seems great, but not quite adapted to my purpose. I will commit the new code using the manual way. |
|
1) For svn username / password ... I will extend the system so that you could directly specify EXTENSION_SVNUSERNAME and EXTENSION_SVNPASSWORD in your CMakeLists. 2) Example of invalid branch name is here: https://github.com/Slicer/ExtensionsIndex/pull/688 |
|
1) That would indeed be great
I could correct [2] by adapting the name of the project in the CMakeLists.txt file. |
|
EXTENSION_SVNUSERNAME and EXTENSION_SVNPASSWORD should already be recognized. (You do need to add them to your CMakeLists.txt, though.) For (2), what does your CMakeLists.txt look like? If it could reasonably look like: if(NOT SUPERBUILD) That might work better. (The first project() call is used. The parser is meant to work without a build directory required, so it is rather simple-minded - basically a glorified regex matcher - as a result.) |
|
Thanks for the clarification. My project is built with Superbuild set to ON even in the case of an extension, so I would have to modify my CMakeLists a little more than that, but that would still be possible to match the expected structure. |
|
What about changing: // ----------------------------- [...] if(${LOCAL_PROJECT_NAME}SUPERBUILD) into something like // ----------------------------- [...] option(${PROJECT_NAME}_SUPERBUILD "Build ${PROJECT_NAME} and the projects it depends on via SuperBuild.cmake." ON) [...] if(${PROJECT_NAME}_SUPERBUILD) |
|
Closing this issue. It turns out that: was sufficient. @Francois: In Slicer, I was thinking to change the SVN minimum required version. Would that be an issue ? @Matt: I added an entry into the ExtensionWizard wiki page mentioning that SVN >= 1.7 was required. See http://wiki.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/ExtensionWizard#Requirements Also created issue 0003740 to add version checking to the wizard |
|
Closing resolved issues that have not been updated in more than 3 months. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2014-06-13 12:33 | fbudin | New Issue | |
2014-06-13 12:33 | fbudin | Status | new => assigned |
2014-06-13 12:33 | fbudin | Assigned To | => jcfr |
2014-06-13 12:58 | jcfr | Assigned To | jcfr => matthew-woehlke |
2014-06-13 12:58 | jcfr | Target Version | => Slicer 4.4.0 |
2014-06-13 13:10 | matthew-woehlke | Note Added: 0012063 | |
2014-06-13 13:10 | matthew-woehlke | Status | assigned => feedback |
2014-06-13 13:12 | fbudin | Note Added: 0012064 | |
2014-06-13 14:10 | matthew-woehlke | Note Added: 0012066 | |
2014-06-14 08:02 | fbudin | Note Added: 0012069 | |
2014-06-16 06:30 | fbudin | Note Added: 0012072 | |
2014-06-16 06:56 | jcfr | Note Added: 0012073 | |
2014-06-16 07:02 | fbudin | Note Added: 0012074 | |
2014-06-16 07:07 | fbudin | Note Edited: 0012074 | |
2014-06-16 07:07 | fbudin | Note Edited: 0012074 | |
2014-06-16 07:07 | fbudin | Note Edited: 0012074 | |
2014-06-16 07:16 | jcfr | Note Added: 0012075 | |
2014-06-16 07:47 | fbudin | Note Added: 0012076 | |
2014-06-16 07:58 | jcfr | Note Added: 0012077 | |
2014-06-16 07:59 | jcfr | Note Edited: 0012077 | |
2014-06-16 08:16 | fbudin | Note Added: 0012078 | |
2014-06-16 09:45 | matthew-woehlke | Note Added: 0012079 | |
2014-06-16 09:55 | fbudin | Note Added: 0012080 | |
2014-06-17 05:42 | jcfr | Note Added: 0012081 | |
2014-06-17 05:52 | jcfr | Relationship added | related to 0003740 |
2014-06-17 05:53 | jcfr | Note Added: 0012082 | |
2014-06-17 05:53 | jcfr | Status | feedback => resolved |
2014-06-17 05:53 | jcfr | Fixed in Version | => Slicer 4.4.0 |
2014-06-17 05:53 | jcfr | Resolution | open => no change required |
2014-06-21 23:29 | jcfr | Note Edited: 0012082 | |
2014-09-17 22:59 | jcfr | Status | resolved => closed |
2014-09-17 23:01 | jcfr | Note Added: 0012528 |