View Revisions: Issue #4212

Summary 0004212: git core.autocrlf=true option causes erroneously modified source files and test failures
Revision 2016-06-17 15:56 by msmolens
Steps To Reproduce
  • On Windows, install Git for Windows from http://git-for-windows.github.io.

  • I believe the default install options configure core.autocrlf=true. Verify that using 'git config --list'.

  • Checkout Slicer, build, and test.

Results:

$ git status
modified: Testing/Data/Input/ExecutionModelTourTest.mrml
modified: Utilities/Scripts/SlicerWizard/version.py

$ ctest -C Release -R MergeModelsTestCompare -V
...
470: CMake Error at C:/path/to/Slicer/Modules/CLI/MergeModels/Testing/run_MergeModelsTest.cmake:34 (message):
470: C:/path/to/SR/Slicer-build/Testing/Temporary/sphereCube.vtp does not match
470: C:/path/to/Slicer/Modules/CLI/MergeModels/Testing/../Data/Baseline/sphereCube.vtp!
...

$ file /path/to/SR/Slicer-build/Testing/Temporary/sphereCube.vtp
/path/to/Slicer/Slicer-build/Testing/Temporary/sphereCube.vtp: XML 1.0 document, ASCII text, with very long lines

$ file /path/to/Slicer/Modules/CLI/MergeModels/Data/Baseline/sphereCube.vtp
/path/to/Slicer/Modules/CLI/MergeModels/Data/Baseline/sphereCube.vtp: XML 1.0 document, ASCII text, with very long lines, with CRLF line terminators

Revision 2016-06-17 15:55 by msmolens
Steps To Reproduce
  • On Windows, install Git for Windows from http://git-for-windows.github.io.

  • I believe the default install options configure core.autocrlf=true. Verify that using 'git config --list'.

  • Checkout Slicer, build, and test.

Results:

$ git status
modified: Testing/Data/Input/ExecutionModelTourTest.mrml
modified: Utilities/Scripts/SlicerWizard/version.py

$ ctest -C Release -R MergeModelsTestCompare -V
...
470: CMake Error at C:/path/to/Slicer/Modules/CLI/MergeModels/Testing/run_MergeModelsTest.cmake:34 (message):
470: C:/path/to/SR/Slicer-build/Testing/Temporary/sphereCube.vtp does not match
470: C:/path/to/Slicer/Modules/CLI/MergeModels/Testing/../Data/Baseline/sphereCube.vtp!
...

$ file /path/to/Slicer/Slicer-build/Testing/Temporary/sphereCube.vtp
/path/to/Slicer/Slicer-build/Testing/Temporary/sphereCube.vtp: XML 1.0 document, ASCII text, with very long lines

$ file /path/to/Slicer/Modules/CLI/MergeModels/Data/Baseline/sphereCube.vtp
/path/to/Slicer/Modules/CLI/MergeModels/Data/Baseline/sphereCube.vtp: XML 1.0 document, ASCII text, with very long lines, with CRLF line terminators

Revision 2016-06-17 15:37 by msmolens
Steps To Reproduce
  • On Windows, install Git for Windows from http://git-for-windows.github.io.

  • I believe the default install options configure core.autocrlf=true. Verify that using 'git config --list'.

  • Checkout Slicer, build, and test.

Results:

$ git status
modified: Testing/Data/Input/ExecutionModelTourTest.mrml
modified: Utilities/Scripts/SlicerWizard/version.py

$ ctest -C Release -R MergeModelsTestCompare -V
...
470: CMake Error at C:/path/to/Slicer/Modules/CLI/MergeModels/Testing/run_MergeModelsTest.cmake:34 (message):
470: C:/path/to/SR/Slicer-build/Testing/Temporary/sphereCube.vtp does not match
470: C:/path/to/Slicer/Modules/CLI/MergeModels/Testing/../Data/Baseline/sphereCube.vtp!
...

Revision 2016-06-17 15:36 by msmolens
Steps To Reproduce
  • On Windows, install Git for Windows from http://git-for-windows.github.io.

  • I believe the default install options configure core.autocrlf=true. Verify that using 'git config --list'.

  • Checkout Slicer, build, and test.

Results:

$ git status
modified: Testing/Data/Input/ExecutionModelTourTest.mrml
modified: Utilities/Scripts/SlicerWizard/version.py

$ ctest -C Release -R MergeModelsTestCompare -V
...
470: CMake Error at C:/path/to/Slice/Modules/CLI/MergeModels/Testing/run_MergeModelsTest.cmake:34 (message):
470: C:/path/to/SR/Slicer-build/Testing/Temporary/sphereCube.vtp does not match
470: C:/path/to/Slicer/Modules/CLI/MergeModels/Testing/../Data/Baseline/sphereCube.vtp!
...

Revision 2016-06-17 15:35 by msmolens
Steps To Reproduce
  • On Windows, install Git for Windows from http://git-for-windows.github.io.

  • I believe the default install options configure core.autocrlf=true. Verify that using 'git config --list'.

  • Checkout Slicer, build, and test.

Results:

$ git status
modified: Testing/Data/Input/ExecutionModelTourTest.mrml
modified: Utilities/Scripts/SlicerWizard/version.py

470: CMake Error at C:/path/to/Slice/Modules/CLI/MergeModels/Testing/run_MergeModelsTest.cmake:34 (message):
470: C:/path/to/SR/Slicer-build/Testing/Temporary/sphereCube.vtp does not match
470: C:/path/to/Slicer/Modules/CLI/MergeModels/Testing/../Data/Baseline/sphereCube.vtp!